From: Jiri Slaby <jirislaby@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Fietkau <nbd@openwrt.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna
Date: Tue, 5 Dec 2023 14:10:11 +0100 [thread overview]
Message-ID: <dde1fdb0-c905-4c46-baf6-cdc1011df4cc@kernel.org> (raw)
In-Reply-To: <874jgwrgxu.fsf@kernel.org>
On 05. 12. 23, 13:07, Kalle Valo wrote:
> "Jiri Slaby (SUSE)" <jirislaby@kernel.org> writes:
>
>> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
>> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
>> parsing and add missing calibration data") added it, but did not use it
>> in any way. Neither, there is a later user.
>>
>> So remove that unused member.
>>
>> [1] https://github.com/jirislaby/clang-struct
>
> clang-struct looks really nice, especially if it can also find unused
> structures.
It can...
> What about unused defines or enums, any chance to find those
> in the future? :)
All of that is IMO possible (I'm not completely sure about macros,
despite clang ASTs provide a lot of info. Incl. info about them and
their expansion).
It's all limited only by man-force: me.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-12-05 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:15 Jiri Slaby (SUSE)
2023-12-05 12:07 ` Kalle Valo
2023-12-05 13:10 ` Jiri Slaby [this message]
2023-12-05 14:45 ` Kalle Valo
2023-12-07 10:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde1fdb0-c905-4c46-baf6-cdc1011df4cc@kernel.org \
--to=jirislaby@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®