Re: [PATCH] [v1] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

[Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>]

On 15/02/2022 19:40, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> Description: Creating binding for the GXP watchdog timer to be used in
>  the device tree. This along with the
>   dt-bindings: timer: Add HPE GXP Timer binding patch will be used to
>    create the basic dts and dtsi for GXP.
> Information: GXP is the name of the HPE SoC.
>  This SoC is used to implement BMC features of HPE servers
>   (all ProLiant, Synergy, and many Apollo, and Superdome machines)
>    It does support many features including:
>         ARMv7 architecture, and it is based on a Cortex A9 core
>         Use an AXI bus to which
>                 a memory controller is attached, as well as
>                  multiple SPI interfaces to connect boot flash,
>                  and ROM flash, a 10/100/1000 Mac engine which
>                  supports SGMII (2 ports) and RMII
>                 Multiple I2C engines to drive connectivity with a
> 				 host infrastructure
>                 A video engine which support VGA and DP, as well as
>                  an hardware video encoder
>                 Multiple PCIe ports
>                 A PECI interface, and LPC eSPI
>                 Multiple UART for debug purpose, and Virtual UART for
>                  host connectivity
>                 A GPIO engine.

All this commit msg looks irrelevant, obfuscating and duplicating the
same message.

> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
>  .../bindings/watchdog/hpe,gxp-wdt.yaml        | 37 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> new file mode 100644
> index 000000000000..6044496b4968
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP Controlled Watchdog
> +
> +allOf:
> +  - $ref: "watchdog.yaml#"
> +
> +maintainers:
> +  - Nick Hawkins <nick.hawkins@hpe.com>
> +  - Jean-Marie Verdun <verdun@hpe.com>
> +
> +properties:
> +  compatible:
> +    const: hpe,gxp-wdt
> +
> +  reg:
> +    items:
> +      - description: WDGRST register
> +      - description: WDGCS register
> +

Quite ascetic bindings - no clocks? no power-domains? interrupts?

> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    watchdog0:  watchdog@c0000090 {
> +      compatible = "hpe,gxp-wdt";
> +      reg = <0xc0000090 0x02>, <0xc0000096 0x01>;
> +    };
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f41088418aae..8c96f4db900c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8385,6 +8385,12 @@ L:	linux-efi@vger.kernel.org
>  S:	Maintained
>  F:	block/partitions/efi.*
>  
> +GXP WATCHDOG TIMER
> +M:	Nick Hawkins <nick.hawkins@hpe.com>
> +M:	Jean-Marie Verdun <verdun@hpe.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml

If you have the same maintainers for each of your drivers, it's actually
easier to keep them in one entry - HPE GXP ARCHITECTURE. There is little
benefit in having per-block entries which are the same as your main entry.

Best regards,
Krzysztof