From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbdEIHpW (ORCPT ); Tue, 9 May 2017 03:45:22 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:53518 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdEIHpU (ORCPT ); Tue, 9 May 2017 03:45:20 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: randy.li@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: randy.li@rock-chips.com X-UNIQUE-TAG: <6749463ff4a46783c51a418796eaeca9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288 To: Guillaume Tucker Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Mark Rutland , devicetree@vger.kernel.org, Neil Armstrong , Sjoerd Simons , Wookey , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, John Reitan , Rob Herring , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org References: <12996903.t3AZceNVOh@diego> From: Randy Li Organization: Fuzhou Rockchip Message-ID: Date: Tue, 9 May 2017 15:45:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2017 03:40 PM, Guillaume Tucker wrote: > On 09/05/17 02:16, Randy Li wrote: >> >> >> On 05/09/2017 12:27 AM, Heiko Stübner wrote: >>> Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: >>>> The ARM Mali Midgard GPU kernel driver is only available >>>> out-of-tree and is not going to be merged in its current form. >>>> However, it would be useful to have its device tree bindings >>>> merged. In particular, this would enable distributions to create >>>> working driver packages (dkms...) without having to patch the >>>> kernel. >>>> >>>> The bindings for the earlier Mali Utgard GPU family have already >>>> been merged, so this is essentially the same scenario but for >>>> newer GPUs (Mali-T604 ~ Mali-T880). >>>> >>>> This series of patches first imports the bindings from the latest >>>> driver release with some clean-up then adds a gpu node for the >>>> rk3288 SoC. This was successfully tested on Radxa Rock2 Square, >>>> Firefly, Veyron Minnie and Jerry boards using Mali kernel driver >>>> r16p0 and r12p0 user-space binary. >> I won't suggest such combine. We meet some problems at mali 400 serial. >> I would suggest the kernel version would match the user library. > > Well, I can test it again with r12p0 kernel driver (out-of-tree) > if you want. The user-space driver checks the version of the > kernel driver and gives up if it's not compatible. With Midgard, > there's a range of versions that maintain kernel/userspace > compatibility unlike Utgard and older Midgard releases where they > had to exactly match. Again, if there was a mismatch then the > user-space would fail to initialise and report an error. Anyway, could you verify the mali userspace library r13p0? Rockchip would use this version to offer the support of X11, wayland and gbm. > >> Also please notice there is rk3288w, the hardware version becomes r1p0. > > Sounds like a new SoC? Does rk3288w affect rk3288 in any way? It is not a new SoC, just a new version of rk3288. It fixes a various of the chip bug of the rk3288. > > Unless it's a special case, it seems to me that any new SoC with > a Midgard GPU would need an extra vendor compatible string in the > binding documentation and maybe a separate gpu dt node. > >>> The actual devicetree parts are all Rockchip-specific, so I guess >>> I'll just >>> pick up the whole series, including the binding doc, after the merge >>> window if nobody complains before that :-) > > Thanks! > > > Guillaume > > -- Randy Li