From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51135C2BB41 for ; Wed, 17 Aug 2022 21:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242237AbiHQVCe (ORCPT ); Wed, 17 Aug 2022 17:02:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242234AbiHQVCZ (ORCPT ); Wed, 17 Aug 2022 17:02:25 -0400 Received: from relay03.th.seeweb.it (relay03.th.seeweb.it [IPv6:2001:4b7a:2000:18::164]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A354AB414 for ; Wed, 17 Aug 2022 14:02:23 -0700 (PDT) Received: from [192.168.1.101] (abxi168.neoplus.adsl.tpnet.pl [83.9.2.168]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id A63681F425; Wed, 17 Aug 2022 23:02:21 +0200 (CEST) Message-ID: Date: Wed, 17 Aug 2022 23:02:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFT PATCH v2 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> <20220817130342.568396-8-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20220817130342.568396-8-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.08.2022 15:03, Krzysztof Kozlowski wrote: > The TCSR halt regs are next to TCSR mutex, so before converting the TCSR > mutex into device with address space, we need to split the halt regs to > its own syscon device. This also describes more accurately the devices > and their IO address space. > > Signed-off-by: Krzysztof Kozlowski > --- Not tested on a device, but looks good to the eye: Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 49f28cb531f6..5d2dd21da79c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { > > tcsr_mutex_regs: syscon@1f40000 { > compatible = "syscon"; > - reg = <0 0x01f40000 0 0x40000>; > + reg = <0 0x01f40000 0 0x20000>; > }; > > - tcsr_regs: syscon@1fc0000 { > + tcsr_regs_1: sycon@1f60000 { > + compatible = "qcom,sc7180-tcsr", "syscon"; > + reg = <0 0x01f60000 0 0x20000>; > + }; > + > + tcsr_regs_2: syscon@1fc0000 { > compatible = "qcom,sc7180-tcsr", "syscon"; > reg = <0 0x01fc0000 0 0x40000>; > }; > @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { > <&pdc_reset PDC_MODEM_SYNC_RESET>; > reset-names = "mss_restart", "pdc_reset"; > > - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; > - qcom,spare-regs = <&tcsr_regs 0xb3e4>; > + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; > + qcom,spare-regs = <&tcsr_regs_2 0xb3e4>; > > status = "disabled"; >