From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F093348896 for ; Mon, 8 Jun 2026 06:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900164; cv=none; b=LwFOCl9EXTAlxlmyMosIKTdCHVwexX+zW1DlOpGsopY+KnVb6SLmWGwpOSRXTUo3sayGh4c/zi6KYSRADe60hWo2fxSpRCdqE1EJ3nrj1NPrjN4qnyDzPU3T1ji62xuXQrlrqRUWnrFXKnuu5ky4em4dydCX8smZiYYKhiodVdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900164; c=relaxed/simple; bh=VFtyKhjmbMF2L0eaDBDT+Ol3C58smT6ZZY0Q36qit6c=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=YeLaaOMY9/0NY+Lv7VQLHZsElqGm+gG4a7tYu/AFzZHbVkUuDmB5VEH3lHRoStuAEZe3Edg7saeIdeG8mDAbTDZunF7Wq660sFmz3o6d2EZI6n/bmi+xmCreMlwtRWDfPz2Mh3aikdFiRAAiaoYL4VYaanJaPLE4UhLm3gRYBJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YyMHghlU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P2RXpq36; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YyMHghlU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P2RXpq36" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586OrB82274530 for ; Mon, 8 Jun 2026 06:29:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= esF80riE2NJ0vmPT5A+P8qHkNdHWZ6xrNpQUTG/GXy8=; b=YyMHghlUQB6i4X3I t2CdX9EqHomm1RojV74wx7KJVpRMi0IdJFIRis8T5jGaoDgfZ5V13tQTCeDocDFf Bx18eRat3LK2Tg1bE69t56Ze+hPivF/DU7Az3ibicAG1tPO+btBLtXWMzFsTuPQZ 9Ty5tec2uT5DWrfprsj/FS4vx+dUvLaA8Fr5QhejKVN+9tk0KbwPrbkM0xVLIcMU 4syqDRA0+EHO4hXKAjhPQRyUuqzblypBYnOi0t9h4xB2U8SO2U+9O/XalNvK4ohC qZWrLB34aE3jLbVlYnk/z86kxyP2BSN+chiQI8dMZDNSB5g7/9OahZus69KYxUkB dgedbg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emcqgx09g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 06:29:20 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0c331eda3so42704775ad.2 for ; Sun, 07 Jun 2026 23:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780900160; x=1781504960; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=esF80riE2NJ0vmPT5A+P8qHkNdHWZ6xrNpQUTG/GXy8=; b=P2RXpq36TpLOaOf6mOyuv4pOtp5HZhjKm613aRYvr7auseNUB4CnWyfjfeA5n3FMtS ag6GtOe7J1Qpug+KBiCOtrXemfaRs/3QEVUWQO7SCL18zkFn4qvvroGzXzyuwWkJiJ9y qUpbngVe9vA2rMq/50Q8/Tpop67tWHmc0IZjqV0cI7TJxRDJkwRIIWzfJmT63zLi4ZV7 HbkuIhR1brHY8VunDz7TfG9HxUoRoYQuToSMDYFrYMyQd2DxlHzPA7QncyAHn5MLjGnp 9t/qiePQLEsJ6wOK5HRF6C7gj0E+ZreEJWm13su8AEe6Asq93Qzpp3glI3gOvXcHXw9E rJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780900160; x=1781504960; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=esF80riE2NJ0vmPT5A+P8qHkNdHWZ6xrNpQUTG/GXy8=; b=DkP3lAZldsQ/9kehPXDdWgF2DmcHyNu+b584gEjgNQeoHhSmaO2I1jpAT98s7HI/wZ snRG56eyY71iJnA6GnkWhIcxFauRAW34eCgHa4dmpJTZqdWNaPBHH/A6qG+iBKSFzbAP RVL4CRQCqYIssuayRMgdsWj3cewnoJuX4BS+f+JWkZ0V/QgmuR+OootwLtDzOdcphl6h JfTVU88kUHOWqLyFAdZBmHnnZv5f48pv3+z7ZYmW51bGWCmUUhL9NvAvQC35WuL37EmQ sqa4wnFff/nX5CGcwDz9tAZDZJ/Eg1lda0MKyfTnsOPX7gfF3/AB+g3StiSmp2aG2GMj 2WAQ== X-Forwarded-Encrypted: i=1; AFNElJ9XQuYguWIG5wOw0gwCN+U8p15BCRc2DPLncQ40bA/f34Q4HruwP1uP8GBuwgsxQTgJEkknR7AN3kZ8ey4=@vger.kernel.org X-Gm-Message-State: AOJu0YznM1XOLh+N+amYHO6vZIRiczwptnYVR/A9oUID6DLY4q4AbPCu tX/LdoDsUza3xglPNRxyrycB8/UqfEBkkV7ut6JaFI2Oy2uuIv3rWgZZ4ldSob+JlBSYh7+ffut RBFQn/fAoslJG9VuGK+9ifn/DGaiMaih1RacYRa9mt/4cZzmgfEGA0BfxPhgloiKpGek= X-Gm-Gg: Acq92OECJitVGrmVCjnPcsxSHRdp84udPTpkS1d1bkdcIgMFk0Xxstj/bKJoWSR0k/V iPDOpPYNZ33eg+EjU0M85K4sRvn0VB9hofUNJntIMCsuNT8DutR3+IqvEPoLXho+h78KvCNI5Vz kpIaTSybLH+m2YffIFFskhXve9kIl8aSvk6/UzTanNNgO2zIsnQ6QgcwXgxnjqVHI673b0w81tA I4PRkCa6XI8dJ9Huxe4nAiyRCUhq0q7DUKjxkbRUr+lFVrpbROq5YHvL8WXmqdiyhHvd4euKDuN L8BFY4cBGhXqoVnH0d/sSK6cXnpN58SPSDBPke3NbMvtigB7HQC+aiUX0dkNjf/4DNjoEHPXear BVOC+46jwHjtNM93iTU2OEyiOgF57pSx+7S7KOogvZeN/qfFWT6QkZq7it5Xz/i77uYWxY7n9gJ 6aAiSIYNCH97bVcD1zDdL5MM4JDjg= X-Received: by 2002:a17:903:4b50:b0:2bc:b80f:6782 with SMTP id d9443c01a7336-2c1e821dd0bmr141753825ad.11.1780900160077; Sun, 07 Jun 2026 23:29:20 -0700 (PDT) X-Received: by 2002:a17:903:4b50:b0:2bc:b80f:6782 with SMTP id d9443c01a7336-2c1e821dd0bmr141753315ad.11.1780900159601; Sun, 07 Jun 2026 23:29:19 -0700 (PDT) Received: from [10.133.33.209] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6dc92sm157118725ad.13.2026.06.07.23.29.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jun 2026 23:29:19 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 14:29:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Dmitry Baryshkov References: <20260602071750.526-1-jianping.li@oss.qualcomm.com> <20260602071750.526-4-jianping.li@oss.qualcomm.com> Content-Language: en-US Cc: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, Greg KH , abelvesa@kernel.org, jorge.ramirez@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ekansh Gupta , quic_chennak@quicinc.com, stable@kernel.org From: Jianping Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dJGWXuZb c=1 sm=1 tr=0 ts=6a266140 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=np7A-RzQJBVldtc5gtwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 458xAzRnnF0kzfkC5_RWW08VN20dWReO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA1NiBTYWx0ZWRfX13LFRmsK5wvN EXatOVQ95l9iZJmb1dJaQZi1EW2tBnmZEHebvBxhRtVW52P2TsQ7tNSmMvnzu88PNcCOs+pavMN PTp0WNVWMXGff5vdMM1CCmkLACB88o4jIsk778NDj1URC0cMPYhPIBhLen1FGaNt7eg+/X2q8es TidENeX5k0Nq3pA02WAt5fkhLNN9SE4U+jBUqf6j5P9m1Ke7toGXS+C0ErbqfPdPNpb9RNmfR8M cjqUqRthmZdriR5UXbPbm0RC3SFk38EJuJq5yOmBdpFiPPv8MWZaT5FjnARAMsz3BSYyXFUSFDa Mdkl2Kg9uyUlf2SVzxKZLyWWmSoCOSCh+CGZVw5e7ZegiaN7RvDjb3gs2HGqRych2W+HKlhhZHJ m7sjFGAiE0RRbDVDbEvN8RymeyiWJ22YW23mcV+EQUihs4cFxVuzFK35AguATyg9LnwjicmkJoR Ej/07l+euDffLiujpBQ== X-Proofpoint-ORIG-GUID: 458xAzRnnF0kzfkC5_RWW08VN20dWReO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080056 On 6/8/2026 2:11 PM, Dmitry Baryshkov wrote: > On Tue, Jun 02, 2026 at 03:17:48PM +0800, Jianping Li wrote: >> Audio PD static process creation assumes that a reserved-memory >> region is defined in DT and exposed via cctx->remote_heap. >> >> If reserved-memory is missing or incomplete, the driver may pass >> invalid address/size information to the DSP, leading to undefined >> behavior or crashes. >> >> Add explicit validation for remote_heap presence and size before >> sending the memory to DSP, and fail early if the configuration is >> invalid. >> >> Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") >> Cc: stable@kernel.org >> Signed-off-by: Jianping Li >> --- >> drivers/misc/fastrpc.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index a8a58f889d07..f46a8f53970d 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -1354,6 +1354,13 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> } inbuf; >> u32 sc; >> >> + if (!fl->cctx->remote_heap || >> + !fl->cctx->remote_heap->dma_addr || >> + !fl->cctx->remote_heap->size) { >> + err = -ENOMEM; >> + dev_dbg(fl->sctx->dev, "remote heap memory region is not added\n"); >> + return err; >> + } > Won't this check without the next commit break the kernel? I don't see > where else the remote heap is being allocated. Yes, this check depends on remote_heap being populated during rpmsg probe from the reserved-memory region, introduced in a subsequent patch in this series. If there is no dependency on the next series, the remote_heap allocation here after the if check. The logic will be wrong. > >> args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); >> if (!args) >> return -ENOMEM; >> -- >> 2.43.0 >>