From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B5031487E1; Mon, 14 Apr 2025 01:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744593983; cv=none; b=WjgcfN+GttDMtAr42X+c6KBOH5Pi1Vw8uBb2v8xwvNjrC7i2K+gjP7Fsbhjj/y6hOonmVSy1NL9SZUwMDDPo0KiX20wLrV8NdGpquYRM2hKqY4fh/HZdvFGSd47SoGNgICUBXPKzYQfjhTScMPB/hMtNDInW06DXbETd6G6SgU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744593983; c=relaxed/simple; bh=wS24v30if9RYBtGDQ3Jax1G2zzJrDoYyGOIOHyWAawg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=EX+ZWcBA9/2zFR/K6nVH72PB4G9HMVdc90IhSRwlkeiNs36pp0JkKRosVMOue9ckLUwgrGyy33qPfmtT4r6OOVytxMw2HTKbwTS+bUxCJ4KJNrAzr5NEWDlCfuq/1Cefbzwe7LKmrR3oQu0E1xr9aqyBqsOJq6oEzGPS3fcwiOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4ZbV390zx2z13KcB; Mon, 14 Apr 2025 09:25:25 +0800 (CST) Received: from kwepemh100008.china.huawei.com (unknown [7.202.181.93]) by mail.maildlp.com (Postfix) with ESMTPS id 06482180080; Mon, 14 Apr 2025 09:26:12 +0800 (CST) Received: from [10.67.121.90] (10.67.121.90) by kwepemh100008.china.huawei.com (7.202.181.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Apr 2025 09:26:10 +0800 Message-ID: Date: Mon, 14 Apr 2025 09:26:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/8] Add functions for getting and setting registers related to autonomous selection in cppc_acpi To: Mario Limonciello , , , , , , , , , CC: , , , , , , , , , References: <20250411093855.982491-1-zhenglifeng1@huawei.com> From: "zhenglifeng (A)" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh100008.china.huawei.com (7.202.181.93) On 2025/4/12 2:18, Mario Limonciello wrote: > On 4/11/2025 4:38 AM, Lifeng Zheng wrote: >> The patch series is organized in two parts: >> >>   - patch 1-6 refactor out the general CPPC register get and set functions >>     in cppc_acpi.c >> >>   - patches 7-8 add functions for getting and setting values of auto_sel, >>     energy_perf and auto_act_window in cppc_acpi.c >> >> Changelog: >> >> v7: >> >>   - Fix some typos >>   - Add check of null pointer in cppc_get_reg_val(), >>     cppc_get_auto_act_window() and cppc_get_auto_sel() >>   - Replace ternary operator with logical expression in cppc_get_reg_val() >> >> v6: >> >>   - Remove the last patch, will resent it in the future after reaching an >>     agreement with Sumit >>   - split patch 3 into 2 smaller patches >>   - Remove the printing of reg_idx in cppc_get_reg_val() and >>     cppc_set_reg_val() >>   - Change the logic for determing whether a register is supported in >>     cppc_get_reg_val() and cppc_set_reg_val() >> >> v5: >> >>   - add more explanation to the commit logs and comments >>   - change REG_OPTIONAL from bin to hex >>   - split patch 2 into 3 smaller patches >>   - remove CPPC_REG_VAL_READ() and CPPC_REG_VAL_WRITE() macros >>   - move the modification part in patch 5 into a separate patch >>   - rename the sysfs file from "energy_perf" to >>     energy_performance_preference_val >> >> v4: >> >>   - add REG_OPTIONAL and IS_OPTIONAL_CPC_REG to judge if a cpc register is >>     an optional one >>   - check whether the register is optional before CPC_SUPPORTED check in >>     cppc_get_reg_val() and cppc_set_reg_val() >>   - check the register's type in cppc_set_reg_val() >>   - add macros to generally implement registers getting and setting >>     functions >>   - move some logic codes from cppc_cpufreq.c to cppc_acpi.c >>   - replace cppc_get_auto_sel_caps() by cppc_get_auto_sel() >> >> v3: >> >>   - change cppc_get_reg() and cppc_set_reg() name to cppc_get_reg_val() and >>     cppc_set_reg_val() >>   - extract cppc_get_reg_val_in_pcc() and cppc_set_reg_val_in_pcc() >>   - return the result of cpc_read() in cppc_get_reg_val() >>   - add pr_debug() in cppc_get_reg_val_in_pcc() when pcc_ss_id < 0 >>   - rename 'cpunum' to 'cpu' in cppc_get_reg_val() >>   - move some macros from drivers/cpufreq/cppc_cpufreq.c to >>     include/acpi/cppc_acpi.h with a CPPC_XXX prefix >> >> v2: >> >>   - fix some incorrect placeholder >>   - change kstrtoul to kstrtobool in store_auto_select >> >> --- >> Discussions of previous versions: >> v1: https://lore.kernel.org/all/20241114084816.1128647-1-zhenglifeng1@huawei.com/ >> v2: https://lore.kernel.org/all/20241122062051.3658577-1-zhenglifeng1@huawei.com/ >> v3: https://lore.kernel.org/all/20241216091603.1247644-1-zhenglifeng1@huawei.com/ >> v4: https://lore.kernel.org/all/20250113122104.3870673-1-zhenglifeng1@huawei.com/ >> v5: https://lore.kernel.org/all/20250206131428.3261578-1-zhenglifeng1@huawei.com/ >> v6: https://lore.kernel.org/all/20250409065703.1461867-1-zhenglifeng1@huawei.com/ >> >> Lifeng Zheng (8): >>    ACPI: CPPC: Add IS_OPTIONAL_CPC_REG macro to judge if a cpc_reg is >>      optional >>    ACPI: CPPC: Optimize cppc_get_perf() >>    ACPI: CPPC: Rename cppc_get_perf() to cppc_get_reg_val() >>    ACPI: CPPC: Extract cppc_get_reg_val_in_pcc() >>    ACPI: CPPC: Add cppc_set_reg_val() >>    ACPI: CPPC: Refactor register value get and set ABIs >>    ACPI: CPPC: Modify cppc_get_auto_sel_caps() to cppc_get_auto_sel() >>    ACPI: CPPC: Add three functions related to autonomous selection >> >>   drivers/acpi/cppc_acpi.c     | 313 +++++++++++++++++++++-------------- >>   drivers/cpufreq/amd-pstate.c |   3 +- >>   include/acpi/cppc_acpi.h     |  30 +++- >>   3 files changed, 219 insertions(+), 127 deletions(-) >> > > Reviewed-by: Mario Limonciello Thank you! Regards, Lifeng