From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Lino Sanfilippo" <l.sanfilippo@kunbus.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
u.kleine-koenig@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com,
hugo@hugovil.com, m.brock@vanmierlo.com,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Lukas Wunner <lukas@wunner.de>,
p.rosenberger@kunbus.com, stable@vger.kernel.org
Subject: Re: [PATCH v7 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO
Date: Fri, 5 Jan 2024 11:44:27 +0100 [thread overview]
Message-ID: <ddf185b0-1a6e-cace-7dbe-ea48348491d0@gmx.de> (raw)
In-Reply-To: <485fbc21-d099-d316-2146-36fef116f894@linux.intel.com>
On 03.01.24 at 12:10, Ilpo Järvinen wrote:
> On Wed, 3 Jan 2024, Lino Sanfilippo wrote:
>
>> Also with commit c54d48543689 ("serial: stm32: Add support for rs485
>> RX_DURING_TX output GPIO") the SER_RS485_RX_DURING_TX flag is only set if a
>> rx-during-tx GPIO is _not_ available, which is wrong. Fix this, too.
>
> This doesn't explain why it's wrong and I could figure it out myself
> either.
>
Ugh, you are right. I confused some things here. This part of the patch is completely
wrong and the concerning code was correct as it was before. I will correct this patch
for v8.
Thanks,
Lino
next prev parent reply other threads:[~2024-01-05 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 6:18 [PATCH v7 0/7] Fixes and improvements for RS485 Lino Sanfilippo
2024-01-03 6:18 ` [PATCH v7 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2024-01-03 11:10 ` Ilpo Järvinen
2024-01-05 10:44 ` Lino Sanfilippo [this message]
2024-01-03 6:18 ` [PATCH v7 2/7] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2024-01-03 6:18 ` [PATCH v7 3/7] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2024-01-03 6:18 ` [PATCH v7 4/7] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2024-01-03 6:18 ` [PATCH v7 5/7] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2024-01-03 11:19 ` Ilpo Järvinen
2024-01-03 6:18 ` [PATCH v7 6/7] serial: omap: do not override settings for RS485 support Lino Sanfilippo
2024-01-03 11:36 ` Ilpo Järvinen
2024-01-05 12:42 ` Lino Sanfilippo
2024-01-03 6:18 ` [PATCH v7 7/7] serial: 8250_exar: Set missing rs485_supported flag Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf185b0-1a6e-cace-7dbe-ea48348491d0@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=cniedermaier@dh-electronics.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m.brock@vanmierlo.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.rosenberger@kunbus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®