From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6331B2FB99D; Fri, 10 Oct 2025 16:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760115284; cv=none; b=H3YHUMXTU2Xjx2J5PmP5kuwRX6EguZllMtcdQv86Xac9BsiR8Tbl5pxTYb4ERgEWtgPpjj2/SKMs58iHrxEUVljde0ZwzJERfoh96u6uPqQtPwho+Pko4LwS9/QgdA+kKvsvIYToZ3loxWh2NRuTonU1Z4F7emLtUCxKKjrDXSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760115284; c=relaxed/simple; bh=Mre5NldF57v/qgCv1OBV6PcRmdgEEZG1uzhe703BsnE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EosWc8tzdkb4HbHUPQDTsytH5Tmf+sl5CWIW2/AgNi85me0Y/UKDu6GrRlIjx1ppGBqHtdoItTqNSf+8ACZQG+2U+oGRgcBApnEgNIaAZIe34lhsvO9lqMcWu6aaAqnJvdfNg0NEdATFFzyYiESo9HTIJlgQ+QVoTTtaA14iAqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D20B31596; Fri, 10 Oct 2025 09:54:34 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3C033F66E; Fri, 10 Oct 2025 09:54:35 -0700 (PDT) Message-ID: Date: Fri, 10 Oct 2025 17:54:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 29/29] arm_mpam: Add kunit tests for props_mismatch() To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-30-james.morse@arm.com> <2ed1be84-5097-488d-b8ce-7abebf5b9a7e@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <2ed1be84-5097-488d-b8ce-7abebf5b9a7e@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ben, On 12/09/2025 17:01, Ben Horgan wrote: > On 9/10/25 21:43, James Morse wrote: >> When features are mismatched between MSC the way features are combined >> to the class determines whether resctrl can support this SoC. >> >> Add some tests to illustrate the sort of thing that is expected to >> work, and those that must be removed. > Looks good to me, I checked the tests for v1. I agree with Jonathan that > you could make RESET_FAKE_HIEARCHY() a function now that you've changed > to use globals. > > Reviewed-by: Ben Horgan Thanks! James