From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Peilin Ye <yepeilin.cs@gmail.com>
Subject: Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe
Date: Mon, 30 Nov 2020 11:37:30 -0800 [thread overview]
Message-ID: <ddfde921e75f36cab2cd924d45dfbd11e07c6768.camel@perches.com> (raw)
In-Reply-To: <CABJPP5C0eN5kC8-jB0Bes438GxWbwnNyYeN5a+6uym5MgyuBPw@mail.gmail.com>
On Mon, 2020-11-30 at 23:56 +0530, Dwaipayan Ray wrote:
> Thanks, this does resolve the original problem, but again the following
> line throws 0 warnings:
>
> "zeebra" ther, yourr.
>
> Any punctuation separators are ignored :(
>
> (?:^|\s)($misspellings)(?=[\s\.\,\:\;\"\?\!]|$)
>
> Would this be acceptable rather? But again this doesn't
> handle [therr] or (therr).
No idea.
What does codespell use for its regex?
Maybe that should be used.
Maybe all the added lines should be collected and
codespell should be called on those lines instead.
Try other options and check if the overall cpu/wall clock use is reduced.
Adding codespell's dictionary was kind of a 'nice to have' option and
it's not likely that it matters a lot if it's perfect or not.
My presumption is that it's not frequently used, but hey, who knows.
prev parent reply other threads:[~2020-11-30 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 14:45 Dwaipayan Ray
2020-11-30 16:43 ` Joe Perches
2020-11-30 17:03 ` Dwaipayan Ray
2020-11-30 17:24 ` Joe Perches
2020-11-30 17:32 ` Dwaipayan Ray
2020-11-30 18:01 ` Joe Perches
2020-11-30 18:26 ` Dwaipayan Ray
2020-11-30 19:37 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddfde921e75f36cab2cd924d45dfbd11e07c6768.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®