From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org,
willmcvicker@google.com, semen.protsenko@linaro.org,
kernel-team@android.com, jaewon02.kim@samsung.com
Subject: Re: [PATCH 2/3] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks
Date: Wed, 29 Jan 2025 18:53:16 +0100 [thread overview]
Message-ID: <de0d9a23-7364-4d33-81bc-05847a3b4ff6@kernel.org> (raw)
In-Reply-To: <CADrjBPox8ZXRPSAsAxbPqoib0dgpgQXQF+5grPguujYjoOiy7g@mail.gmail.com>
On 21/01/2025 15:46, Peter Griffin wrote:
>>> and eint_mask_offset for saving & restoring it's registers.
>>>
>>> Refactor the existing platform specific suspend/resume callback
>>> so that each SoC variant has their own callback containing the
>>> SoC specific logic.
>>>
>>> Additionally we now call drvdata->suspend() & drvdata->resume()
>>> from within the loop that iterates the banks in
>>> samsung_pinctrl_suspend() and samsung_pinctrl_resume().
>>
>> Maybe split this patch in two:
>> * first to do the refactoring plus adding exynosautov920_pinctrl_suspend()
>> and exynosautov920_pinctrl_resume()
>> * second to add gs101_pinctrl_suspend() / gs101_pinctrl_resume()
>>
>> This way, it's obvious which part is the bugfix and which part is the
>> preparation and I believe it'd be easier to read.
>
> Sure, I will split it into two patches in the next version.
>
Yeah, ack.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-29 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 22:34 [PATCH 0/3] samsung: pinctrl: Add support for eint_fltcon_offset and filter selection on gs101 Peter Griffin
2025-01-20 22:34 ` [PATCH 1/3] pinctrl: samsung: add support for eint_fltcon_offset Peter Griffin
2025-01-21 8:03 ` André Draszik
2025-01-20 22:34 ` [PATCH 2/3] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks Peter Griffin
2025-01-21 11:20 ` André Draszik
2025-01-21 14:46 ` Peter Griffin
2025-01-29 17:53 ` Krzysztof Kozlowski [this message]
2025-01-20 22:34 ` [PATCH 3/3] pinctrl: samsung: Add filter selection support for alive bank on gs101 Peter Griffin
2025-01-21 11:04 ` André Draszik
2025-01-21 15:39 ` Peter Griffin
2025-01-29 17:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0d9a23-7364-4d33-81bc-05847a3b4ff6@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=jaewon02.kim@samsung.com \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®