From: Reinette Chatre <reinette.chatre@intel.com>
To: Zeng Heng <zengheng4@huawei.com>, <tony.luck@intel.com>,
<Dave.Martin@arm.com>, <fenghuay@nvidia.com>, <bp@alien8.de>,
<james.morse@arm.com>
Cc: <bobo.shaobowang@huawei.com>, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>
Subject: Re: [PATCH v2] fs/resctrl: Restore the rdt_last_cmd_clear() calls after acquiring rdtgroup_mutex
Date: Wed, 4 Jun 2025 11:06:20 -0700 [thread overview]
Message-ID: <de0da633-5d8d-4343-8d23-2c88cb06c1f4@intel.com> (raw)
In-Reply-To: <20250603125828.1590067-1-zengheng4@huawei.com>
Hi Zeng Heng,
On 6/3/25 5:58 AM, Zeng Heng wrote:
> A lockdep fix removed two rdt_last_cmd_clear() calls that were used
> to clear the last_cmd_status buffer but called without holding the
> required rdtgroup_mutex. The impacted resctrl commands are:
> writing to the cpus or cpus_list files and creating a new monitor
> or control group. With stale data in the last_cmd_status buffer the
> impacted resctrl commands report the stale error on success, or append
> its own failure message to the stale error on failure.
>
> Consequently, restore the rdt_last_cmd_clear() calls after acquiring
> rdtgroup_mutex.
>
> Fixes: c8eafe149530 ("x86/resctrl: Fix potential lockdep warning")
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2025-06-04 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 12:58 Zeng Heng
2025-06-04 18:06 ` Reinette Chatre [this message]
2025-06-04 18:36 ` [tip: x86/urgent] " tip-bot2 for Zeng Heng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0da633-5d8d-4343-8d23-2c88cb06c1f4@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®