From: Dan Murphy <dmurphy@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control
Date: Thu, 20 Feb 2020 12:46:57 -0600 [thread overview]
Message-ID: <de0e8a5b-8c2a-ee04-856f-f0d678a3c66b@ti.com> (raw)
In-Reply-To: <20200220184507.GF3926@sirena.org.uk>
Mark
On 2/20/20 12:45 PM, Mark Brown wrote:
> On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote:
>
>> + /* Set the Digital volume to -110dB */
>> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00);
>> + if (ret)
>> + return ret;
>> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00);
>> + if (ret)
>> + return ret;
>> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d);
>> + if (ret)
>> + return ret;
>> + ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43);
>> + if (ret)
>> + return ret;
> Is there a reason not to use the chip default here? Otherwise this
> looks good.
Chip default is set to 0dB full blast+ 0x40400000. This sets the volume
to -110dB.
I have the values backwards. CFG4 should b 0x43 and CFG3 should be 0x0d
and CFG1&2 should be 0.
I will resend v2 with this fixed.
Dan
next prev parent reply other threads:[~2020-02-20 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:27 Dan Murphy
2020-02-20 18:45 ` Mark Brown
2020-02-20 18:46 ` Dan Murphy [this message]
2020-02-20 19:18 ` Mark Brown
2020-02-20 19:22 ` Dan Murphy
2020-02-20 19:40 ` Mark Brown
2020-02-20 19:52 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0e8a5b-8c2a-ee04-856f-f0d678a3c66b@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®