From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB67C7618F for ; Sat, 20 Jul 2019 02:04:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9E4620880 for ; Sat, 20 Jul 2019 02:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FxK9AQGw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390177AbfGTCD5 (ORCPT ); Fri, 19 Jul 2019 22:03:57 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1032 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733067AbfGTCD4 (ORCPT ); Fri, 19 Jul 2019 22:03:56 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 19 Jul 2019 19:04:02 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 19 Jul 2019 19:03:55 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 19 Jul 2019 19:03:55 -0700 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 20 Jul 2019 02:03:54 +0000 Subject: Re: [PATCH] mm/migrate: initialize pud_entry in migrate_vma() To: Ralph Campbell , CC: , , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton References: <20190719233225.12243-1-rcampbell@nvidia.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Fri, 19 Jul 2019 19:03:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190719233225.12243-1-rcampbell@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1563588242; bh=K89J2IEPJbk6VmuKgUrqZ1VHo+WQOc0Cte4m7yFZoOE=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FxK9AQGwhecU2l9E5xWnRjCI47IQqIB1G9YP1qaTQccoxr6/fiLGGjY0YSYude6Ss ldx4YsThY7WOYGW4UCOdZSHrOrMLWRiaOTTqh477zVcFtymsttcJvuAtY4Kshpzop0 05PJiu02FZmZ+NtH84hCL4TFh8r/ULQplJ+ck6f5iEkLuxOYPAGxEadkPzJhh3hB4q IUYfFsqgnuCrhIfSyTwbQMWR6k03sGAIe3VaTzUem3j/u0Ougpqao7phyGoi//a8jr hWzwc654tVQdZg+yMN4xCgTR00cQoYFuD3oWQHcYpWnpmuw23c/tdcZX3fkdD6w1+o 8ynbqObsmbohw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/19/19 4:32 PM, Ralph Campbell wrote: > When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls > migrate_vma_collect() which initializes a struct mm_walk but > didn't initialize mm_walk.pud_entry. (Found by code inspection) > Use a C structure initialization to make sure it is set to NULL. >=20 > Fixes: 8763cb45ab967 ("mm/migrate: new memory migration helper for use wi= th > device memory") > Cc: stable@vger.kernel.org > Signed-off-by: Ralph Campbell > Cc: "J=C3=A9r=C3=B4me Glisse" > Cc: Andrew Morton > --- > mm/migrate.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) >=20 > diff --git a/mm/migrate.c b/mm/migrate.c > index 515718392b24..a42858d8e00b 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2340,16 +2340,13 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > static void migrate_vma_collect(struct migrate_vma *migrate) > { > struct mmu_notifier_range range; > - struct mm_walk mm_walk; > - > - mm_walk.pmd_entry =3D migrate_vma_collect_pmd; > - mm_walk.pte_entry =3D NULL; > - mm_walk.pte_hole =3D migrate_vma_collect_hole; > - mm_walk.hugetlb_entry =3D NULL; > - mm_walk.test_walk =3D NULL; > - mm_walk.vma =3D migrate->vma; > - mm_walk.mm =3D migrate->vma->vm_mm; > - mm_walk.private =3D migrate; > + struct mm_walk mm_walk =3D { > + .pmd_entry =3D migrate_vma_collect_pmd, > + .pte_hole =3D migrate_vma_collect_hole, > + .vma =3D migrate->vma, > + .mm =3D migrate->vma->vm_mm, > + .private =3D migrate, > + }; Neatly done. > =20 > mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm_walk.mm, > migrate->start, >=20 Reviewed-by: John Hubbard thanks, --=20 John Hubbard NVIDIA