mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@ovn.org>
To: Norbert Szetei <norbert@doyensec.com>, netdev@vger.kernel.org
Cc: Aaron Conole <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	dev@openvswitch.org, linux-kernel@vger.kernel.org,
	David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net] openvswitch: reject a negative transport length in the IPv6 L4 checksum update
Date: Tue, 15 Sep 2026 23:13:41 +0200	[thread overview]
Message-ID: <de0fd2e5-8509-406c-9f92-cb644c42229d@ovn.org> (raw)
In-Reply-To: <114FAFBD-F7BC-46AE-AF9F-0D15124F130E@doyensec.com>

On 9/15/26 9:55 PM, Norbert Szetei wrote:
> update_ipv6_checksum() computes
> 
> 	int transport_len = skb->len - skb_transport_offset(skb);
> 
> and gates the L4 access on
> 
> 	if (likely(transport_len >= sizeof(struct tcphdr)))
> 
> sizeof yields size_t, so transport_len is converted to unsigned and every
> negative value passes the guard.  inet_proto_csum_replace16() then reads
> the transport checksum field out of bounds, and writes the updated value
> back to the same address:
> 
>   BUG: KASAN: slab-use-after-free in inet_proto_csum_replace16+0x445/0x470
>   Read of size 2 at addr ffff888131a4cb06 by task ovs_ipv6_oob/696
>   CPU: 3 UID: 1000 PID: 696 Comm: ovs_ipv6_oob Tainted: G N 7.3.0-rc2+ #338
>   Call Trace:
>    inet_proto_csum_replace16+0x445/0x470
>    set_ipv6_addr+0x3dd/0x460
>    do_execute_actions+0x6a3d/0x7c40
>    ovs_execute_actions+0xfd/0x480
>    ovs_packet_cmd_execute+0xc38/0xf20
>    genl_rcv_msg+0x59e/0x870
>    netlink_rcv_skb+0x18b/0x450
>    genl_rcv+0x2d/0x40
>    netlink_unicast+0x6bc/0xa20
> 
>   The buggy address belongs to the object at ffff888131a4c980
>    which belongs to the cache skbuff_small_head of size 704
>   The buggy address is located 390 bytes inside of
>    freed 704-byte region [ffff888131a4c980, ffff888131a4cc40)
> 
> ipv6_find_hdr() walks the extension header chain, skipping each header
> by the length that header itself declares, and ipv6_optlen() returns up
> to 2048.  The last skip is never checked against skb->len, and
> parse_ipv6hdr() installs the result as the transport header.

Hi, Norbert.

This looks like something that needs to be fixed in the ipv6_find_hdr().
IMO, this function should not return an offset that doesn't exist in the
packet, i.e. we should not be able to find what's not in there.

CC: David and Ido.

In general, we should be able to trust the skb_transport_offset(),
otherwise there could be other issues all over the place, not only in
openvswitch.

Best regards, Ilya Maximets.

> 
> Reject a negative length.
> 
> Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Norbert Szetei <norbert@doyensec.com>
> ---
> Reproducer available on request.
> 
>  net/openvswitch/actions.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index dc5ff859f114..4fdc08cca058 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -360,6 +360,9 @@ static void update_ipv6_checksum(struct sk_buff *skb, u8 l4_proto,
>  {
>  	int transport_len = skb->len - skb_transport_offset(skb);
>  
> +	if (unlikely(transport_len < 0))
> +		return;
> +
>  	if (l4_proto == NEXTHDR_TCP) {
>  		if (likely(transport_len >= sizeof(struct tcphdr)))
>  			inet_proto_csum_replace16(&tcp_hdr(skb)->check, skb,


  reply	other threads:[~2026-09-15 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 19:55 Norbert Szetei
2026-09-15 21:13 ` Ilya Maximets [this message]
2026-09-15 21:40   ` Eric Dumazet
2026-09-16  7:20     ` Norbert Szetei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de0fd2e5-8509-406c-9f92-cb644c42229d@ovn.org \
    --to=i.maximets@ovn.org \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dsahern@kernel.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=norbert@doyensec.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®