From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98634339844 for ; Wed, 28 Jan 2026 11:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599500; cv=none; b=UOfkf9OBm6eJWsf72F+37a0jFmnBS0IOaCBjblNiymawh8hhrbaLNqzCahrApYhURR6oETMl8aXuRwGRoSzYVXGk/vt0Zq0yWBgfOY6X2xZV5HaJpSLSdow33VH6EED1wB3fwmdovjKqvPHGqGzUs82HhGzdSxs6lrLsKFw6/dQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599500; c=relaxed/simple; bh=dVaaZ/ts/oUQNOwdJUlK/CE2cyjwYip+mrbrgffsmDY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h4qwd7MSAkzZlqz/VIPn+0Tw4hqogitlnWxOgN4oC0Hm7Ch1qneRo9P63we9x6ynPM2uIazrufvi9KVhA+JRvY+d5aEG6GqlktCSiFaEmzmXci20zpI+uC38tVa6ez5H3knRvI/Den/B53J02KpyI+cKkDB3yKDOOTkGCDZ594Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eSBO5EHk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Za3fglJs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eSBO5EHk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Za3fglJs" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S928vI320312 for ; Wed, 28 Jan 2026 11:24:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dhRsJ3EzuUj/2l9fOKYhc3V/t6syCqgQiffXBGPgzVU=; b=eSBO5EHkrk1kKvol or1hol6Sg/aspr2AtDwhhY13UR1eIqD9bG3gYLci7B0wSHjWtftBFSGdsPtlBcS0 gmfF/12HMueS+9JgpEynVntlJQAX3IZHmC53Aw62zLMDKnaEOnZ5sOrLi1eHtUyH Ykvt1VM16nyeOAutu3YgEv8lwDvluq2erwKlrDXCusZtEpLw37JoP3mc/2JX5+9p urgyjMvOKOHg4uhwcNbnSSajZOeeZu7KmpeWa0lSs7nz3B+icVeL/OM02E68eTo5 p6Qs6gzBK5OXPo3155SKE3LEKWsu7WxvCuzhwDXeCwO2tQzofTi0SOyubeXWeJYV fVl0Mg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by4sjtgqb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 11:24:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c53892a195so12756385a.3 for ; Wed, 28 Jan 2026 03:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769599497; x=1770204297; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dhRsJ3EzuUj/2l9fOKYhc3V/t6syCqgQiffXBGPgzVU=; b=Za3fglJsnNFRQ7a9wwKI1JoJvIB0xrC9PE1O6btR01k9ewhn3pQsM6JNuG5yFYBwxs 4GkqhoBxCHsjCwYjFebPAZxbUDofYT74n1CCeNJ54OS02skyBZI/XHDxnD/yDpqbg6BD pHp+OiNapQs91XX+ltq4mlMtA8Plfg6QmvYIfTSogUWXTApFEmAvASdATJu+1PINJUd4 Juq9S5NDAIacHWq6A4IpAaz49aweNNvq8Xds1wF1tbLPH9R5XxWzKWEoDf4T/zdyThT4 Ba1IzXQdF7t/fbtH89fiVytb+LGvrw2hnDwgj9hdBBEaEBs9gr3vCLigcUk0eFaxLnDz RDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599497; x=1770204297; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dhRsJ3EzuUj/2l9fOKYhc3V/t6syCqgQiffXBGPgzVU=; b=HKiSqUwVABFH3yo4VsteZe4W4YRP7aU5lNA7DzG8EPIaNE+tbgLa02aGC/fS3coeBd /0UTnjp+4bBQ59C1ubETviA7VhlgK4bfT6vxTOOvjJBjFXsLDDXQ5NtI0zjbKCKtbNMU Bmu14eDiYpdm5ozi9FAWp4jtcGkMN/8SMV/ldLOaJsWQ+PWlipALEuKL9US2vjhgUHYH YnJosj2Vl8WQOh+Tf1gUFvjcjEt9DaBDRWUykHLAfVrttgOL2MZgY5zagBQ9LTAdONpd uRaj4lFEVozpggzxjjh+rmnhVTK/edQsBprRv4qmqpjOehkhjO033GT5SI8R1blbnSkR Vu2A== X-Forwarded-Encrypted: i=1; AJvYcCUakk0BHVGGzqtrQ9larqw04h3w+b48bA9r75G0GC4TWRC+9MJGWBnlbGft01rllLvb6+2FaX8LJeJcLco=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw02tQh6KEQ9ngM3/xT8Z5jbHBE4HXFeX1XkcWOpUghy6YyeHH 8nMTA3LLtJcvZ3fkKY/dPkm1g2l1qHNaJti3WQFuWOB5awNiby1hY4CU6XheIcqrRlV7YFgG8rN Y9Hul+pNwSnMLi0bvccwKbNLXeb7EoCWid2f9P7wRJy5MDggPrQdZYmfuz/yRDRNwmr8= X-Gm-Gg: AZuq6aLI2eJ+bmKIPkTXjT9vq2yN0qD8mt/GHSycmSESRBz2qNe2GdPkVELUFYbtJ/Q yvsGLNV9ak91mEvRlkISOQaunHLt6RH3orflrpoq5jSLAj7K/liX4i0MkcNop87M+ve2J4W0dyb E0rVZHXyWHCQBhc92IsnJKUoFTiUbxtSrNiodamBY6yv6iROQD/WjF3NdHBP+31DD7by2KKWrxq 4yiH1WyoQMoMktT9d+cHhC+Gdjb/boQwAt8ijXQ+l5yubwLd4VMRYyAqVWD/RHkbMDoRhEajY6A KIcL9hrTw3GZOyY4dTR0Pj9TX8TUal9uhMebngvB6YPA6g0dSv84M/45E6WZkqNC/JhmQs3IhwQ B8QWEoWAcaSJtFf3QMV6hWrg5taee1Tiw5pNNiBId8/sQtDxkrV8H1gq7MQi/Ex+wSZM= X-Received: by 2002:a05:620a:2904:b0:8c6:d3a7:3d1e with SMTP id af79cd13be357-8c714a67607mr122192285a.0.1769599496952; Wed, 28 Jan 2026 03:24:56 -0800 (PST) X-Received: by 2002:a05:620a:2904:b0:8c6:d3a7:3d1e with SMTP id af79cd13be357-8c714a67607mr122190085a.0.1769599496363; Wed, 28 Jan 2026 03:24:56 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1847f9sm117534166b.42.2026.01.28.03.24.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 03:24:55 -0800 (PST) Message-ID: Date: Wed, 28 Jan 2026 12:24:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket S2 gaming console To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Greg Kroah-Hartman , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, KancyJoe References: <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-0-c55ec1b5d8bf@linaro.org> <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-7-c55ec1b5d8bf@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-7-c55ec1b5d8bf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA5MyBTYWx0ZWRfX/LHF1L3l+jK6 Kr4/ocefRRU1fVtf4u+6t9pKx3iKPeik/9WXbzMgdQPe3jhotsCprGJzf4CnqHHm8vejEcE+E/b y7HQcAlzWukrMLgz4gYOPaoC5nlpCa0/e/v1qAw8TItD0tbOYbO4sT/Ng2sF5C/+KIo6eZp0/PS XebhFuV7ldcvllmUXePsZIGGSeT3S515mcgwCgIZCK2QM5x5Oqor+LLohajQpzUAvbBC1uOuNgh o+huQVbmZ7Ns4y8IfIg5VlaVFEES6CZs0G+rVlXKSIPtTT4PQpsQyK1xMHM5nb9anOgxBMHU/hG ovQ3L7Nqdvgb54EmB8aszevboB8Qwv3XFnqblVmTj/QevWhtjkiN65OztVsvy3FJVl4NHZzWO8z dx6x7/uJrO/ntiUqnS/AX0SZFY9dNa/WjW0Lnpb9UfYNWNadzOkzPepQO4k8nTbJd5X3eRk9CUn Wycesg1xLOXHV/awpNw== X-Proofpoint-ORIG-GUID: wRRtvKEiuYUWfWUd3wXkDLVGLnfqfxpS X-Authority-Analysis: v=2.4 cv=KezfcAYD c=1 sm=1 tr=0 ts=6979f209 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=UqCG9HQmAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=rO7Yge3HHgQ4wEOnkrQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: wRRtvKEiuYUWfWUd3wXkDLVGLnfqfxpS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280093 On 1/27/26 10:57 AM, Neil Armstrong wrote: > From: KancyJoe > > Add initial Device Tree for the Ayaneo Pocket S2 gaming console based > on the Qualcomm Snapdragon 8 Gen 3 platform. > > The design is similar to a phone without the modem, the game control > is handled via a standalone controller connected to a PCIe USB > controller. > > Display panel support will be added in a second time. > > Signed-off-by: KancyJoe > Signed-off-by: Neil Armstrong > --- [...] > + va-dai-link { > + link-name = "VA Capture"; > + > + codec { > + sound-dai = <&lpass_vamacro 0>; > + }; > + > + cpu { > + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; > + }; > + > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + > + dp-dai-link { 'd'p-dai-link < 'v'a-dai-link [...] > +&pm8550_gpios { > + volume_up_n: volume-up-n-state { > + pins = "gpio6"; > + function = "normal"; > + bias-pull-up; > + input-enable; > + power-source = <1>; > + }; > + > + pwm_fan_ctrl_active: pwm-fan-ctrl-active-state { > + pins = "gpio9"; > + function = "func1"; > + output-low; > + bias-disable; > + power-source = <0>; > + qcom,drive-strength = <3>; /* PMIC_GPIO_STRENGTH_LOW */ This is defined in include/dt-bindings/pinctrl/qcom,pmic-gpio.h, you can just use it [...] > + upd720201_avdd33: upd720201-avdd33-state { > + pins = "gpio123"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + output-low; You should be able to drop all the output-low/high properties since the device driver that references these GPIOs already asserts that otherwise lgtm Reviewed-by: Konrad Dybcio Konrad