From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Shreesh Adiga" <16567adigashreesh@gmail.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Demian Shulhan" <demyansh@gmail.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crc: Add 4-way folding in NEON crc64_nvme implementation
Date: Wed, 18 Nov 2026 17:29:30 +0100 [thread overview]
Message-ID: <de1538b0-bb42-4a7f-af9d-f7311a452fe1@app.fastmail.com> (raw)
In-Reply-To: <20261118160110.1662470-1-16567adigashreesh@gmail.com>
On Wed, 18 Nov 2026, at 17:01, Shreesh Adiga wrote:
> Use 4-way folding in the shared NEON crc64_nvme for AArch64
> as well as AArch32. This improves performance by about 2x for 512 byte
> data size on Cortex-X925.
>
> Add similar optimizations from x86 implementation like reducing
> the 4x to 2x and doing a tail (len >= 32) 2x fold as well as partial
> block handling to process lengths which are not multiple of 16 bytes.
>
> The partial block stage is enabled only for AArch64 as it needs the
> 128-bit TBL instruction not available in AArch32.
> Modified the loop dispatch on AArch64 to allow any len >= 128 rather
> than just multiple of 16 bytes.
>
> Modified the pmull intrinsics from crc64-neon.h to use inline
> assembly as the intrinsic usage was causing the compiler to
> generate the fold constants via mov+movk+fmov/dup which was about 10
> instructions for 16-byte constant instead of expected adrp+ld1.
>
Why is that better?
next prev parent reply other threads:[~2026-11-18 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 16:01 Shreesh Adiga
2026-11-18 16:29 ` Ard Biesheuvel [this message]
2026-11-18 16:48 ` Shreesh Adiga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1538b0-bb42-4a7f-af9d-f7311a452fe1@app.fastmail.com \
--to=ardb@kernel.org \
--cc=16567adigashreesh@gmail.com \
--cc=demyansh@gmail.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®