From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbdK3HCP (ORCPT ); Thu, 30 Nov 2017 02:02:15 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37840 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdK3HCN (ORCPT ); Thu, 30 Nov 2017 02:02:13 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 751186035F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling To: Hans Verkuil Cc: John Stultz , Arnd Bergmann , David Airlie , lkml , dri-devel@lists.freedesktop.org, Hans Verkuil , Laurent Pinchart , Dan Carpenter , Bhumika Goyal References: <9097b2a4-b6b9-5fca-e039-0a17694b1143@xs4all.nl> From: Archit Taneja Message-ID: Date: Thu, 30 Nov 2017 12:32:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/2017 05:52 AM, John Stultz wrote: > On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: >> If the device tree for a board did not specify a cec clock, then >> adv7511_cec_init would return an error, which would cause adv7511_probe() >> to fail and thus there is no HDMI output. >> >> There is no need to have adv7511_probe() fail if the CEC initialization >> fails, so just change adv7511_cec_init() to a void function. In addition, >> adv7511_cec_init() should just return silently if the cec clock isn't >> found and show a message for any other errors. >> >> An otherwise correct cleanup patch from Dan Carpenter turned this broken >> failure handling into a kernel Oops, so bisection points to commit >> 7af35b0addbc ("drm/kirin: Checking for IS_ERR() instead of NULL") rather >> than 3b1b975003e4 ("drm: adv7511/33: add HDMI CEC support"). >> >> Based on earlier patches from Arnd and John. >> >> Reported-by: Naresh Kamboju >> Cc: Xinliang Liu >> Cc: Dan Carpenter >> Cc: Sean Paul >> Cc: Archit Taneja >> Cc: John Stultz >> Link: https://bugs.linaro.org/show_bug.cgi?id=3345 >> Link: https://lkft.validation.linaro.org/scheduler/job/48017#L3551 >> Fixes: 7af35b0addbc ("drm/kirin: Checking for IS_ERR() instead of NULL") >> Fixes: 3b1b975003e4 ("drm: adv7511/33: add HDMI CEC support") >> Signed-off-by: Hans Verkuil >> Tested-by: Hans Verkuil >> --- >> This rework of Arnd and John's patches goes a bit further and just silently >> exits if there is no cec clock defined in the dts. I'm sure that's the >> reason why the kirin board failed on this. BTW: if the kirin board DOES >> support cec, then it would be nice if it can be hooked up in the dts! >> >> Tested with my Dragonboard and Renesas Koelsch board. Also tested what >> happens when probing is deferred due to missing cec clock. >> >> John, can you test this again? > > Sorry I didn't get back to you yesterday on this! > > Seems to be working ok for me! > > Tested-by: John Stultz Queued to drm-misc-fixes. Thanks for fixing this. Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project