From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754829AbdKAQPL (ORCPT ); Wed, 1 Nov 2017 12:15:11 -0400 Received: from esa4.dell-outbound.iphmx.com ([68.232.149.214]:38246 "EHLO esa4.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbdKAQPJ (ORCPT ); Wed, 1 Nov 2017 12:15:09 -0400 From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.44,329,1505797200"; d="scan'208";a="81913481" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , , Subject: RE: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface Thread-Topic: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface Thread-Index: AQHTUqg1+PzMnZFz9EyHTJeQyg2XQqL/svxg Date: Wed, 1 Nov 2017 16:15:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA1GFHJp011528 > > +/* This structure may be modified by the firmware when we enter > > + * system management mode through SMM, hence the volatiles > > + */ > > +struct calling_interface_buffer { > > + __u16 class; > > Hey Mario, > > I just realized that there is a slight problem calling this identifier > "class" for userspace that happens to be written in C++ that #includes > this header as class is a reversed word. > Perhaps we could rename it to class_ or something otherwise userspace > has to shim with a C object and extern it with new identifiers to the > C++ component, which is awkward. Edward, Ah darn, I wish we would have caught this earlier in the series development, but it's better to do fix it now rather than after the uapi has been included in a kernel. Darren, I think I should adjust the series for this change to s/class/cmd_class; s/select/cmd_select/ . As ->class is used in many patches in the series, it will require be better to resend as v12 rather than a single patch that changes this one thing. I'll send it later this afternoon. Thanks,