From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: maarten.lankhorst@linux.intel.com, daniel.vetter@ffwll.ch,
viresh.kumar@linaro.org, rafael.j.wysocki@intel.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fbdev/sa1100fb: use devm_platform_ioremap_resource() to simplify code
Date: Fri, 3 Jan 2020 13:17:36 +0100 [thread overview]
Message-ID: <de1f8697-3b8a-20f1-e3fe-73a889b0e68a@samsung.com> (raw)
In-Reply-To: <20190904115754.21612-1-yuehaibing@huawei.com>
On 9/4/19 1:57 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/sa1100fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index ae2bcfe..4428cef 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1156,7 +1156,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev)
> static int sa1100fb_probe(struct platform_device *pdev)
> {
> struct sa1100fb_info *fbi;
> - struct resource *res;
> int ret, irq;
>
> if (!dev_get_platdata(&pdev->dev)) {
> @@ -1172,8 +1171,7 @@ static int sa1100fb_probe(struct platform_device *pdev)
> if (!fbi)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - fbi->base = devm_ioremap_resource(&pdev->dev, res);
> + fbi->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(fbi->base))
> return PTR_ERR(fbi->base);
>
prev parent reply other threads:[~2020-01-03 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190904120019epcas2p2d20e3e922d6a51ebd51c226440bc5df9@epcas2p2.samsung.com>
2019-09-04 11:57 ` YueHaibing
2020-01-03 12:17 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1f8697-3b8a-20f1-e3fe-73a889b0e68a@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®