mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	 Thierry Reding <thierry.reding@gmail.com>,
	 Russell King <linux@armlinux.org.uk>,
	 Jonathan Hunter <jonathanh@nvidia.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: paz00: use software nodes to describe GPIOs for WiFi rfkill
Date: Sat, 14 Feb 2026 21:40:31 +0100 (CET)	[thread overview]
Message-ID: <de212734-0b59-144c-7ec9-91d1b3443148@gmx.de> (raw)
In-Reply-To: <CAGb2v64BApjGy2AZsM5sJit4ZDKDreVE230kxFikBeo-SFnGzA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]

Hallo Chen-Yu,

On Sat, 14 Feb 2026, Chen-Yu Tsai wrote:

> On Sat, Feb 14, 2026 at 10:27 PM Marc Dietrich <marvin24@gmx.de> wrote:
>>
>> Hi Dimitry,
>>
>> On Wed, 11 Feb 2026, Dmitry Torokhov wrote:
>>
>>> Hi Thierry,
>>>
>>> On Fri, Jun 28, 2024 at 05:35:08PM +0200, Thierry Reding wrote:
>>>> From: Thierry Reding <treding@nvidia.com>
>>>>
>>>>
>>>> On Wed, 26 Jun 2024 21:46:13 -0700, Dmitry Torokhov wrote:
>>>>> Complete conversion of the WiFi rfkill device to use device
>>>>> properties/software nodes by utilizing PROPERTY_ENTRY_GPIO() instead of
>>>>> a lookup table.
>>>>>
>>>>>
>>>>
>>>> Applied, thanks!
>>>>
>>>> [1/1] ARM: tegra: paz00: use software nodes to describe GPIOs for WiFi rfkill
>>>>       commit: 47ac458bb229f8c4864081d173adbcfc55c34880
>>>
>>> Do you know by any chance why paz00 does not simply configure rfkill
>>> switch via device tree? The driver (rfkill-gpio) seem to support device
>>> tree...
>>
>> last time I tried this was rejected because the wifi chip is on the usb
>> bus and "rfkill" should be a sub-function of this chip [1], but that was
>> some time ago...
>>
>> Looking hard the schematics, the wifi chip does not have a gpio input as
>> first thought. Rather it seems that the first gpio toggles a regulator
>> which supplies the wifi module (m2 card) with power and the second gpio is
>> just connected to the wifi LED.
>>
>> Not sure how to transfer this into dt, but I guess this would be the
>> better solution.
>
> Then the first GPIO should probably just be described as a fixed regulator
> feeding the USB controller that the M.2 module is connected to.

I think that is what rfkill-gpio is for, so the proposal of 
Dimitry looks fine, execpt for the reset-gpio, aka LED which is 
already included in the dt (but maybe with the wrong gpio).

I will give it a try on real HW and report back.

Thanks!

Marc

  reply	other threads:[~2026-02-14 20:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  4:46 Dmitry Torokhov
2024-06-28 15:35 ` Thierry Reding
2026-02-12  3:22   ` Dmitry Torokhov
2026-02-14 14:26     ` Marc Dietrich
2026-02-14 14:49       ` Chen-Yu Tsai
2026-02-14 20:40         ` Marc Dietrich [this message]
2026-02-23  9:27           ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de212734-0b59-144c-7ec9-91d1b3443148@gmx.de \
    --to=marvin24@gmx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=thierry.reding@gmail.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®