From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6CF3DE42F for ; Fri, 10 Apr 2026 15:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834982; cv=none; b=YyJ0Xr8FfU1VD/p6Ob2ehzDShpks3FBvCtQfT13+Ht2F9aOW12DDH4QcUVPGd7iU8d+rIAAiWdibPgK0yvnuxdaWMpKtWGXYCxUYOP4/GJ87lCP7qh+Nkcfmi/V+KfyalNeJmNAJxOfj2AxuFqIky7XQt9fQKwaSnT6cMGgdAJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834982; c=relaxed/simple; bh=pMVJg16RiU5xetNeImXRVz5ocYzhoxQRKuIB3kbckjM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cxeBVuZD+ikdcMEDtigw0KJcYYQifiODP0S7M6f22+g+G0YMgEs/8DhKqjNlMqDIxTvBGNPc10/EVOpVnvCEDRSvDtejUcT+egwzsLjtHnmIjz/wn5nWXdY8XH/7WsMN6Ow0GqoGFCI8uRCt0JyZWl1/vAKLLe9czdqZDqYQrPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hW30GnB3; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hW30GnB3" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2c7d8bbad06so3621154eec.1 for ; Fri, 10 Apr 2026 08:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775834980; x=1776439780; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=bQBjqJfFbgAgcp+e3QnLHrvx3vq4o6Y5iRDazMhYwWM=; b=hW30GnB34mLaRyAS6fQWWiiIWJ1cotd0NphKa49gb90w90So57o6QB50a92dMTpoO3 u9l0jLC0nBQneRX648/5oXbl4l9EDYlmlRpi/8Wr/IkaUzxH1wQ7CliJypp+iTq6TN/2 mqBYu2wXMBC34NcDHzaydBQ56x/3IVBZZuiK+CnZz7UD1QcZU81zwu/Y/WOUWwIkgyRA tk/0E+HRK61Pgb82ZXTuh/tO0C/uj6rhxahSUw8JAOYPzf6lzxxK14UfzwIi5/MECSOT CzM5t+8iV/1gVgblVA5vcSkMAnvJzFyONIkMlYzGQkarZhqmQeHcK4ZDsMIiDfzQLqKl 7/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775834980; x=1776439780; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bQBjqJfFbgAgcp+e3QnLHrvx3vq4o6Y5iRDazMhYwWM=; b=b6jbdCihWMvrxuCRcx5aH2NCv6sdmBggCDbVYQLavAbhpp0iK6icx18pHJo9fYjgxM Ye7NZNakFPwpK4KI4S6aQNY9TAMhxCytVGxVJVerv3lb6ZuyDRmTfpaIUZnsYLVlb2M9 oPW3nQEv16bqwBYvMZcI9L26aMYdhFJ21b0FEiaAUgTaezuI+I2eiLNB3W1pY9EBln+U KBKKrV1V7WL7elSWiUHGLz6jBE8THsoKD3xazLqCvRIcS9bG1Q0wo1jLo9ywiUxKS1zA G2Cq5d+TcAAOaxQ6HT1Zw41H3Lo5A4+CeJwz8Qh72JbQxcCYglM2JXeJiflUhz0uH8j4 a8nw== X-Forwarded-Encrypted: i=1; AJvYcCWyPZ+gH+Ivy6E3ZV3z+7NVirNYojwD8cs/PxpK9mVN3ObsBiMfVQNStvWyBmIuEKm/1kNp35mXaBS+0E4=@vger.kernel.org X-Gm-Message-State: AOJu0YzSRbPYBiI3+d2AMT/1H4HQ8hhEZO42mbmhOambrrxFNj8V4eZJ el2WdnM+raQGWcrp/PprAZSH+E6K/3L+bhLJzV61W92xVimnFc18Rdt/ X-Gm-Gg: AeBDies7RWVFuQNeWdQmG14825H7fAClHjhuM6w9mKdfZKo9dNLzSrgUYl7FphGhiFm mhbrvrcWlLZI299+dKTpZYwLuc7Noe44/D0gU2qONa/C4PJIKM8z7ykIEGnKt5bV7oXY9/E42sL NphR0ihopSN0S89qKXHNA6johHNcBKmnuPtC8JMi0ATP3lEqmmEgI+5KG4bjhK9wPc93Jh1piDf p8IvkrqJRyoSlkiiYXUsdCw0tY2cL3zg/75JQNEqpRWqJkpLuBuse2Yw3OABg/saeiwQcPxeGfu fvOnfOpVBVJ2UtTZalvWziQ4WmpGLF0Pp46TivwTxpg9e5UcKEgstUJfkN8EqmQMb0pOfAAumOL nPEJGgMdY+xY40hBlVZy8wcuX0mkWlSlstrld6JmLJB3Vb0UhNmcJfpL8R19n6AVY7dHLYgGKIw 94s4nqtZ5ZbHAhM+ajE2XZDn+LHsWAETt04far X-Received: by 2002:a05:7300:6da6:b0:2c7:8e1c:956a with SMTP id 5a478bee46e88-2d589662875mr2131999eec.19.1775834979965; Fri, 10 Apr 2026 08:29:39 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2d561cd2c09sm5743556eec.18.2026.04.10.08.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 08:29:39 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 10 Apr 2026 08:29:38 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "linux@weissschuh.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH v4 2/2] hwmon: (powerz) Fix missing usb_kill_urb() on signal interrupt Message-ID: References: <20260410002521.422645-1-sanman.pradhan@hpe.com> <20260410002521.422645-3-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410002521.422645-3-sanman.pradhan@hpe.com> On Fri, Apr 10, 2026 at 12:25:41AM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > wait_for_completion_interruptible_timeout() returns -ERESTARTSYS when > interrupted. This needs to abort the URB and return an error. No data > has been received from the device so any reads from the transfer > buffer are invalid. > > The original code tests !ret, which only catches the timeout case (0). > On signal delivery (-ERESTARTSYS), !ret is false so the function skips > usb_kill_urb() and falls through to read from the unfilled transfer > buffer. > > Fix by capturing the return value into a long (matching the function > return type) and handling signal (negative) and timeout (zero) cases > with separate checks that both call usb_kill_urb() before returning. > > Fixes: 4381a36abdf1c ("hwmon: add POWER-Z driver") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter