From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5F6C61D85 for ; Fri, 24 Nov 2023 00:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbjKXATg (ORCPT ); Thu, 23 Nov 2023 19:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjKXATf (ORCPT ); Thu, 23 Nov 2023 19:19:35 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB14110C8; Thu, 23 Nov 2023 16:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=hdx62OaweghTuxJKy40I6uvLAL8EQr33RCrXQ1/BSAM=; b=qoMKvIi5r5oZJ2h7x8vFmUTFH/ 6RnF4ojppprty21w1nQzLV+gYTyUE4lCmMtNjsF2raI02Tj2zpioiEHk4QGyt4w80YieSspGf2fnF RdZRC9oVIcBI16G2r6MR/+OK8pEpqzFEY+VmTHuFOVKFA72Hxy3SU2K/MPEWO7wtkEbOOfJtCRU+t Fb+CxW/aGVJPIEp7iveJx5p/wbXkbqzEWI4vun00r/uijzTewRLZ4jBALwZ2C79tsCA5CFVU7WWfd rGLd+dPY6HGv0OOdqjDDJEBd7/1eXu2bHnuKHns+Wwyz2AEoYtVgn6u7VCekpLJN+iDWmcJTUKdYi FPaTQFTA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r6Juy-005rtQ-0Z; Fri, 24 Nov 2023 00:19:36 +0000 Message-ID: Date: Thu, 23 Nov 2023 16:19:35 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/Kconfig: Make hugetlbfs a menuconfig Content-Language: en-US To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Mike Kravetz , Muchun Song , linux-fsdevel@vger.kernel.org References: <20231123223929.1059375-1-peterx@redhat.com> From: Randy Dunlap In-Reply-To: <20231123223929.1059375-1-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BTW: On 11/23/23 14:39, Peter Xu wrote: > Hugetlb vmemmap default option (HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON) > is a sub-option to hugetlbfs, but it shows in the same level as hugetlbfs > itself, under "Pesudo filesystems". > Make the vmemmap option a sub-option to hugetlbfs, by changing hugetlbfs > into a menuconfig. > > Cc: Mike Kravetz > Cc: Muchun Song > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Peter Xu > --- > fs/Kconfig | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index fd1f655b4f1f..8636198a8689 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -254,7 +254,7 @@ config TMPFS_QUOTA > config ARCH_SUPPORTS_HUGETLBFS > def_bool n > > -config HUGETLBFS > +menuconfig HUGETLBFS > bool "HugeTLB file system support" > depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN > depends on (SYSFS || SYSCTL) > @@ -266,14 +266,7 @@ config HUGETLBFS > > If unsure, say N. > > -config HUGETLB_PAGE > - def_bool HUGETLBFS > - > -config HUGETLB_PAGE_OPTIMIZE_VMEMMAP > - def_bool HUGETLB_PAGE > - depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP > - depends on SPARSEMEM_VMEMMAP > - > +if HUGETLBFS > config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > bool "HugeTLB Vmemmap Optimization (HVO) defaults to on" > default n > @@ -282,6 +275,15 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > The HugeTLB VmemmapvOptimization (HVO) defaults to off. Say Y here to Is this small 'v' ^ a typo? thanks. > enable HVO by default. It can be disabled via hugetlb_free_vmemmap=off > (boot command line) or hugetlb_optimize_vmemmap (sysctl). > +endif # HUGETLBFS > + > +config HUGETLB_PAGE > + def_bool HUGETLBFS > + > +config HUGETLB_PAGE_OPTIMIZE_VMEMMAP > + def_bool HUGETLB_PAGE > + depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP > + depends on SPARSEMEM_VMEMMAP > > config ARCH_HAS_GIGANTIC_PAGE > bool -- ~Randy