From: Martin Kurbanov <mmkurbanov@salutedevices.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Michael Walle" <michael@walle.cc>,
Mark Brown <broonie@kernel.org>,
Chia-Lin Kao <acelan.kao@canonical.com>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
"Ezra Buehler" <ezra.buehler@husqvarnagroup.com>,
Sridharan S N <quic_sridsn@quicinc.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Alexey Romanov <avromanov@salutedevices.com>,
<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<kernel@salutedevices.com>
Subject: Re: [PATCH v2 4/5] mtd: spinand: micron: OTP access for MT29F2G01ABAGD
Date: Mon, 14 Oct 2024 15:48:46 +0300 [thread overview]
Message-ID: <de27927d-ce37-4c0f-85d0-e32bae3f0ef9@salutedevices.com> (raw)
In-Reply-To: <20241001113108.4fdb6360@xps-13>
Hi Miquel,
On 10/1/24 12:31, Miquel Raynal wrote:
>> +#define MICRON_MT29F2G01ABAGD_OTP_PAGES 12
>> +#define MICRON_MT29F2G01ABAGD_OTP_PAGE_SIZE 2176
>
> In the core we did add the data size and the OOB size to get the OTP
> page size. I would prefer something dynamic here as well, otherwise the
> implementation is very device specific for now reason?
Do you mean:
otp_page_size = nanddev_page_size(nand) + nanddev_per_page_oobsize(nand)
>> + size_t i = 0;
>> +
>> + /* If all zeros, then the OTP area is locked. */
>> + while (i < buf_size && *(uint32_t *)(&buf[i]) == 0)
>> + i += 4;
>
> Shall we expect buf_size to always be a multiple of 4? (real question)
This function is only for the nand flash MT29F2G01ABAGD that has a page
size multiple of 4.
--
Best Regards,
Martin Kurbanov
next prev parent reply other threads:[~2024-10-14 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 17:48 [PATCH v2 0/5] mtd: spinand: add OTP support Martin Kurbanov
2024-08-27 17:48 ` [PATCH v2 1/5] mtd: spinand: make spinand_{read,write}_page global Martin Kurbanov
2024-10-01 9:12 ` Miquel Raynal
2024-08-27 17:49 ` [PATCH v2 2/5] mtd: spinand: add OTP support Martin Kurbanov
2024-08-27 17:57 ` Martin Kurbanov
2024-09-02 14:18 ` Miquel Raynal
2024-10-01 9:12 ` Miquel Raynal
2024-10-14 12:27 ` Martin Kurbanov
2024-10-25 7:48 ` Miquel Raynal
2024-08-27 17:49 ` [PATCH v2 3/5] mtd: spinand: make spinand_wait() global Martin Kurbanov
2024-08-27 17:49 ` [PATCH v2 4/5] mtd: spinand: micron: OTP access for MT29F2G01ABAGD Martin Kurbanov
2024-10-01 9:31 ` Miquel Raynal
2024-10-14 12:48 ` Martin Kurbanov [this message]
2024-10-25 7:51 ` Miquel Raynal
2024-08-27 17:49 ` [PATCH v2 5/5] mtd: spinand: esmt: OTP access for F50{L,D}1G41LB Martin Kurbanov
2024-10-01 9:32 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de27927d-ce37-4c0f-85d0-e32bae3f0ef9@salutedevices.com \
--to=mmkurbanov@salutedevices.com \
--cc=acelan.kao@canonical.com \
--cc=avromanov@salutedevices.com \
--cc=broonie@kernel.org \
--cc=ezra.buehler@husqvarnagroup.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@salutedevices.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=quic_mdalam@quicinc.com \
--cc=quic_sridsn@quicinc.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®