mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Len Brown <len.brown@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org,
	Markus Elfring <elfring@users.sourceforge.net>,
	Bob Moore <robert.moore@intel.com>
Subject: [PATCH 13/42] ACPICA: Debugger: Remove some unecessary NULL checks
Date: Tue, 29 Dec 2015 13:55:27 +0800	[thread overview]
Message-ID: <de27c1c56fc53dd7426b09086191b4ed15ad4e2a.1451367389.git.lv.zheng@intel.com> (raw)
In-Reply-To: <cover.1451367388.git.lv.zheng@intel.com>

From: Markus Elfring <elfring@users.sourceforge.net>

ACPICA commit 36fcc1b98def3fb6e20cf5e877ffc3c1592d0140

local strupr function already checks for NULL pointers.
Original linux patch submitted by:
Markus Elfring <elfring@users.sourceforge.net>

Link: https://github.com/acpica/acpica/commit/36fcc1b9
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/acpica/dbcmds.c  |    9 ++-------
 drivers/acpi/acpica/dbinput.c |    4 +---
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/acpi/acpica/dbcmds.c b/drivers/acpi/acpica/dbcmds.c
index 84ab1c2..328c35b 100644
--- a/drivers/acpi/acpica/dbcmds.c
+++ b/drivers/acpi/acpica/dbcmds.c
@@ -1131,13 +1131,8 @@ void acpi_db_trace(char *enable_arg, char *method_arg, char *once_arg)
 	u32 debug_layer = 0;
 	u32 flags = 0;
 
-	if (enable_arg) {
-		acpi_ut_strupr(enable_arg);
-	}
-
-	if (once_arg) {
-		acpi_ut_strupr(once_arg);
-	}
+	acpi_ut_strupr(enable_arg);
+	acpi_ut_strupr(once_arg);
 
 	if (method_arg) {
 		if (acpi_db_trace_method_name) {
diff --git a/drivers/acpi/acpica/dbinput.c b/drivers/acpi/acpica/dbinput.c
index 802779a..6203001 100644
--- a/drivers/acpi/acpica/dbinput.c
+++ b/drivers/acpi/acpica/dbinput.c
@@ -625,9 +625,7 @@ static u32 acpi_db_get_line(char *input_buffer)
 
 	/* Uppercase the actual command */
 
-	if (acpi_gbl_db_args[0]) {
-		acpi_ut_strupr(acpi_gbl_db_args[0]);
-	}
+	acpi_ut_strupr(acpi_gbl_db_args[0]);
 
 	count = i;
 	if (count) {
-- 
1.7.10


  parent reply	other threads:[~2015-12-29  5:55 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  5:52 [PATCH 00/42] ACPICA: 20151218 Release Lv Zheng
2015-12-29  5:52 ` [PATCH 01/42] ACPICA: Linuxize: reduce divergences for 20151218 release Lv Zheng
2015-12-29  5:52 ` [PATCH 02/42] ACPICA: acpi_get_sleep_type_data: Reduce warnings Lv Zheng
2015-12-29  5:52 ` [PATCH 03/42] ACPICA: Namespace: Fix wrong error log Lv Zheng
2015-12-29  5:53 ` [PATCH 04/42] ACPICA: Debugger: reduce old external path format Lv Zheng
2015-12-29  5:53 ` [PATCH 05/42] ACPICA: Fix SyncLevel support interaction with method auto-serialization Lv Zheng
2015-12-29  5:54 ` [PATCH 06/42] ACPICA: Add "const" to some functions that return fixed strings Lv Zheng
2015-12-29  5:54 ` [PATCH 07/42] ACPICA: exmutex: General cleanup, restructured some code Lv Zheng
2015-12-29  5:54 ` [PATCH 08/42] ACPICA: Core: Major update for code formatting, no functional changes Lv Zheng
2015-12-29  5:54 ` [PATCH 09/42] ACPICA: Split interpreter tracing functions to a new file Lv Zheng
2015-12-29  5:54 ` [PATCH 10/42] ACPICA: acpiexec: Add support for AML files containing multiple tables Lv Zheng
2015-12-29  5:54 ` [PATCH 11/42] ACPICA: Disassembler/tools: Support for multiple ACPI tables in one file Lv Zheng
2015-12-29  5:55 ` [PATCH 12/42] ACPICA: iasl/acpiexec: Update input file handling and verification Lv Zheng
2015-12-29  5:55 ` Lv Zheng [this message]
2015-12-29  5:55 ` [PATCH 14/42] ACPICA: Revert "acpi_get_object_info: Add support for ACPI 5.0 _SUB method." Lv Zheng
2015-12-29  5:56 ` [PATCH 15/42] ACPICA: Add comment explaining _SUB removal Lv Zheng
2015-12-29  5:56 ` [PATCH 16/42] ACPICA: acpiexec/acpinames: Update for error checking macros Lv Zheng
2015-12-29  5:56 ` [PATCH 17/42] ACPICA: Concatenate operator: Add extensions to support all ACPI objects Lv Zheng
2015-12-29  5:57 ` [PATCH 18/42] ACPICA: Debug Object: Cleanup output Lv Zheng
2015-12-29  5:57 ` [PATCH 19/42] ACPICA: Debug object: Fix output for a NULL object Lv Zheng
2015-12-29  5:57 ` [PATCH 20/42] ACPICA: Update for output of the Debug Object Lv Zheng
2015-12-29  5:57 ` [PATCH 21/42] ACPICA: Namespace: Add scope information to the simple object repair mechanism Lv Zheng
2015-12-29  5:58 ` [PATCH 22/42] ACPICA: Namespace: Add String -> ObjectReference conversion support Lv Zheng
2015-12-29  5:58 ` [PATCH 23/42] ACPICA: getopt: Comment update, no functional change Lv Zheng
2015-12-29  5:59 ` [PATCH 24/42] ACPICA: Tools: Add spacing and missing options in acpibin tool Lv Zheng
2015-12-29  5:59 ` [PATCH 25/42] ACPICA: Add new exception code, AE_IO_ERROR Lv Zheng
2015-12-29  6:00 ` [PATCH 26/42] ACPICA: iasl/Disassembler: Support ASL ElseIf operator Lv Zheng
2015-12-29  6:00 ` [PATCH 27/42] ACPICA: Parser: Add constants for internal namepath function Lv Zheng
2015-12-29  6:00 ` [PATCH 28/42] ACPICA: Parser: Fix for SuperName method invocation Lv Zheng
2015-12-29  6:00 ` [PATCH 29/42] ACPICA: Update parameter type for ObjectType operator Lv Zheng
2015-12-29  6:00 ` [PATCH 30/42] ACPICA: Update internal #defines for ObjectType operator. No functional change Lv Zheng
2015-12-29  6:01 ` [PATCH 31/42] ACPICA: Update for CondRefOf and RefOf operators Lv Zheng
2015-12-29  6:01 ` [PATCH 32/42] ACPICA: Cleanup code related to the per-table module level improvement Lv Zheng
2015-12-29  6:02 ` [PATCH 33/42] ACPICA: Events: Deploys acpi_ev_find_region_handler() Lv Zheng
2015-12-29  6:02 ` [PATCH 34/42] ACPICA: Events: Uses common_notify for address space handlers Lv Zheng
2015-12-29  6:02 ` [PATCH 35/42] ACPICA: Utilities: Reorder initialization code Lv Zheng
2015-12-29  6:02 ` [PATCH 36/42] ACPICA: Events: Fix an issue that region object is re-attached to another scope when it is already attached Lv Zheng
2015-12-29  6:02 ` [PATCH 37/42] ACPICA: Events: Split acpi_ev_associate_reg_method() from region initialization code Lv Zheng
2015-12-29  6:03 ` [PATCH 38/42] ACPICA: Events: Enhance acpi_ev_execute_reg_method() to ensure no _REG evaluations can happen during OS early boot stages Lv Zheng
2015-12-29  6:03 ` [PATCH 39/42] ACPICA: Events: Introduce ACPI_REG_DISCONNECT invocation to acpi_ev_execute_reg_methods() Lv Zheng
2015-12-29  6:04 ` [PATCH 40/42] ACPICA: Add "root node" case to the ACPI name repair code Lv Zheng
2015-12-29  6:04 ` [PATCH 41/42] ACPICA: Add per-table execution of module-level code Lv Zheng
2015-12-29  6:04 ` [PATCH 42/42] ACPICA: Update version to 20151218 Lv Zheng
2016-01-01  3:04 ` [PATCH 00/42] ACPICA: 20151218 Release Rafael J. Wysocki
2016-01-01  3:24   ` Rafael J. Wysocki
2016-01-04  2:29   ` Zheng, Lv
2016-01-03  0:49 ` Rafael J. Wysocki
2016-01-03  6:45 ` David Lang
2016-01-04  2:27   ` Zheng, Lv
2016-01-04 13:16     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de27c1c56fc53dd7426b09086191b4ed15ad4e2a.1451367389.git.lv.zheng@intel.com \
    --to=lv.zheng@intel.com \
    --cc=elfring@users.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    --cc=zetalog@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®