From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C7434A2F; Fri, 23 Feb 2024 14:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698740; cv=none; b=MsvTQzob7wWjwZ/6qxvnqwoiTLFEShBhlPxDchgluGo3gYvh9Rx7S9vtsrAQdd1erYYBkhzLu6ZCPn2u8lbGJhQ5tVl0jeM+wyNo5YYSA3aPknsfLtsTfDb0h9PoZrUjf9wNRxQOegHpRiw+2khgZX7wDsBpV0XTBJEu4WlcA7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708698740; c=relaxed/simple; bh=6CxhTI2jTiafcu7o2bWlObYCVZe38zQ+4jHomDIbkiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lCNmeKVm+XCxHG29ZpqwI8uWqoOTrZW35VsErLZuM1G2AFJdYAL1pPYP7JvdrsFQyPfbGiPCizTHUImHk8lTM0pY4i4J0twXPRe3kfrWQy0POYPaEPqpcGUrjur2ItuIqV/PZkODQUkHyHQ6cNDVjiNGhb7RfNJfVJfeZevWRDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [141.14.220.34] (g34.guest.molgen.mpg.de [141.14.220.34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id D53F261E5FE05; Fri, 23 Feb 2024 15:30:34 +0100 (CET) Message-ID: Date: Fri, 23 Feb 2024 15:30:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] linux-firmware: update firmware for mediatek bluetooth chip (MT7921) Content-Language: en-US To: Chris Lu Cc: Josh Boyer , David Woodhouse , Ben Hutchings , Marcel Holtmann , Johan Hedberg , Sean Wang , Deren Wu , Aaron Hou , KM Lin , Robin Chiu , Steve Lee , linux-bluetooth@vger.kernel.org, linux-firmware@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20240223095044.7824-1-chris.lu@mediatek.com> From: Paul Menzel In-Reply-To: <20240223095044.7824-1-chris.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Chris, Thank you for your patch. Some nits. Am 23.02.24 um 10:50 schrieb Chris Lu: > Update binary firmware for MT7921 BT devices. > > File: mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin > Version: 20240219111427 The title is very unspecific for `git log --oneline`. Could you mention the version number in there? Maybe: linux-firmware: Update MediaTek MT7921 Bluetooth chip FW to 20240219111427 Also, could you please add a change-log of what changed between version 20231109191416 and 20240219111427? > Signed-off-by: Chris Lu > --- > WHENCE | 2 +- > mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin | Bin 532206 -> 530926 bytes > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/WHENCE b/WHENCE > index 576f8d73..f7dcc6db 100644 > --- a/WHENCE > +++ b/WHENCE > @@ -5645,7 +5645,7 @@ Licence: Redistributable. See LICENCE.mediatek for details. > Driver: mt7921 - MediaTek MT7921 bluetooth chipset > > File: mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin > -Version: 20231109191416 > +Version: 20240219111427 > > Licence: Redistributable. See LICENCE.mediatek for details. > > diff --git a/mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin b/mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin > index c7a96755b122ef7aa601eb40fbd7abb9ca85a545..34b791b7cc66780a80a18a631a9d578b2a744546 100644 > GIT binary patch > literal 530926 […] Kind regards, Paul