From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA50CC2D0BE for ; Tue, 10 Dec 2019 05:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C073620652 for ; Tue, 10 Dec 2019 05:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="ljzgP9T4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbfLJFEx (ORCPT ); Tue, 10 Dec 2019 00:04:53 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:40863 "EHLO mail-pj1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbfLJFEx (ORCPT ); Tue, 10 Dec 2019 00:04:53 -0500 Received: by mail-pj1-f52.google.com with SMTP id s35so6875965pjb.7 for ; Mon, 09 Dec 2019 21:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w5Tt0Lysebe0M7lQlmlIOszNZiqffqGag4pqh1DTTKc=; b=ljzgP9T4D/lgTaP7SkOrWiaDE9GqJ6V2GI2q5cFavhRVL04iT4jGNn/muTKK9Wkboe dX6xJOOqqiPGshijeqVlmx405JjpOLyhKVEkbwtABYT6cN24ca1dTvzxrGn1QB2/vTHR b/p4aOcTNcAHh4+tHeByvSn0A3X3zW/vAmREuROoQDs8OfIWlb4h660SHkehBSn1ug3v kNJfGdM4cePzPz5Pa9R8Be7Ukdu1vA3MIzn9RENprmmlmzvH2L4Zd9djJOS7DCQRcPeo oNAMMcJPE9txJERZvjdIZDKt354AO/P9hqhDnVVjFHyX19CZRXQVxWt8WtIi756fdukw KfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w5Tt0Lysebe0M7lQlmlIOszNZiqffqGag4pqh1DTTKc=; b=V8nIuQeJA8hfCadTbcFnAMpXi1NYNac+QcFstDQiewDWDkoUU0DrlZaJQ+K58GP6zg gEsedk44qBsaebfesjtXHxw9Hnc/M6vL6fc887NAZ1WuIMhfU8+pM9S8Hllia6QcH+hy V+6NNIQwCTIEta5/F6O+SbFFcXdWnoPulDventfxKjG7fXgmrQlz5/TfVNbqm2Z9GuOx CP8Sw/pvb8CGr7ZAFWa5T0SfsnLETaBQIrxuZT6vRQ95jCZHVTVf6XTAbh8FbWVwS8hP 3Z+gQEsqZ2AiLThQRUT+dgsoTKHV7mEl6Vre+oXdtegZ/1nAzeb6Gv89hpwWIkwU5FnG 6GVw== X-Gm-Message-State: APjAAAUx+GFWs63gwse8f4v3XPVPPog1//O1rg9Q4gjqNOSyQXoA/AJa Fn7ZlCrukZjgf/SkN3To5/bAwA== X-Google-Smtp-Source: APXvYqwa03MOkEo21d2LMth8ipN6oASoEbM9AtPlVBf90KSKstjZ152ZHbSqudsFAxn7pAoJdKgmXA== X-Received: by 2002:a17:902:6a8a:: with SMTP id n10mr4981514plk.9.1575954292242; Mon, 09 Dec 2019 21:04:52 -0800 (PST) Received: from ?IPv6:2620:10d:c081:1133::11c7? ([2620:10d:c090:180::240]) by smtp.gmail.com with ESMTPSA id q11sm1237900pff.111.2019.12.09.21.04.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2019 21:04:50 -0800 (PST) Subject: Re: [PATCH] block: fix "check bi_size overflow before merge" To: Andreas Gruenbacher Cc: Linus Torvalds , Junichi Nomura , Christoph Hellwig , Ming Lei , Hannes Reinecke , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20191209191114.17266-1-agruenba@redhat.com> From: Jens Axboe Message-ID: Date: Mon, 9 Dec 2019 22:04:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191209191114.17266-1-agruenba@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/9/19 12:11 PM, Andreas Gruenbacher wrote: > This partially reverts commit e3a5d8e386c3fb973fa75f2403622a8f3640ec06. > > Commit e3a5d8e386c3 ("check bi_size overflow before merge") adds a bio_full > check to __bio_try_merge_page. This will cause __bio_try_merge_page to fail > when the last bi_io_vec has been reached. Instead, what we want here is only > the bi_size overflow check. Applied, thanks. -- Jens Axboe