From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: stable@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH for 4.4-stable] KVM: x86: fix singlestepping over syscall
Date: Mon, 20 Nov 2017 19:33:21 +0100 [thread overview]
Message-ID: <de312294-2d78-0540-97ce-ffb5e08597de@redhat.com> (raw)
In-Reply-To: <1ce1faac-b580-2fc3-bebe-60e6f76d925a@redhat.com>
On 20/11/2017 10:55, David Hildenbrand wrote:
> This looks good to me.
>
> General question: how do we treat KVM single stepping and concurrent TF
> in the guest? IOW, shouldn't the "else" rather be a check for ctxt->tf ?
> (or is that handled later on e.g. in user space?)
At this time, not very well. What you suggest seems sensible, however
note that this function is only used on the (slow and rare) emulation
path, not when the guest is running in VMX (or SVM) non-root mode.
Paolo
prev parent reply other threads:[~2017-11-20 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 18:07 Paolo Bonzini
2017-11-20 9:55 ` David Hildenbrand
2017-11-20 18:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de312294-2d78-0540-97ce-ffb5e08597de@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®