From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB171B7E4 for ; Mon, 19 Aug 2024 01:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724031106; cv=none; b=XkDgdqlZKenGtOpV51UJrh2Dg0z0CVyGFkWUyepCAfEBVQ0bb8kGWL/aOh3a2UVw7QLZDkTINILKppPk+H/iqesyNpdciYkvZjbog/M3VXSkX9DIk9DC/j66pL8TSLniJ0CqoEcxCYkrvAw2Lh+PfPdRSJPeOid6fBJegpnmbQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724031106; c=relaxed/simple; bh=HQ5/dI0Bdm9EgRmrjx9EPAhLLGK7WM59NQ2TNadHhEY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oFSiUowe64KUVWDhyi6zGFMc+bfOOxlIibMVMN5MkwkwQDIkrJh1uKhUk5SkRyVv/vYOUo5WxXThMZDVVFPgIwptc11TK7MwaIovCBfZtedOJBec9AcfyN+BVvb6jQN32w30u6li2mKuCmtILbMbWQvlIyz7xNrK1YSphifdFRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dckD/Va9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dckD/Va9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724031103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+CCs3r6hJH4DMfIS+VQJMNGzaRyfgBQFWrMHED7vXl8=; b=dckD/Va9vV6fg1h/SXbPOI9PcwJpa9hSdAjHeECxtN/y5Ln9oZ6JuzyKDpAn8VniQ2xe7Q TDiWkiRyj+JajNPQj06iAzFlzaVpXOhDIukC7k6hyvhIqmleCI+p3xMbthn7SkGNgNQ/qn iavUW78rGh7FxWen7yFTy6chZHah/J0= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-okQt7iHBNZG95QxtQFbzSQ-1; Sun, 18 Aug 2024 21:31:42 -0400 X-MC-Unique: okQt7iHBNZG95QxtQFbzSQ-1 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-70cb2cd0cf4so2021079a34.3 for ; Sun, 18 Aug 2024 18:31:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724031101; x=1724635901; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+CCs3r6hJH4DMfIS+VQJMNGzaRyfgBQFWrMHED7vXl8=; b=BFXYogmolg/AVP9R4ae3oCPjgLfSkvhgZusGGE7k7Ry7ZdV7szC6Z6zjUboDz2GQfe 8/3q5AThUmSZ59bffK5JFZHzNxs5eL+mlI+HEKSX1Ce7Uro1MaRBFYPtXmuAMzCrVDdd iUmObqmAy7gf7LqNWDadsjgN0/R0oQeoyPcTUHkkl7gXoUsjiHV8lJyerp8XhhlJT8/t 8z6kphoD/2Diw2IjMELPfn8JL+Mhv8ewP72TJArgoslmgkDss88Fye+xxlpsEBjUCEhe s4mRryIGVQzofe3WDN8VYoe9Kld5boUY9I6aU7g78vHN27Nq1l8xYLQKYwDSBH2PppQm l9MA== X-Forwarded-Encrypted: i=1; AJvYcCXCgox2hHpoPGpqAAt9kEdYLuJGmLBUa7FczXemf6OumPpxllhu8Om6PRjOlz5OQE7qz3O6ZYLWEuk8YM4OnHkwOEWtmO4fRx3/iRQZ X-Gm-Message-State: AOJu0Yx57rOQj/CEVA6WRcQEDbwLEj2gCFiS1PEw8WpvSpi6rTl11UVh DsE+nbOM48uZEwW7WtsDTIP8T+e1iUHXp3EVKkq8zpDzfYgXKzd6toQkJWT5n8vehjlTNH9AMCG 8hEdZuQmsrvdy/uKcmFzyv3r2R43Tf03MNpOnGGuQRnXWi9TQ8CmbId70HoJXWg== X-Received: by 2002:a05:6830:919:b0:709:47a6:627c with SMTP id 46e09a7af769-70cac84915emr9933893a34.4.1724031101678; Sun, 18 Aug 2024 18:31:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6X1a7pPkn+SUa6v7Wbgpm6Nj8OlxFtxYJDnVVkia7xEYC08b4X5v9+urMoiKWMtuL+brG/w== X-Received: by 2002:a05:6830:919:b0:709:47a6:627c with SMTP id 46e09a7af769-70cac84915emr9933887a34.4.1724031101377; Sun, 18 Aug 2024 18:31:41 -0700 (PDT) Received: from [10.72.116.30] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c6b61dd9c9sm6712306a12.41.2024.08.18.18.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 18:31:40 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 09:31:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty" To: David Howells , Christian Brauner Cc: Max Kellermann , Ilya Dryomov , Jeff Layton , Matthew Wilcox , ceph-devel@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <2181767.1723665003@warthog.procyon.org.uk> Content-Language: en-US From: Xiubo Li In-Reply-To: <2181767.1723665003@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/15/24 03:50, David Howells wrote: > > This partially reverts commit 2ff1e97587f4d398686f52c07afde3faf3da4e5c. > > In addition to reverting the removal of PG_private_2 wrangling from the > buffered read code[1][2], the removal of the waits for PG_private_2 from > netfs_release_folio() and netfs_invalidate_folio() need reverting too. > > It also adds a wait into ceph_evict_inode() to wait for netfs read and > copy-to-cache ops to complete. > > Fixes: 2ff1e97587f4 ("netfs: Replace PG_fscache by setting folio->private and marking dirty") > Signed-off-by: David Howells > cc: Max Kellermann > cc: Ilya Dryomov > cc: Xiubo Li > cc: Jeff Layton > cc: Matthew Wilcox > cc: ceph-devel@vger.kernel.org > cc: netfs@lists.linux.dev > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > Link: https://lore.kernel.org/r/3575457.1722355300@warthog.procyon.org.uk [1] > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8e5ced7804cb9184c4a23f8054551240562a8eda [2] > --- > fs/ceph/inode.c | 1 + > fs/netfs/misc.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index 71cd70514efa..4a8eec46254b 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -695,6 +695,7 @@ void ceph_evict_inode(struct inode *inode) > > percpu_counter_dec(&mdsc->metric.total_inodes); > > + netfs_wait_for_outstanding_io(inode); > truncate_inode_pages_final(&inode->i_data); > if (inode->i_state & I_PINNING_NETFS_WB) > ceph_fscache_unuse_cookie(inode, true); > diff --git a/fs/netfs/misc.c b/fs/netfs/misc.c > index 83e644bd518f..554a1a4615ad 100644 > --- a/fs/netfs/misc.c > +++ b/fs/netfs/misc.c > @@ -101,6 +101,8 @@ void netfs_invalidate_folio(struct folio *folio, size_t offset, size_t length) > > _enter("{%lx},%zx,%zx", folio->index, offset, length); > > + folio_wait_private_2(folio); /* [DEPRECATED] */ > + > if (!folio_test_private(folio)) > return; > > @@ -165,6 +167,11 @@ bool netfs_release_folio(struct folio *folio, gfp_t gfp) > > if (folio_test_private(folio)) > return false; > + if (unlikely(folio_test_private_2(folio))) { /* [DEPRECATED] */ > + if (current_is_kswapd() || !(gfp & __GFP_FS)) > + return false; > + folio_wait_private_2(folio); > + } > fscache_note_page_release(netfs_i_cookie(ctx)); > return true; > } Just back from PTOs. This LGTM and I will run the test today locally. Thanks David. - Xiubo