From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A9220E32F for ; Tue, 8 Apr 2025 21:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149105; cv=none; b=QvHH4kBu8IWDZdLO1BfrxAkLv5RF+SaIWcmFfO3YuB0XF1rEAiMWCCEFDebSVtaP3uGSypaFA0Hvap9WIWvqf/3yoFqUO3H2xQSNW6g7GLsl/EfzzHoLasmAPjH/MD/eCLW5Di6gygoLdCGaww/SLAzU02Es7TPolYolZp9jv8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744149105; c=relaxed/simple; bh=SO5j5WgpKL3BcXKO5kOdxByCJcvTLcn9ijCoQY04dpQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PmNb9LtsJ6k+eEpIQEza/1pRATkmjV0cW0g7/KFZ8+NFscLxPd8RtrRndsd+SVz3S144W4JORXc3mqhu0DDTudGLyeRDpnFF3YxuYX1FYR2aiFG5fJlm0Er4gnqWCH35LSFkHD3TuPAA4rJYq02QJw8Xl1E6BAvsTgI5owXi/QI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fHN20sUj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fHN20sUj" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 538JZ0Au023085 for ; Tue, 8 Apr 2025 21:51:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4qYMmx1cwwXQQRUe4B443jnoYMCJS9Y4BrBHvddUYs0=; b=fHN20sUjyr6/tJLY VFhatTXDYbz76Q0DK5zR2QYW9X9Y/auQ1nlJ7HFpRTshffjRlcLSirXqIxTLYqXN w9ZEOnVuhOGlCcoyLHhIlt8tdrbPluKXVrQurRD6TS6/lva/R+tq9uDsvFZ0xQ+Z a8oBH20Ljg9CewBtye8yMMArv4aaBjMQDRJ5jO0eqoUpthRtmP68Ac4hWhMDDm5g y/cf6cS5DuNI8wypYHE7MXHll3Esx3tiBVKMMI9PAOg77sogXsoWndhNgaO91H7w ttTbf4MUUpKSARWg9BevWtu+FFt5XOHTPhBZob3Dbve218YHPWsWynBBu7NIsiLf LJtPTQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twfkh4vw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 08 Apr 2025 21:51:41 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-227ed471999so50146065ad.3 for ; Tue, 08 Apr 2025 14:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744149100; x=1744753900; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4qYMmx1cwwXQQRUe4B443jnoYMCJS9Y4BrBHvddUYs0=; b=I0qnMC4nvXdi38rORSlSexle9nWcdBftNK/lFt3mgQo068MZ+evzYKTsXCz33nxGgX zabHe3pxENQdixeKHKDXl1l4VFyQlkvn7xMrfTG1pWdYQdiGPips9dBFc4jvTH7wA8PV 6AJg+wDF0M1uO7QRbWycyh5jfVbgzHdX+X+2ymVvOlAHwBMCX765wopx01b5vHrKGi9h 9oRH1xSUWlhVmVh+RuV/oJGvG4MDuOsUt3I6/VgSUKkiqGS8qKV+imJBOeE5pBiI+Cqc zEIzl8xXhO4AwEwhaX78+6nGsWycoJX9UvIdo9hNvkxuWarB2L7fQpjXRpMDzibg34It rwWg== X-Forwarded-Encrypted: i=1; AJvYcCVmYGcUpZfNvICETJ0oOY2M0dx89nldgRZyLtVFXiCggKvcq0Dvd5yKK1IiVBQGPL1v1AbfUYd4s0/fMWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf7FarlMwHW4rLm0VLJtAH5kjNUN1bFPTMy8J7idmv3z6sZF8v ZvNmUVrC1MNVxI1KF8M2es85Bae41bmeN66V4t6tTdnF7Z+Smi2rtA/S2uN7rjZJgmgH302kQ5q uPH86pFa4ChipsbB7LfWpTR4jX8eiaZestsHOyuqfxMdH/ywm2VsJxZuE39zA/ig= X-Gm-Gg: ASbGncvLPG7Igm+oEd6OZhK6clNJArs1zR8Vldwbph3coAkC4ngTCiOXfvbLpU1KSVN sxQZGzbOK8KRpNXc5Juh7XlYSkRVTCqQ7xn3TMyz5EDHkZgCP2V/vewX8neJIsJi7vaeyYhvKbQ kMSwoo000beNOpsG8974zDRTFzBJE2RsW+ooyb2sBHBq/a8Qh7x5zktnryS9StqZO/bZ2PqCY1W TxNjOXCo6GXOBySfUU8SiVC2avQNt1DIIICXDV1UGQTohZFQf7hs2Hk6tkpPeNiYg9xMf4sQfF/ 0Z/JT2Mt5SaOKvyrAjqmWBfwq9pU/vPgSY35YjGeSzwG7wJRJwtR44hBCjhXz04CIQ5occOr5oM LL4xL6A== X-Received: by 2002:a17:903:1245:b0:221:7b4a:476c with SMTP id d9443c01a7336-22ac2992a09mr8608965ad.18.1744149099657; Tue, 08 Apr 2025 14:51:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCNranT1CO/GEUVT0ohp6e+mD5pBJVFGlgN+QUZlRKj2YbWbEFTNk7ni641yJ3KvIeudhivw== X-Received: by 2002:a17:903:1245:b0:221:7b4a:476c with SMTP id d9443c01a7336-22ac2992a09mr8608705ad.18.1744149099281; Tue, 08 Apr 2025 14:51:39 -0700 (PDT) Received: from [10.71.114.173] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ada60sm106004875ad.3.2025.04.08.14.51.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Apr 2025 14:51:38 -0700 (PDT) Message-ID: Date: Tue, 8 Apr 2025 14:51:37 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5 RESEND] thermal: qcom-spmi-temp-alarm: Add support for new TEMP_ALARM subtypes From: Anjelique Melendez To: amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org Cc: rui.zhang@intel.com, lukasz.luba@arm.com, david.collins@oss.qualcomm.com, srinivas.kandagatla@linaro.org, stefan.schmidt@linaro.org, quic_tsoni@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org References: <20250320202408.3940777-1-anjelique.melendez@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <20250320202408.3940777-1-anjelique.melendez@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5Wzi5sOZbnzn1Xxgf-EX6wEwH59c7xJ3 X-Proofpoint-ORIG-GUID: 5Wzi5sOZbnzn1Xxgf-EX6wEwH59c7xJ3 X-Authority-Analysis: v=2.4 cv=b7Oy4sGx c=1 sm=1 tr=0 ts=67f59a6d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=p-nOP-kxAAAA:8 a=EUspDBNiAAAA:8 a=P6RHbN-0fNZ3JhbA0IsA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 a=XN2wCei03jY4uMu7D0Wg:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-08_09,2025-04-08_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 mlxscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504080151 On 3/20/2025 1:24 PM, Anjelique Melendez wrote: > Add support in the qcom-spmi-temp-alarm driver for the new PMIC > TEMP_ALARM peripheral subtypes: GEN2 rev 2 and LITE. The GEN2 rev 2 > subtype provides greater flexibility in temperature threshold > specification by using an independent register value to configure > each of the three thresholds. The LITE subtype utilizes a simplified > set of control registers to configure two thresholds: warning and > shutdown. While at it refactor the qcom-spmi-temp-alarm driver to limit > code reuse and if/else statements when deciphering between TEMP_ALARM > peripheral subtypes. > > Also add support to avoid a potential issue on certain versions of > the TEMP_ALARM GEN2 subtype when automatic stage 2 partial shutdown > is disabled. > > This patch series is a continuation of older series from 7/2024 > (https://lore.kernel.org/all/20240729231259.2122976-1-quic_amelende@quicinc.com/) > but current series has been reworked to address the change in thermal framework to > update .set_trip_temp() callback function variables > (https://lore.kernel.org/all/8392906.T7Z3S40VBb@rjwysocki.net/) > > Changes since v2: > - Updated function name to include "gen1" in patch 2/5 > - Added Dmitry's reviewed-by tag in patch 2/5 > - link: https://lore.kernel.org/all/20250225192429.2328092-1-anjelique.melendez@oss.qualcomm.com/ > Changes since v1: > - Remove unnecessary moving of code > - Added new v2 patch 3/5 add a preparation patch to v1 patch 2/5 > - Updated temp alarm data function names to be consistently named > - link: https://lore.kernel.org/all/20250213210403.3396392-1-anjelique.melendez@oss.qualcomm.com/ > > Anjelique Melendez (4): > thermal: qcom-spmi-temp-alarm: Add temp alarm data struct based on HW > subtype > thermal: qcom-spmi-temp-alarm: Prepare to support additional Temp > Alarm subtypes > thermal: qcom-spmi-temp-alarm: add support for GEN2 rev 2 PMIC > peripherals > thermal: qcom-spmi-temp-alarm: add support for LITE PMIC peripherals > > David Collins (1): > thermal: qcom-spmi-temp-alarm: enable stage 2 shutdown when required > > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 515 ++++++++++++++++++-- > 1 file changed, 464 insertions(+), 51 deletions(-) > Hi Amit and Thara, Can you take a look at changes when you have a chance. Thanks, Anjelique