From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903F7C4332F for ; Thu, 15 Dec 2022 12:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbiLOMJi (ORCPT ); Thu, 15 Dec 2022 07:09:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbiLOMJ0 (ORCPT ); Thu, 15 Dec 2022 07:09:26 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C97E2D1DA for ; Thu, 15 Dec 2022 04:09:25 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id cf42so15363152lfb.1 for ; Thu, 15 Dec 2022 04:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BonayDXjelRmeYBGGJjvECoETrAi9l86oKUl2f/LTBs=; b=NZqx9pPeB0Pzcb5nIc5vvSOBjvvyGu7zDGqvDIpnGMLF3uCvxylvCo9HlNEZGRtdFP 7VnsQYEW4SsYrnDPa/CwmizqbTb+7Tsn4VRbd0DwMy6iE7KfAAf6QcMoM9eMDxz5zY3b MITKvGFCEu1nxaKaWocTfOJ7QVeQbQ20Qwq54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BonayDXjelRmeYBGGJjvECoETrAi9l86oKUl2f/LTBs=; b=aD7GTti499JZgtO/SFa5shPWeTAAS+20I9BauqEyHWkpxFnTL1/Sqv9jW+7PIlQW9x ygaZAZ8VA5Beblgin7U2kjpIvM47pMB5FIixCefB9PoSP05XjhEOKr571Go1O6JJqBsH aFR4VWkbSpGHO3Ad29KIDN8XFTF8/VA57h7M0XX0oEZfZ0m8iWlsjlVjBEJbmw7CHkSL 0JMxElndUPyYDTsu+/XZj+dSARckJ5pyMXKFciNinVhJTIeFMSA8qDAX+ukTAI6L4YF8 71YsPaqHnygzrCxA6zcMa6DeXyC3me3MxwK4X3Rov5IqRNJt6dA9AEcVxP3z0fHSWFVW C41A== X-Gm-Message-State: ANoB5pmBzhL1VqNoAFnvpuo0n0XkAevgcdmXXZMSNLFaMAk+QU6tlJz3 ReuVbiqkm2bVpfzH6pESKRjCDQ== X-Google-Smtp-Source: AA0mqf6FJx7D+G5p9QQX/o7bT+pFkhw513lLD2u4U9OZ1hBHy2y58Em73i14qx/TWBY6n0pv2ql1ew== X-Received: by 2002:a05:6512:6d1:b0:4a4:7cab:3bad with SMTP id u17-20020a05651206d100b004a47cab3badmr9344432lff.28.1671106163654; Thu, 15 Dec 2022 04:09:23 -0800 (PST) Received: from [172.16.11.74] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id a23-20020a19f817000000b0049465afdd38sm1149721lff.108.2022.12.15.04.09.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 04:09:23 -0800 (PST) Message-ID: Date: Thu, 15 Dec 2022 13:09:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH AUTOSEL 4.9 2/2] net: loopback: use NET_NAME_PREDICTABLE for name_assign_type Content-Language: en-US, da To: Pavel Machek , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jacob Keller , "David S . Miller" , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org References: <20221212103704.300692-1-sashal@kernel.org> <20221212103704.300692-2-sashal@kernel.org> From: Rasmus Villemoes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/12/2022 11.59, Pavel Machek wrote: > Hi! > >> From: Rasmus Villemoes >> >> [ Upstream commit 31d929de5a112ee1b977a89c57de74710894bbbf ] >> >> When the name_assign_type attribute was introduced (commit >> 685343fc3ba6, "net: add name_assign_type netdev attribute"), the >> loopback device was explicitly mentioned as one which would make use >> of NET_NAME_PREDICTABLE: >> >> The name_assign_type attribute gives hints where the interface name of a >> given net-device comes from. These values are currently defined: >> ... >> NET_NAME_PREDICTABLE: >> The ifname has been assigned by the kernel in a predictable way >> that is guaranteed to avoid reuse and always be the same for a >> given device. Examples include statically created devices like >> the loopback device [...] >> >> Switch to that so that reading /sys/class/net/lo/name_assign_type >> produces something sensible instead of returning -EINVAL. > > This was already part of the previous autosel: Yup, but it was punted for a week: https://lore.kernel.org/lkml/Y5AO7TrYsdeVqyI6@sashalap/