From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A357CC43619 for ; Thu, 4 Mar 2021 00:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 796BC64F77 for ; Thu, 4 Mar 2021 00:09:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354438AbhCDAIp (ORCPT ); Wed, 3 Mar 2021 19:08:45 -0500 Received: from mga18.intel.com ([134.134.136.126]:63205 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1390535AbhCCWKK (ORCPT ); Wed, 3 Mar 2021 17:10:10 -0500 IronPort-SDR: SD2vLxZcJ0EFrpvHSy4AUDihSFGvnsysWXdEsFrj9dAbpSTByvGz5K02XsgRwuS88L0OeHVf2B QbxJe+5QraWw== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="174925418" X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="174925418" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 13:59:13 -0800 IronPort-SDR: xPuyXcgcp6AOnk3OFK851lgX0vAM/NBvbQ0XwP74WyfCB4aJvCI4Javx8OhCLDT8ngD4ZjmfuB gl+tbVVgTmgg== X-IronPort-AV: E=Sophos;i="5.81,220,1610438400"; d="scan'208";a="586487017" Received: from srcook1-mobl1.amr.corp.intel.com (HELO [10.209.143.11]) ([10.209.143.11]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 13:59:12 -0800 Subject: Re: [PATCH v2 1/5] soundwire: qcom: add support to missing transport params To: Srinivas Kandagatla , vkoul@kernel.org Cc: sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <20210226155814.27536-1-srinivas.kandagatla@linaro.org> <20210226155814.27536-2-srinivas.kandagatla@linaro.org> <00842f73-c0fb-5728-3ed0-c0a1fd75f94e@linux.intel.com> <31eca99d-9f84-e088-443b-9aae782c2df2@linaro.org> <06a687f6-e79c-9bad-32c2-ea61356f882e@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 3 Mar 2021 10:16:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > soundwire-controller@3210000 { >     reg = <0 0x3210000 0 0x2000>; >     compatible = "qcom,soundwire-v1.5.1"; >     interrupts = ; >     clocks = <&rxmacro>; >     clock-names = "iface"; >     qcom,clock-stop-mode0; >     qcom,din-ports = <0>; >     qcom,dout-ports = <5>; > >     qcom,ports-sinterval-low = /bits/ 8 <0x03 0x1F 0x1F 0x07 0x00>; >     qcom,ports-offset1 = /bits/ 8 <0x00 0x00 0x0B 0x01 0x00>; >     qcom,ports-offset2 = /bits/ 8 <0x00 0x00 0x0B 0x00 0x00>; >     qcom,ports-hstart = /bits/ 8 <0xFF 0x03 0xFF 0xFF 0xFF>; >     qcom,ports-hstop = /bits/ 8 <0xFF 0x06 0xFF 0xFF 0xFF>; >     qcom,ports-word-length = /bits/ 8 <0x01 0x07 0x04 0xFF 0xFF>; >     qcom,ports-block-pack-mode = /bits/ 8 <0xFF 0x00 0x01 0xFF 0xFF>; >     qcom,ports-lane-control = /bits/ 8 <0x01 0x00 0x00 0x00 0x00>; >     qcom,ports-block-group-count = /bits/ 8 <0xFF 0xFF 0xFF 0xFF 0x00>; > >     #sound-dai-cells = <1>; >     #address-cells = <2>; >     #size-cells = <0>; > }; >> properties that may or may not be valid. If this is intentional and >> desired, this should still be captured somehow, e.g. in the bindings >> documentation or in the code with a comment, no? > > Yes, I agree with you on this, I should document this in bindings! thanks for the explanations, it'd be useful indeed to document what this magic 0xFF value means.