From: Huan Yang <link@vivo.com>
To: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "opensource.kernel@vivo.com" <opensource.kernel@vivo.com>
Subject: Re: [PATCH v2 1/4] udmabuf: cancel mmap page fault, direct map it
Date: Mon, 12 Aug 2024 10:49:40 +0800 [thread overview]
Message-ID: <de3f3cc4-5e0a-4524-902f-4913addba227@vivo.com> (raw)
In-Reply-To: <IA0PR11MB718542BA11A38A5BD40ECB00F8BB2@IA0PR11MB7185.namprd11.prod.outlook.com>
在 2024/8/10 9:28, Kasireddy, Vivek 写道:
> [Some people who received this message don't often get email from vivek.kasireddy@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Hi Huan,
>
>> The current udmabuf mmap uses a page fault mechanism to populate the
>> vma.
>>
>> However, the current udmabuf has already obtained and pinned the folio
>> upon completion of the creation.This means that the physical memory has
>> already been acquired, rather than being accessed dynamically. The
>> current page fault method only saves some page table memory.
>>
>> As a result, the page fault mechanism has lost its purpose as a demanding
>> page. Due to the fact that page fault requires trapping into kernel mode
>> and filling in when accessing the corresponding virtual address in mmap,
>> this means that user mode access to virtual addresses needs to trap into
>> kernel mode.
>>
>> Therefore, when creating a large size udmabuf, this represents a
>> considerable overhead.
>>
>> The current patch removes the page fault method of mmap and
>> instead fills it directly when mmap is triggered.
> I think it makes sense to populate the vma when the first fault is triggered
> instead of doing it during mmap. This is because the userspace may call
> mmap but does not actually use the data. Qemu works this way depending on
Yes, the idea of this is also related to the concept of page fault.
However, the folio has already been pinned during creation. I think
using the page fault
again is theoretically sound, but it may not save memory, only increase
context switch overhead.
> whether opengl is available in the environment or not.
>
>> Signed-off-by: Huan Yang <link@vivo.com>
>> ---
>> drivers/dma-buf/udmabuf.c | 39 ++++++++++++++++-----------------------
>> 1 file changed, 16 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
>> index 047c3cd2ceff..475268d4ebb1 100644
>> --- a/drivers/dma-buf/udmabuf.c
>> +++ b/drivers/dma-buf/udmabuf.c
>> @@ -38,36 +38,29 @@ struct udmabuf_folio {
>> struct list_head list;
>> };
>>
>> -static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf)
>> -{
>> - struct vm_area_struct *vma = vmf->vma;
>> - struct udmabuf *ubuf = vma->vm_private_data;
>> - pgoff_t pgoff = vmf->pgoff;
>> - unsigned long pfn;
>> -
>> - if (pgoff >= ubuf->pagecount)
>> - return VM_FAULT_SIGBUS;
>> -
>> - pfn = folio_pfn(ubuf->folios[pgoff]);
>> - pfn += ubuf->offsets[pgoff] >> PAGE_SHIFT;
>> -
>> - return vmf_insert_pfn(vma, vmf->address, pfn);
>> -}
>> -
>> -static const struct vm_operations_struct udmabuf_vm_ops = {
>> - .fault = udmabuf_vm_fault,
>> -};
>> -
>> static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct
>> *vma)
>> {
>> struct udmabuf *ubuf = buf->priv;
>> + unsigned long addr;
>> + unsigned long end;
>> + unsigned long pgoff;
>> + int ret;
>>
>> if ((vma->vm_flags & (VM_SHARED | VM_MAYSHARE)) == 0)
>> return -EINVAL;
>>
>> - vma->vm_ops = &udmabuf_vm_ops;
>> - vma->vm_private_data = ubuf;
>> - vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND |
>> VM_DONTDUMP);
>> + for (pgoff = vma->vm_pgoff, end = vma->vm_end, addr = vma-
>>> vm_start;
>> + addr < end; pgoff++, addr += PAGE_SIZE) {
>> + struct page *page =
>> + folio_page(ubuf->folios[pgoff],
>> + ubuf->offsets[pgoff] >> PAGE_SHIFT);
> Please don't use struct page pointers, given the recent conversion to use
> only folios in udmabuf driver. I think what you are trying to do above can
> be done using only folios.
Yes, just use pfn. Consider of HVO, must use this.
>
>> +
>> + ret = remap_pfn_range(vma, addr, page_to_pfn(page),
>> PAGE_SIZE,
>> + vma->vm_page_prot);
> Could you please retain the use of vmf_insert_pfn() here, given the simplicity,
> among other reasons?
I will make the correction.
Thanks.
>
> Thanks,
> Vivek
>
>> + if (ret)
>> + return ret;
>> + }
>> +
>> return 0;
>> }
>>
>> --
>> 2.45.2
next prev parent reply other threads:[~2024-08-12 2:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 3:25 [PATCH v2 0/4] udmbuf bug fix and some improvements Huan Yang
2024-08-05 3:25 ` [PATCH v2 1/4] udmabuf: cancel mmap page fault, direct map it Huan Yang
2024-08-10 1:28 ` Kasireddy, Vivek
2024-08-12 2:49 ` Huan Yang [this message]
2024-08-22 8:11 ` Christian König
2024-08-05 3:25 ` [PATCH v2 2/4] udmabuf: change folios array from kmalloc to kvmalloc Huan Yang
2024-08-10 1:29 ` Kasireddy, Vivek
2024-08-12 2:49 ` Huan Yang
2024-08-05 3:25 ` [PATCH v2 3/4] fix vmap_udmabuf error page set Huan Yang
2024-08-10 2:39 ` Kasireddy, Vivek
2024-08-12 2:49 ` Huan Yang
2024-08-05 3:25 ` [PATCH v2 4/4] udmabuf: remove folio unpin list Huan Yang
2024-08-10 2:52 ` Kasireddy, Vivek
2024-08-12 2:49 ` Huan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de3f3cc4-5e0a-4524-902f-4913addba227@vivo.com \
--to=link@vivo.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®