From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C379B3B9613 for ; Fri, 24 Apr 2026 12:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777032720; cv=none; b=DbyzA5/k76z4kwsz8yM/lqYJ7FYy6I3vRtwLgGJlpldUD2BJxRxMZWaQPWu0e7REbQTiB0AC0mpepVBegrD3tKjex+RNWAWrYlDLtNpPA2Or9GTBFQEKoCg0OGZVHvY2YuaOcjFWcXTy+wQGpFahc41gPD3wWWUcE9gbCfgamK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777032720; c=relaxed/simple; bh=H1Bq2JCd/loHLBUg6D2e8MYj9Z1jJAKfSptt326NEw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hI86JQGM4vDbOL//fEn6llHOTgdGnHZj5ponOefBCoPdr6LwMxjQOBGKsV+AAHYVPasi0CZ8iXfXaa+f3rKfFBMtyp/C/JuCZuA0ol7YIfptLEtCqWqbJzFuPJiWB4zDZ04eZq0vDFM29a0Ej+WJJspx3Vszk2IqyOT4ppDr2LA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gPHph5Om; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hL8T1SJN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gPHph5Om"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hL8T1SJN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63O9YnO3756737 for ; Fri, 24 Apr 2026 12:11:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kxwXFmbu6qnj8uhNBxLJ+V0C+GzpicEK+P3K4wNFbkU=; b=gPHph5Omzw4vLOGt bENFkCA2LJZ3qgd3kXQnydDzLRpg6Gj/afKiXPs/RjW5cSjPmKv6XQchB9gRjFS9 uMFg0dkt/yFwZyNT8xbrDfjhnXvOXmj42m2KSrMaJ6BfnR5XE7oCINcRKgu47wOy FL5kO+hTeyF1gZsRjce3jZp5KZj6Rp5MFpZcFPOVGjB0OdsPlaYfW+3wdFeu0Zzk z1zTzjTawWOhDypgjGUN3/gvIOQVMoNN3zYKUcewx9GtJVbH+pCWwdKCSiK8IkiQ sht2KT5S1VhBl2QFJnsMWoqEk2gSwFQgCkGvk1+b3aZlMflf3wJ0Rf4nVXYTWYTo OBHHXQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqr4bm1qw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 12:11:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d8c183c2eso70427501cf.0 for ; Fri, 24 Apr 2026 05:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777032717; x=1777637517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kxwXFmbu6qnj8uhNBxLJ+V0C+GzpicEK+P3K4wNFbkU=; b=hL8T1SJNuqgixFgsuHWy6H7gajkDStQSjkAW4fMFYcVOK4fcF3+tuzcVMJ/xoWSyUM z03W95A1wadgUy4ApasO/mHAUKzJvHgXK4q/QEXudkyivIFSLp42TlstDcX9Jhp6nBLE zCBaaI5Mvgl5sNl73v+tsxeckeE3WKR4kX2sUuLhhAH0JIUVcgO4wfuK5gVxBCDK+0ep e97QGQ9hTWjxPeEEN9504hbAqx6qB0hjFJ6Jtdfrj/+J3FEc3RYPX/rlwNe+zDfSd/8z IL6J5rovCTnQD0RvpZfWviXygoeIYoTKCxg2Cz6EF0DKGTEzOTvyF54aE/GWVmCbkJ5X XUIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777032717; x=1777637517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kxwXFmbu6qnj8uhNBxLJ+V0C+GzpicEK+P3K4wNFbkU=; b=lIN2oQctx+EUHoV0cZGNTEXjut/7+IOV01PlLL860dOttVsmSGS9mOwZ5aA6qnBIXv OcJtQlc7PJgovSPJYhFxCaFAcqz+DN/gBA95xstdAujatmgU3Tl8psnD4hJLyNe/iMfq Ntho6sNGjede2AswK1Vu2OHOzgzU74Z9wqL3ziNhwllXhM+stGAWX4Ygc8opD79ynYCy ZkR1ZFBJ9yA0AiphFBxjR1fO/tg59RkcDihx0xnBglzXUeTpbbVNgKsTNLipyvRRXktH CaV3nTC7WhCjMSWkxcsd6+3M0RhY6C7o5T+jqBbDFniUohnEAXxFYMcXs1kNGWgTnk/6 t0Gw== X-Forwarded-Encrypted: i=1; AFNElJ9TtlWN3oy5gd+Bg9MfuedhOvMOu9bqkdTquUzRtupTzUgBMNcmqEi5Sh+PpTOrzIG93THMPffMCRk3Als=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2jHVImClDX9usLOL4fUZh3YsK0ZO/iVo2mGsn+NlI+S90yZfY OHZUIscfPBBV5b4e2OjEMjf9fYyApi4MwKq57tUn85mP8OKcNFZMpehojFJHpqYfMtZzYiG72pM TdLJIGRgJSN2EfXVuqqKGqfrsda3jF0tET5XsabeWgAcFh2UdbwZXo6W4hZmNOHXVs40= X-Gm-Gg: AeBDieuy6YbCiqzyKVLVoPWl3Y9MBcQu0rmvz0jSuDIs0tvaf+vPlik0oLw0/NOEXZu FvTEG1VHj+XKLjGNwmYjVxFJ0hbhv146DGbMu+ikxHoSB2NgtqYk50CwdlWXMmshx8XD8ZxZTwx mesfG5K4EZ1EPHAlmnk1hdm79MGHmb3ASQbzdX+VQ+zhIXsIOsGu6+T668mm3zjQCUqGPSz0Dc9 hRfEVxnFxfOX3WyoaJDBni7SuTXxPyo1MNi2VFuWdQC6NE44qsz5NcBjMG4VhgzASsdcygNdCNT B9+cXKzfJqt9Q6k+2/YusfendSvWf2IAhaoaTlC+YMFwL04lsd0Iu2z8U6ctQBEx9Xw2mQQZCY4 sr5Ypab+3604PsaFjGf/H1/k5WD0BSLV9Qn30e828GaVf7IQqop3xumRLbcMP59dqEuQ75pMT33 VDWdzYQEFkml3ddA== X-Received: by 2002:ac8:7fd2:0:b0:50b:3489:5495 with SMTP id d75a77b69052e-50e36c9d407mr324193131cf.8.1777032717098; Fri, 24 Apr 2026 05:11:57 -0700 (PDT) X-Received: by 2002:ac8:7fd2:0:b0:50b:3489:5495 with SMTP id d75a77b69052e-50e36c9d407mr324192511cf.8.1777032716532; Fri, 24 Apr 2026 05:11:56 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6743fba7321sm4354260a12.0.2026.04.24.05.11.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 05:11:55 -0700 (PDT) Message-ID: Date: Fri, 24 Apr 2026 14:11:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/6] arm64: dts: qcom: Add AYN QCS8550 Common To: webgeek1234@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin References: <20260408-ayn-qcs8550-v5-0-c90abeb7a152@gmail.com> <20260408-ayn-qcs8550-v5-3-c90abeb7a152@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260408-ayn-qcs8550-v5-3-c90abeb7a152@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDExNiBTYWx0ZWRfXxr35EhgVYxY2 APL0A+o+eWZKG9Xr2WKea+fynraAM8rVW6R/SZhWjKvru2jEF8/XjmKFO+F/Y/FBg9siUS3WvV3 nRJoKTig2LL//SclZ8vCpX2NxHEwIniLnxSsjJ48Y7oRc0CexURzMcAmobjlvrG5Z/COQb66rly 3cW+SPt9ilKL/BWxVJJr405pSClXnLxZqIv+cx6QExcnSWTXgraqoJkFTm4nnOhQrvADYagLyd8 buWnUkvlHNZJ7kzQAIFE1QnuA9FNTs+m9abMB5tqJM9rlOSfQIF1ss1JPosXu6tkEtq1raaDKqE hop1m6UeMwve/GbL38sVf0fOTRkPZEHhPd1h7EeA2099ApiU7nA50lcH4lv+aT//v6wTeq4EyoX lGDEvnLFVpeOyytiCgVOcEjB6ocad9kw22w/QNYhHx50dTMrdEmzBvCvB5ol6nSwSbWF2J8AT4r 54uG1TuQFbr5n6xA5KA== X-Authority-Analysis: v=2.4 cv=TtnWQjXh c=1 sm=1 tr=0 ts=69eb5e0d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=pGLkceISAAAA:8 a=ExZjEUzYGPi_yzd-oLQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: xvgjulULx_OfD7dgdW75nR-G05i5jET3 X-Proofpoint-GUID: xvgjulULx_OfD7dgdW75nR-G05i5jET3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240116 On 4/8/26 9:41 PM, Aaron Kling via B4 Relay wrote: > From: Teguh Sobirin > > This contains everything common between the AYN QCS8550 devices. It will > be included by device specific dts'. > > Signed-off-by: Teguh Sobirin > Co-developed-by: Aaron Kling > Signed-off-by: Aaron Kling > --- [...] > + // The tzlog label is required by ABL to apply a dtbo, but it can be on any node I don't know if the policy changed, but I think C-style (/* Foo */) comments are still preferred [...] > + // The arch_timer label is unused here, but is required by ABL to apply a dtbo > + arch_timer: timer { }; ditto [...] > +&pm8550_gpios { > + fan_pwm_active: fan-pwm-active-state { > + pins = "gpio8"; > + function = "func1"; > + input-disable; > + output-enable; > + output-low; Looks like this should be a regulator then, probably? [...] > + wcd_default: wcd-reset-n-active-state { > + pins = "gpio108"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low; no need for this property > + }; > + > + fan_pwr_active: fan-pwr-active-state { > + pins = "gpio109"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + output-low; likewise, especially since it's the opposite of the active state defined in the vreg node [...] > + usb0_sbu_default: usb0-sbu-state { > + oe-n-pins { > + pins = "gpio140"; > + function = "gpio"; > + bias-disable; > + drive-strength = <16>; > + output-high; This is probably not required too.. unless there's a hw bug? fwiw 16 mA is a very high drive-strength - does this come from vendor sources? Konrad