From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EB626F476 for ; Fri, 31 Jul 2026 03:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785467235; cv=none; b=AovrvRs8Bhj+ETqP0PRYbKpp+CHIKjKpmcbh7Ua+mSgUrsr9IVB8wG/ED+ruagDaKNjywR8pi839WYoVwHPudEA6ZJ6lOy3zzFel7DjrU72ovvmejPuTumlB7qX3m43T7bbpGG5ZL73EXrl7mclEegYF8KTtmRYz8D7Ou+aXP+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785467235; c=relaxed/simple; bh=vL2uAWXAmfycxsp31+OxgVS/U1yQANdoF5/6yak7oog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j3is9mq0+TGmZrvhSoE8vCm4J3okEVWernufbv41IO32ODjLSb4P95CL6+FqaX/xzpTUErUKH26TYzLsKalDV02spDHhNmkPeTwaqBWkL0QxSFcvG4MgMpoE5td8/KZYfrbGghqdlUAwc+y42nvoGTImTcQmHlqBuG8O8B5MoMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IfQUe+C7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aQ0R13E4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IfQUe+C7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aQ0R13E4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V2IVDW2781263 for ; Fri, 31 Jul 2026 03:07:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= StiQNB/VgRXxVtOeJyl+DtEvUetWYYDQ1khQl5juSWY=; b=IfQUe+C7F3CI/DwO u8rqx0uFITn9/Z3ZOWTe7Noy5kzFgisOH+VNS4QD5BWvCcL30ZnSiSDUlO+q8RXz DmbqqoC0RxX2bI3VZGdV2fahfdaEw5099hTK9tyLy/2JbZm8p9SLqjKw2ry+x73r 86w4GGsgKi0XSDZqPwr4RCDyre9H55DIEVoXWxUe3+CY2sys+ob1UXNjcPIUJyhH qYQymYAmOMENqOT7TyB+u+S5UFCYFMPFcxZNC+KxEDNZr1+NilLNIJY/6ltavVIW XcL8hpfRcyvslvcJtPH4WilgdF4emdWgMWtsLMojMPKzrPL/MvQKGjymiFSrQ/kq 8lzsVw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frjtag513-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 03:07:12 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c9c26587e67so352629a12.0 for ; Thu, 30 Jul 2026 20:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785467232; x=1786072032; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=StiQNB/VgRXxVtOeJyl+DtEvUetWYYDQ1khQl5juSWY=; b=aQ0R13E4y7rKxmRPxDVWnfI7S4aLASlm6LMhAbFFsQku/CumVdHClc6+lzHot+uT/H 7BubJ0fdm+DqrbOrVfFV9llXw0JY6oGxZv5tgpfn0csc2+WzN+GWDGETQI8daWLn/AAl mJVR8zvxo/ucCO8OM/VoMs7T34wHO84qW4sQSGM4/uWbGKcQwqYmtQh8s+HM4+ZpamHK 78xIuE01s6DyBs2HHpa/6a/+c2QIV9jJc/iyuGn44qlRuM+PJwpqhw678ndaSFSmzRyH yRH5rR6p+DGGWxBruYZuHsvoJpjYY1raCXRoOioxmGfBQGXe7RynWMg3Bt7CFcuk7T77 lmsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785467232; x=1786072032; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=StiQNB/VgRXxVtOeJyl+DtEvUetWYYDQ1khQl5juSWY=; b=tAXH2qQaQuZLOes8EKoSy5fEu5GVC3cAYsgPBIL+gDuLh3McguENxEzMb04JYJkt/p 5bwxbQgAoodTV4cOgIQLB3GRDX+2x9QIaqLDVI70JZ5hUmsH6wVMZeJMF0c5eaQVuVhj LH6jhbU6qTlLylIR75RK5/+eI4WjCbKtauWRT0LiMlK/P1TyJyb/olS2rcXOdQbZ68YK CNFWwoatdVnlyhyuK+Gr4geJ/+EoIqZG4Cy0DuvklEzn2XlPYDWK0VPbj008ycNluWaF Cn1nCmkmTSf3c/Oc/uq2GQsB/lJaWPlM6d3yFbUBDC0TLw/aDh/09uZ3IhQQY1Ndtvir LYZQ== X-Forwarded-Encrypted: i=1; AHgh+RpEwk+WLe0Ag2pxsd6xvsLCFxiOvZjLg8qRnDI4T3wnRIHWdgfMmQBJ1qe6kSzqIIJAKrvl1uhzRo16Nig=@vger.kernel.org X-Gm-Message-State: AOJu0YxEOii++8gSeph0EtNSIFmefGr26ekKc1JsIonI7a8KyGzgjlpW 9BSXABiZrZ++7FISP5eyll7bZ9hbpe7KZv2Ogpye94zRlrfAcwJTzmtPRuBRlSt/hW2t6F7M+uA Wva040oKN6wrrGE0O/5x40+F9KOZwmsASUyzrOkd5u8F+dqiQkNbIFu84z95AGlAekpU= X-Gm-Gg: AR+sD123qt83CBnTBBMczcn/vrVc2DcwjXIfRvLN0caJUV5Ij+1k7fioUbJetLRT/+Y p6lqTvy42jo6XrxKXIXEP1QybLnyzvHfIV4P9YaSZ0hx2e8K4M1DzqlQrdpTR4HzMAKnmXHrMNI NWNWcFXRMnY5SZHH50WVoEfBVxgXTz7WTy+VEGB4OLQkHGu8tdBbSa+Y/MbbfWr4sC+9d+d66Jz kO9lt+Zzw3tKaH8v7q53e20kURvRdpr6cM+gLKwoSVS0uO0v5LRi0tLUDRMB/tOsdI2JmJmhNZV QlSoq2nx9/HtejUL+O3PMpb0yxigehqg4dgS/0frWZ1pXT5d7XmhKJawiarmM4nOcQ6nDyfTxlU u9Cb+pXmlJqdz4SGvSZNqI3l9WQohWjitxgA5l+wzZ0LcPKr77XtBXah0L4vRcyc51ygKCerzog == X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr251201637.38.1785467231566; Thu, 30 Jul 2026 20:07:11 -0700 (PDT) X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr251164637.38.1785467231071; Thu, 30 Jul 2026 20:07:11 -0700 (PDT) Received: from [10.133.33.108] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe3836a898sm101127a12.15.2026.07.30.20.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 20:07:10 -0700 (PDT) Message-ID: Date: Fri, 31 Jul 2026 11:07:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next v2 0/2] wifi: ath11k: fix SoC reboot on firmware crash on AHB To: Julius Bairaktaris , jjohnson@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, vasanthakumar.thiagarajan@oss.qualcomm.com, rameshkumar.sundaram@oss.qualcomm.com References: <20260726221908.104873-1-julius@bairaktaris.de> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260726221908.104873-1-julius@bairaktaris.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDAxNyBTYWx0ZWRfX8N9idtKQExme yT0dJ4WezEQswd0Kr7i/k+5XGz0KjbQYP20e0p7c/NEyj4cOKEvyEv2i4AJp97Vn6m6Vqi+PEDw /nIVZ40xqxxB8lkwEeLMyRvMdYxHKUj/P4rT/4zt/NeJnWlyZIuhv4Xt5V3Hqb4Itn9OnhremdG iBj5nVny/ChdIRFKudGgubvsQHpFw3DzDQ0FWa83CY8Mno6rXBDPesAAINGx+dWg43hMdyueY4M nSWIbDlcEHE/BDYjd3AWlI85fLXeJjD4BHjX843tPw+zDpCE2yf6YsS9H8GrqZacb7kEaIiFMOc 9prNhgdK89b4n5p4Xe07Qlc6ylrYjg9XwmwDKnEGhg73Df/Z077EiWjNKfbhVUO27ZOPgxzgCxU C2Oo3OJs/BuGptBu7AJ2/Y+O9Hua72Omkzxav6lLK0PD/X2l2AYqv/0jEi/RAhJNve6Rm/Ppdu+ xWWfw2Wm2uRccApyHxw== X-Authority-Analysis: v=2.4 cv=ZdYt8MVA c=1 sm=1 tr=0 ts=6a6c1160 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hCEygx0HL4Tx5WVe8Q4A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: yQTRctW7lCRhQPV5I9K_6ikDEjT87ZPQ X-Proofpoint-GUID: yQTRctW7lCRhQPV5I9K_6ikDEjT87ZPQ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDAxNyBTYWx0ZWRfX3Z4RVN99llZu /O7X6qqstG4NuBmaldLPJM+MH+ni35h78PuJLYih53mpjk+YExCunwvvn1fu2C+Ru+seZjFc+Zb KAIxezn+pGZeWhL2+OTREMyuBnfjDmA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_01,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310017 On 7/27/2026 6:19 AM, Julius Bairaktaris wrote: > On IPQ8074 every firmware assert takes the whole SoC down. The DP NAPI > keeps polling while ath11k_core_reconfigure_on_crash() frees the data > path underneath it, and dereferences a ring the teardown has already > cleared. > > The interrupts used to be disabled at the top of that function. > commit d455e805de70 ("wifi: ath11k: rearrange IRQ enable/disable in reset path") > moved the disable into ath11k_core_reset(), which AHB parts never reach > on a real firmware crash: reset_work is queued only from mhi.c and from > the debugfs hw-restart handler. Patch 2 puts the disable back on the > crash path. Patch 1 is a prerequisite - the CE half of the quiesce is a > no-op on AHB today because the bus never implemented the hif ops. > > Reproduced and fixed on a Xiaomi AX3600 (IPQ8074 hw2.0), with no > out-of-tree modules loaded, using the debugfs simulate_fw_crash > 'assert' trigger: > > before: 2/2 asserts panic in ath11k_dp_rx_process_mon_status() and > reboot the SoC > after: 3/3 asserts recover, 5 firmware boots across a single 397 s > uptime, no panics, both radios stay up > > Note the debugfs 'hw-restart' trigger does not reproduce this, since it > goes through ath11k_core_reset() - the one path that still disables the > interrupts. Only a real firmware assert does. > > Patch 1 is by inspection: it makes ath11k_hif_ce_irq_disable() take > effect on AHB, which also fixes the existing call in > ath11k_core_reset(). I have not managed to trigger a CE-side crash on > its own, so if you would rather see that split out or dropped, say so. > > Changes in v2 (no functional change, review comments from Jeff on 2/2): > - separate the ath-specific Tested-on tag from the upstream tags with a > blank line > - use the standard kernel block comment style, with /* on its own line > > v1: https://lore.kernel.org/ath11k/20260725141757.1316877-1-julius@bairaktaris.de/ > > Julius Bairaktaris (2): > wifi: ath11k: implement CE interrupt enable/disable for AHB > wifi: ath11k: disable interrupts during firmware crash recovery > > drivers/net/wireless/ath/ath11k/ahb.c | 9 ++++++++- > drivers/net/wireless/ath/ath11k/core.c | 10 ++++++++++ > 2 files changed, 18 insertions(+), 1 deletion(-) > Reviewed-by: Baochen Qiang