From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760700AbdJQUrK (ORCPT ); Tue, 17 Oct 2017 16:47:10 -0400 Received: from mail-ua0-f195.google.com ([209.85.217.195]:54609 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753373AbdJQUrI (ORCPT ); Tue, 17 Oct 2017 16:47:08 -0400 X-Google-Smtp-Source: ABhQp+SS8p5FejHjMirPRoYeCIdwheQV1lGe74kM5+k5K/vsfF0qSpjNSvMfd9nkvbrg4xJMxJ9IjQ== Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi_init() To: SF Markus Elfring , openipmi-developer@lists.sourceforge.net Cc: LKML , kernel-janitors@vger.kernel.org References: From: Corey Minyard Message-ID: Date: Tue, 17 Oct 2017 15:47:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2017 03:36 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Oct 2017 22:30:11 +0200 > > Omit an extra message for a memory allocation failure in this function. Thanks, queued for the next release. -corey > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/char/ipmi/ipmi_si_intf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 55e0c42bee4d..2aed46a6c49c 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2095,7 +2095,6 @@ static int try_smi_init(struct smi_info *new_smi) > /* Allocate the state machine's data and initialize it. */ > new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL); > if (!new_smi->si_sm) { > - pr_err(PFX "Could not allocate state machine memory\n"); > rv = -ENOMEM; > goto out_err; > }