From: Jiri Slaby <jirislaby@kernel.org>
To: Colin King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: synclink_gt: remove redundant initialization of variable count
Date: Tue, 20 Apr 2021 13:02:58 +0200 [thread overview]
Message-ID: <de4f4627-a3e4-aa85-c10d-99677c6fcb57@kernel.org> (raw)
In-Reply-To: <20210420105718.377086-1-colin.king@canonical.com>
On 20. 04. 21, 12:57, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable count is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/synclink_gt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
> index 994618618466..5523cf7bd1c2 100644
> --- a/drivers/tty/synclink_gt.c
> +++ b/drivers/tty/synclink_gt.c
> @@ -4958,7 +4958,7 @@ static int loopback_test(struct slgt_info *info)
> #define TESTFRAMESIZE 20
>
> unsigned long timeout;
> - u16 count = TESTFRAMESIZE;
> + u16 count;
> unsigned char buf[TESTFRAMESIZE];
> int rc = -ENODEV;
> unsigned long flags;
>
--
js
prev parent reply other threads:[~2021-04-20 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 10:57 Colin King
2021-04-20 11:02 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de4f4627-a3e4-aa85-c10d-99677c6fcb57@kernel.org \
--to=jirislaby@kernel.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome