From: Laurence Oberman <loberman@redhat.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Ming Lei <ming.lei@redhat.com>,
David Jeffery <djeffery@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: recalculate segment count for multi-segment discard requests correctly
Date: Wed, 03 Feb 2021 08:50:22 -0500 [thread overview]
Message-ID: <de50b6b8c867ec1f88df54f92134a99b086da8ac.camel@redhat.com> (raw)
In-Reply-To: <BYAPR04MB4965222989DE60A2F198358286B49@BYAPR04MB4965.namprd04.prod.outlook.com>
On Wed, 2021-02-03 at 03:15 +0000, Chaitanya Kulkarni wrote:
> On 2/2/21 18:39, Ming Lei wrote:
> > + /* fall through */
> > case REQ_OP_WRITE_ZEROES:
> > - return 0;
>
> I don't think returning 1 for write-zeroes is right,
> did you test this patch with write-zeores enabled controller with
> the right fs that triggers this behavior ?
>
>
I tested the first iteration of the patch fully mounting an XFS file
system with -o discard and creating and deleting files.
That was our specific RHEL8 failure we were handling here with David's
first submission.
I can test his most recent, I have not done that yet.
Again, please follow up with exactly what you want based against
David's patch and I can test that.
Regards
Laurence
next prev parent reply other threads:[~2021-02-03 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:48 David Jeffery
2021-02-02 3:33 ` Ming Lei
2021-02-02 20:43 ` David Jeffery
2021-02-03 2:35 ` Ming Lei
2021-02-03 3:15 ` Chaitanya Kulkarni
2021-02-03 13:50 ` Laurence Oberman [this message]
2021-02-03 15:08 ` Laurence Oberman
2021-02-03 3:18 ` Chaitanya Kulkarni
2021-02-03 16:23 ` David Jeffery
2021-02-04 2:18 ` Ming Lei
2021-02-04 2:27 ` Ming Lei
2021-02-04 16:43 ` Laurence Oberman
2021-02-08 18:53 ` Laurence Oberman
2021-02-08 18:58 ` John Pittman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de50b6b8c867ec1f88df54f92134a99b086da8ac.camel@redhat.com \
--to=loberman@redhat.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=djeffery@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®