From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C79BC54EBE for ; Thu, 5 Jan 2023 06:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbjAEGV4 (ORCPT ); Thu, 5 Jan 2023 01:21:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbjAEGV3 (ORCPT ); Thu, 5 Jan 2023 01:21:29 -0500 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0EA51334; Wed, 4 Jan 2023 22:21:28 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso562533wmp.3; Wed, 04 Jan 2023 22:21:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZAEMQFdfgVBcmOVq2pNOL15xuSdJkLLmqjgylxoc+Sk=; b=PLEr4PHUbbArUyMcSpFnEXGftMwdxViKNYWQ4snnieH9SKsdQwYrqCjP1ItfPJRCEQ IaxkOOR9Ndzlh803Ip9N+3/e1mKby6xUEREoK/eqMXCycuKeA5PBXi8OmaAEC63MQdU3 MH0XVjr9VBOA1PSJEgkmX3mNvx7yXFVgfGbmcv4ukzzpWzvSwgr67X105c+ClRG/353P E2+qQlffgoNvC/F4gQ8ezyaIsJdh7uYBufghtti3RzjsfMEiuqltY+SzlbixpQMTyBJY YBmFD6Yi31ifAkYTaTOnkgPGkFIn4dnrkmXVIHgtW2O+vsdSiSWngqGjP3RQekmiRN90 qvGw== X-Gm-Message-State: AFqh2kqWueU9t4w+Ssfd5vs5D8cnfl4XyYdIj4wV/5TqoEntHyIRBk2R AH1zD2J0EczD+wPxYHqsNzc= X-Google-Smtp-Source: AMrXdXtjXHqhoeoZ1KizKFs5ywBzvrDm8GK2iCayrbwAQ5Jm2g2BgyV1ip7zp2zWX3Yh9NlupvFNbg== X-Received: by 2002:a05:600c:1e24:b0:3d3:5075:7526 with SMTP id ay36-20020a05600c1e2400b003d350757526mr36594024wmb.31.1672899687507; Wed, 04 Jan 2023 22:21:27 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:49? ([2a0b:e7c0:0:107::aaaa:49]) by smtp.gmail.com with ESMTPSA id i3-20020a1c5403000000b003cf5ec79bf9sm1177448wmb.40.2023.01.04.22.21.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 22:21:27 -0800 (PST) Message-ID: Date: Thu, 5 Jan 2023 07:21:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 08/10] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Rodolfo Giometti , "David S. Miller" , Johan Hovold , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org References: <20230104151531.73994-1-ilpo.jarvinen@linux.intel.com> <20230104151531.73994-9-ilpo.jarvinen@linux.intel.com> From: Jiri Slaby In-Reply-To: <20230104151531.73994-9-ilpo.jarvinen@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04. 01. 23, 16:15, Ilpo Järvinen wrote: > Convert status parameter for ->dcd_change() and > uart_handle_dcd_change() to bool which matches to how the parameter is > used. > > Signed-off-by: Ilpo Järvinen Reviewed-by: Jiri Slaby > --- a/include/linux/serial_core.h > +++ b/include/linux/serial_core.h > @@ -896,8 +896,7 @@ static inline bool uart_softcts_mode(struct uart_port *uport) > * The following are helper functions for the low level drivers. > */ > > -extern void uart_handle_dcd_change(struct uart_port *uport, > - unsigned int status); > +extern void uart_handle_dcd_change(struct uart_port *uport, bool status); > extern void uart_handle_cts_change(struct uart_port *uport, > unsigned int status); Note to myself: huh, we still have some superfluous "extern"s in headers. thanks, -- -- js suse labs