From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<namhyung@kernel.org>, <will@kernel.org>, <ak@linux.intel.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<james.clark@arm.com>, <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH v2 2/7] perf jevents: Support test events folder
Date: Tue, 17 Mar 2020 16:25:32 +0000 [thread overview]
Message-ID: <de5b58ee-980e-973a-16db-73f23c3edfef@huawei.com> (raw)
In-Reply-To: <20200317162052.GD759708@krava>
On 17/03/2020 16:20, Jiri Olsa wrote:
> On Tue, Mar 17, 2020 at 07:02:14PM +0800, John Garry wrote:
>> With the goal of supporting pmu-events test case, introduce support for a
>> test events folder.
>>
>> These test events can be used for testing generation of pmu-event tables
>> and alias creation for any arch.
>>
>> When running the pmu-events test case, these test events will be used
>> as the platform-agnostic events, so aliases can be created per-PMU and
>> validated against known expected values.
>>
>> To support the test events, add a "testcpu" entry in pmu_events_map[].
>> The pmu-events test will be able to lookup the events map for "testcpu",
>> to verify the generated tables against expected values.
>>
>> The resultant generated pmu-events.c will now look like the following:
>
> can't compile this one:
>
> HOSTCC pmu-events/jevents.o
> pmu-events/jevents.c: In function ‘main’:
> pmu-events/jevents.c:1195:3: error: ‘ret’ undeclared (first use in this function)
> 1195 | ret = 1;
> | ^~~
> pmu-events/jevents.c:1195:3: note: each undeclared identifier is reported only once for each function it appears in
> pmu-events/jevents.c:1196:3: error: label ‘out_free_mapfile’ used but not defined
> 1196 | goto out_free_mapfile;
> | ^~~~
> mv: cannot stat 'pmu-events/.jevents.o.tmp': No such file or directory
> make[3]: *** [/home/jolsa/kernel/linux-perf/tools/build/Makefile.build:97: pmu-events/jevents.o] Error 1
> make[2]: *** [Makefile.perf:619: pmu-events/jevents-in.o] Error 2
> make[1]: *** [Makefile.perf:225: sub-make] Error 2
> make: *** [Makefile:70: all] Error 2
Hi jirka,
What baseline are you using? I used v5.6-rc6. The patches are here:
https://github.com/hisilicon/kernel-dev/commits/private-topic-perf-5.6-pmu-events-test-upstream-v2
thanks,
John
next prev parent reply other threads:[~2020-03-17 16:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 11:02 [PATCH v2 0/7] perf test pmu-events case John Garry
2020-03-17 11:02 ` [PATCH v2 1/7] perf jevents: Add some test events John Garry
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 2/7] perf jevents: Support test events folder John Garry
2020-03-17 16:20 ` Jiri Olsa
2020-03-17 16:25 ` John Garry [this message]
2020-03-17 17:06 ` Jiri Olsa
2020-03-17 17:42 ` John Garry
2020-03-17 20:41 ` Arnaldo Carvalho de Melo
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 3/7] perf pmu: Refactor pmu_add_cpu_aliases() John Garry
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 4/7] perf test: Add pmu-events test John Garry
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 5/7] perf pmu: Add is_pmu_core() John Garry
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 6/7] perf pmu: Make pmu_uncore_alias_match() public John Garry
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-17 11:02 ` [PATCH v2 7/7] perf test: Test pmu-events aliases John Garry
2020-03-17 16:20 ` Jiri Olsa
2020-03-17 16:41 ` John Garry
2020-03-17 17:07 ` Jiri Olsa
2020-03-19 18:36 ` Arnaldo Carvalho de Melo
2020-03-20 9:24 ` John Garry
2020-03-20 9:30 ` Jiri Olsa
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for John Garry
2020-03-18 7:57 ` [PATCH v2 0/7] perf test pmu-events case Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5b58ee-980e-973a-16db-73f23c3edfef@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qiangqing.zhang@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®