From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbcIOOfX (ORCPT ); Thu, 15 Sep 2016 10:35:23 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:55394 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751098AbcIOOfN (ORCPT ); Thu, 15 Sep 2016 10:35:13 -0400 Subject: Re: blk-mq: allow passing in an external queue mapping V3 To: Christoph Hellwig , Keith Busch References: <1473862739-15032-1-git-send-email-hch@lst.de> <20160915144050.GD16556@localhost.localdomain> <20160915143202.GA26221@lst.de> CC: , , , From: Jens Axboe Message-ID: Date: Thu, 15 Sep 2016 08:34:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160915143202.GA26221@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR20CA0009.namprd20.prod.outlook.com (10.165.25.22) To BN6PR15MB1186.namprd15.prod.outlook.com (10.172.205.140) X-MS-Office365-Filtering-Correlation-Id: 1f34db99-b64d-446c-02e5-08d3dd75746d X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;2:Nit62lvSuXiZ5cOaN8VDE3Om8QnmLLJB+zLQTpCW6omGWMAd3lU6FnDWYjy9ERA5aGTnfrxz3UCTn3sOSXvwaPJV4datc9wx1xtGR2JPUgqud7SCZ+elwNXofANvm8Zo2217OfwPkzefT9NVKAsiO6J6xcsIVHyd38nPQgSpEiK/w76JMiGy2HVBiZKXWeFT;3:jI8za9b02Z0gPuxSUG5m26G/bj40ab+6fqzr5LozZVhZysF+bf+AgDnOWcd5NRqO8EX4s3/9ArXT6YnhKhcHEiPQGsLG/RbEjMGafBX2XS/V3S1xh0+l6d42q9yG3pnR;25:M/rSzzN9BTlKrBmc85jsnVY0SK3vJpd5trqZAdxgXxHHpviIxG8JwmI2qjY4DRGkmKldRCRokZB8vs2Xu6HDZochuHd3Rv5bh12OEO2/pxx65q+D791uIvkwEsERqXLC+8xx/CTC0QXjn/KorRziSKonJTERoVTyKkJiqNmU6nnIuINXazy5SMefF+utkeDxhgLwcrAQXlo3YWDQWS4Ipje+/CHJL4f3OBplTSqM4TuSClH8vr6+NguZV3UMb8FuoZTExDw3sWFCeXjp/rVjHwPDY3yE4N28kuP1ZXPbrLvvddEdDPCbiZ/W7vXXhTTD9KULrYmDZOzA1G537SbxuoRt+lQfxRFoEg0USGwbQSnQzFfXDUeU9dHp/Cx/C/akItE7cuEhmO8j+C7G3iL3W1OHBwIRHQ3WZIqIDKJK6Xs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;31:Mn1IgY7VooOGjStzgWH9TLqPRvdjRm1K1ZUrikT7MS0SoOOmcI1fW7YOhVGrK+M9xfFqLBoKEYeW+k1+zoxKThzXPgLxyXeETrcsjOcnwZ2zqGBul/g/hnrXyyMzHJxPl5ORy/0b2rMC8ZckqbS2HJuDmNx1KDbfIbA20hX8lJ1kHGlsPuztxmstQ89Fs/76L4V4l0hTZWbX3zFi05O0tcJYhJ33yTA9uX9cVrEireg=;20:Tvs/a/gejj5Z06vXIApidftVa0/xFPFpYhgEAvn9qMqvMc1r5+v5emeqFr+UwtBRHEuuQQ/H4wvD9WNITO/l/uVRH1ENO3WoI4fjleJ9xu5KNO7vZdeCyHL/+RE/rDOwLa8pEYkqw0r36EiGkfbbk6VkdZIYCc5ihQGCy9qNsF4=;4:ckaplLZ1wLZM56YmzCICd0+PgoiRXnGDQ3CA/4i7qL17ODCrq8cIp38ozENox8cCzCaO4agOcJrKi6FpsD42kcuII40G6nLMrHWQ3sp9+koDK5lQ5YYicIdiRGvCgAwEceIpfA130Eo4mXdL8lJ4OC3+hzikeK1bhylgd2+DEQm5fZEW2jppHaAfxxH86dYlumZo9NyL2AoGCrfzH5iN5aO3ya1pZtxI2nJIDqI/6g6B68idXWDlU4/JfSlxGmHncAjtKTpoBNuBT9AgEXNQrgu6Pp6TlL7iI1ubi5oBZdpxpK4qVQYujQIGv0e+DoFRN1G3Ym9Peyf1xPxCduR9HfFgi94C1N+ix31t6hF9+YCWlpOyiqHFgKMclIz5WZc5qrwvjf9FzdSN8gfO1d6G3c9abDcfyQdOwVIChUAixqkhJYNIszfgLOlMdYJpR747 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(84791874153150); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN6PR15MB1186;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Forefront-PRVS: 0066D63CE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(76104003)(69224002)(199003)(24454002)(189002)(377454003)(2950100001)(5660300001)(65956001)(50466002)(81156014)(65806001)(305945005)(64126003)(15975445007)(23746002)(66066001)(65826007)(77096005)(19580395003)(36756003)(5001770100001)(4001350100001)(97736004)(47776003)(189998001)(105586002)(106356001)(7736002)(7846002)(42186005)(50986999)(6116002)(3846002)(586003)(81166006)(4326007)(101416001)(2906002)(8676002)(86362001)(230700001)(83506001)(68736007)(31696002)(92566002)(33646002)(117156001)(54356999)(76176999)(31686004);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1186;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1186;23:Z7ouycNKLP3m5Qa0pw8v0+5ukOr9GaysuLR+7?= =?Windows-1252?Q?v8EpU5zWbkf9W+nlabwM23nvW31mt1Fz+soENeixqtR8l1omu06RXacl?= =?Windows-1252?Q?ygIhVa2r7HdCMuuazTDHNkZeQx7M/+MGZF+Du03+EL9mXA9vGI8aebyJ?= =?Windows-1252?Q?B7ktSJVnuisvYUp9bJPuT9l8ZWTc4ETClSXiRF/yQ/qxYhEdYbOPekk8?= =?Windows-1252?Q?k/WzgTEwnhK9gawFxq22L7BKQPcy19MC9qA/aZlbJzazIACKVh4QwrXe?= =?Windows-1252?Q?F7+LxTM3VN76bjke9ixNM+hfMrSkCVfIPh6Vc6JTrctdTfVv6FQ9r0MJ?= =?Windows-1252?Q?YABCa+x16GV8KkWFV+Cklfe2xaRQ02Vvz5TM+RleWnvbTjMtq8fAUHJe?= =?Windows-1252?Q?IHQlbMKyQ2j2sqdfwOQjTXGR/FCpoYt0Xfv0jYttgDq9pHpqRbhiQgH0?= =?Windows-1252?Q?rYROyz+P8OOczOTxx/bf6bi0asOYdb70MYgcmKwla1In5PS323YMGxTx?= =?Windows-1252?Q?JbCIa2zgYlRHBQylyt1LFTvWM3menz2RLrc9zAONQrRGqWxvIpWPH3ql?= =?Windows-1252?Q?kOWZWEjicgGJcJ7CcnQk8eY0bMYg/RuepdUuVxzE0E2MONATbi4SxVYY?= =?Windows-1252?Q?Z6IutiX3J7lGDZKDyKWP5X1n+/vTvSir0Frx4GV5ZZM3Wxa+42dCQ99l?= =?Windows-1252?Q?ov0YKcmBPW+8haM79skeM7HY+03UjNYYMyYZvuJsWY6fPZxmgsv8USfD?= =?Windows-1252?Q?Mhmbvh3BY6tdPQOYp+e9EdcMw2Z6d1oRvZ3lvGlX2sY2R5T7fqQyR1Sq?= =?Windows-1252?Q?sTZ0KUORPQvmYOpWvWwiqLi7rQGsBuEHQvTniLMJXP6ncMc5Qma4aeED?= =?Windows-1252?Q?8x1p0CRgOSRUhpsiOpZgGnaSP7w+wVpl0hCwCMw/6zrN9QaoCc8Mfcoq?= =?Windows-1252?Q?J439P835i+DKxNOLN9IOiD07/wrTFY5fbdOblHU9hkikETPNPBwMUBgj?= =?Windows-1252?Q?aqXgOoh1ncZ/7ufi4+yktxWAW7Y5WPq/B/5KZdv5VnI3Zjl0Z7eAS51u?= =?Windows-1252?Q?KbVYAUcNpX0OhU9fIOX/xo3LWZnKKBzGHou6PPldMvBpwjwiIXd7djfd?= =?Windows-1252?Q?uz2837bm9JONnD9lWjd0g8UPiZoYlEndj8T1gzu1IGMkAtE75nEqYZDA?= =?Windows-1252?Q?52wUyM53IuTQ/i4RUN5CgUYVckLZSkotA7+v00ey/3UqOuBGjBoPKySK?= =?Windows-1252?Q?NYZA7NrLKwD832AEgmJSqIUh2dh6K4hBAr8S61aJDPp8n7au7F8Zhrut?= =?Windows-1252?Q?Zilm9P7IYs8c7i/8d2WlIG07EZKUutFiz4HOdQHkOwIudirma5+OFQzW?= =?Windows-1252?Q?JwQKH98K5bCERsjmUHc9LP8s03k1V5FkBLn+YnHt1NTVCMRrdt1eaTNK?= =?Windows-1252?Q?ACNk2nT6ztMPHNORbhH0r4kAC6C+q3yE271F57gDKyvD3NKcrBoy0Iga?= =?Windows-1252?Q?8fvu5s=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;6:DPdizRpWpxIM+jlMtPvHhNz7AGq6jygDyCGNeMULKmkufUTKB706u0G30YovvLflgLz6MxnUc2C2HppIcJWDTDMizDP9cxHw5Wtu9PRAPaX3YR050657wyVzNsca4wh9ARBZGptbeOyJKlHHBmZwgKuLb5QYZCr3fSZNglS6jSiT1lcL313evXFyB9OrYlxFTbKikEn3YPRmcRkF8vyuL9oK42u5dHErFYSA45U8AV/NQlWtkjWvUqFyMfS6A8Yda127uZCtPaBh6AaVbr1HRNbY+zQluu2HWp/tQGDE+NA=;5:W8drTtFVR9TV63ZivOqarw828nYldZCo19f7grpQ8mHoR1yQtRv7zAmug2VGWSlkiE5Gfe9hwhqriEgW9tNwlWEdRm9imt3yJFlZEezW9zEjOo5/R3viqxPcnV69lzN6Ew5Pn7ltjODfFZLa6bRRyg==;24:FqkeLV6J+xC1snoeTl89xqIyl0PxtLR3UUYeCBYLUlAKS6N4CbMLfOXtzZsL/z+Hqmf+/1Qf+xb++ovK8MGOit1br3KTB8IPpuzBQGPGcvw=;7:71gePQRBB3yiV6F9FPesgMrpS2+jqBa0VEJDESw+9TJ9DZxRhb8RLniCgb6xjjwMwWa1UaoJHAPoE57cjRrFNP/U/7yEjOvWi8KoJT7qFgyV9GrQI0V9ucFac54qHQRwdtPJ04gCbJku0Kve2QhgVr3hmRisSkti31EwTBi4MIokv6VCkMhU9o1cKX8Bv6t7hWlozpNa0FrRXzT0/j+LKqkXN345xDLthULjyT3H/bkf2z4/ROTQH/NU6zM05NEr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;20:mVSKe59RvNjR8sm8S0sNRe9ugK/CYSxp4ob+d6uWZuXef8foUuZM8OT0JzFy4iRlBUiZnK3zeeZss/HNMgfqUErwK8fQh6UBoF2jdXiaq7MitqdhxVoLEfV5rJZaKF2ITxyQm/li3aDYNGL2XdJuhqxS7JYf23RTnU+23Wn/Hj0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2016 14:34:51.6959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1186 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-15_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2016 08:32 AM, Christoph Hellwig wrote: > Thanks for all the testing and the review Keith, as well as the > fixes earlier. > > Jens, what do you think of the series? > > Thomas has added the first 5 patches to > > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=irq/for-block > > so it would be great if we could pull that into a block branch and > get the rest into the block tree sooner or later. I was going to ask about splitting it, but that looks fine, I can pull that in. The series looks fine to me. My only real concern is giving drivers the flexibility to define mappings, I don't want that to evolve into drivers (again) doing stupid things wrt mappings. As long as we keep it strictly as a tunnel for passing mappings defined by the (previous blk-mq) core code, then that's fine. -- Jens Axboe