From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753593AbdF1Adv (ORCPT ); Tue, 27 Jun 2017 20:33:51 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9241 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbdF1Ado (ORCPT ); Tue, 27 Jun 2017 20:33:44 -0400 Subject: Re: [PATCH NET V6 1/2] net: phy: Add phy loopback support in net phy framework To: Madalin-cristian Bucur , "davem@davemloft.net" , "andrew@lunn.ch" , "f.fainelli@gmail.com" CC: "huangdaode@hisilicon.com" , "xuwei5@hisilicon.com" , "liguozhu@hisilicon.com" , "Yisen.Zhuang@huawei.com" , "gabriele.paoloni@huawei.com" , "john.garry@huawei.com" , "linuxarm@huawei.com" , "salil.mehta@huawei.com" , "lipeng321@huawei.com" , "tremyfr@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1498561245-93997-1-git-send-email-linyunsheng@huawei.com> <1498561245-93997-2-git-send-email-linyunsheng@huawei.com> From: Yunsheng Lin Message-ID: Date: Wed, 28 Jun 2017 08:33:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.190.125] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.5952F953.004A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 95740522bf2168a77bbecc5ce10935d8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Madalin On 2017/6/27 19:48, Madalin-cristian Bucur wrote: >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] >> On Behalf Of Lin Yun Sheng >> Sent: Tuesday, June 27, 2017 2:01 PM >> To: davem@davemloft.net; andrew@lunn.ch; f.fainelli@gmail.com >> Cc: huangdaode@hisilicon.com; xuwei5@hisilicon.com; >> liguozhu@hisilicon.com; Yisen.Zhuang@huawei.com; >> gabriele.paoloni@huawei.com; john.garry@huawei.com; linuxarm@huawei.com; >> yisen.zhuang@huawei.com; salil.mehta@huawei.com; lipeng321@huawei.com; >> tremyfr@gmail.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: [PATCH NET V6 1/2] net: phy: Add phy loopback support in net phy >> framework >> >> This patch add set_loopback in phy_driver, which is used by Mac >> driver to enable or disable a phy. it also add a generic >> genphy_loopback function, which use BMCR loopback bit to enable >> or disable a phy. > > "disable a phy" or disable the PHY loopback function? It should be disable the PHY loopback function, thanks for pointing out. > >> @@ -1123,6 +1123,39 @@ int phy_resume(struct phy_device *phydev) >> } >> EXPORT_SYMBOL(phy_resume); >> >> +int phy_loopback(struct phy_device *phydev, bool enable) >> +{ >> + struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); >> + int ret = 0; >> + >> + mutex_lock(&phydev->lock); >> + >> + if (enable && phydev->loopback_enabled) { >> + ret = -EBUSY; >> + goto out; >> + } >> + >> + if (!enable && !phydev->loopback_enabled) { >> + ret = -EINVAL; >> + goto out; >> + } >> + > > if (enable == phydev->loopback_enabled) One if statement don't work here, it returns different error code. > >> + if (phydev->drv && phydrv->set_loopback) >> + ret = phydrv->set_loopback(phydev, enable); >> + else >> + ret = -EOPNOTSUPP; >> + >> + if (ret) >> + goto out; >> + >> + phydev->loopback_enabled = enable; >> + >> +out: >> + mutex_unlock(&phydev->lock); >> + return ret; >> +} >> +EXPORT_SYMBOL(phy_loopback); >> + > Best Regards Yunsheng