From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: "Arnd Bergmann" <arnd@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Leon Huang" <Leon.Huang1@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Qingqing Zhuo <qingqing.zhuo@amd.com>,
Wenjing Liu <wenjing.liu@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/amd/display: remove unused variables in dcn21_set_backlight_level
Date: Thu, 20 Apr 2023 10:21:27 -0400 [thread overview]
Message-ID: <de66ba4f-52b3-6507-3194-60b894d840c4@amd.com> (raw)
In-Reply-To: <20230420084711.3063453-3-arnd@kernel.org>
On 4/20/23 04:47, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The only references to these variables were removed, so they now cause
> warnings and have to be removed as well:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:226:20: error: unused variable 'cmd' [-Werror,-Wunused-variable]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:229:11: error: unused variable 'otg_inst' [-Werror,-Wunused-variable]
>
> Fixes: 6f0ef80a00ad ("drm/amd/display: Fix ABM pipe/backlight issues when change backlight")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This has already been fixed, as of commit 1adb4dd5bd4b
("drm/amd/display: Remove unused variables in dcn21_hwseq.c") in
amd-staging-drm-next.
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> index 55a464a39529..43463d08f21b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> @@ -223,10 +223,8 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
> uint32_t backlight_pwm_u16_16,
> uint32_t frame_ramp)
> {
> - union dmub_rb_cmd cmd;
> struct dc_context *dc = pipe_ctx->stream->ctx;
> struct abm *abm = pipe_ctx->stream_res.abm;
> - uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
> struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
>
> if (dc->dc->res_pool->dmcu) {
--
Hamza
prev parent reply other threads:[~2023-04-20 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:47 [PATCH 1/3] drm/amdgpu: mark gfx_v9_4_3_disable_gpa_mode() static Arnd Bergmann
2023-04-20 8:47 ` [PATCH 2/3] drm/amd/display: dumb_abm_lcd: avoid missing-prototype warnings Arnd Bergmann
2023-04-20 14:29 ` Hamza Mahfooz
2023-04-20 8:47 ` [PATCH 3/3] drm/amd/display: remove unused variables in dcn21_set_backlight_level Arnd Bergmann
2023-04-20 14:21 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de66ba4f-52b3-6507-3194-60b894d840c4@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=Leon.Huang1@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qingqing.zhuo@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®