From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92C2C282C3 for ; Thu, 24 Jan 2019 18:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B889D2184C for ; Thu, 24 Jan 2019 18:21:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VVUaoGeM"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="iZD/Fa20" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbfAXSVl (ORCPT ); Thu, 24 Jan 2019 13:21:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33064 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfAXSVk (ORCPT ); Thu, 24 Jan 2019 13:21:40 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 527F6606FC; Thu, 24 Jan 2019 18:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548354099; bh=b5YLJe50/fmev2XJ1PYLgvvqRlTFqRtx/AOY0iQvDbs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VVUaoGeMRWLN4VcHM/E4dp3SSMFQKFqOXpa4SHkwSuB/3wMXwh5mYUMtZyS1ynFCo 0GrIDmicV2pLFXlGr7nKl7UQtduqZaZcE5FmHzZkQBLoQ3D6LCTP+m4GMtJ2xy+uGo GsqMhIMzSLho5j14gNt6+lYozxAL4e29TbPpZHwY= Received: from [192.168.1.101] (unknown [157.45.230.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 76910606FC; Thu, 24 Jan 2019 18:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548354098; bh=b5YLJe50/fmev2XJ1PYLgvvqRlTFqRtx/AOY0iQvDbs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iZD/Fa20u5cFzhQqLWM4kzgBZZJUjLVpF/wDhVwzU2dZ+/DaCbqDc22EpQGk9mk+f 54Jeihfc1aAJx/4Lx3NfquYR7oHAFac21R2yKzTT9lTBaWKf+saqX2A5X+bS14wxHC 4TxxUk2o0y0mHol92fM8K1M+mpmti5ivmQ70D/Kc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 76910606FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support To: Suzuki K Poulose , robh+dt@kernel.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, andy.gross@linaro.org, david.brown@linaro.org, vivek.gautam@codeaurora.org, dianders@chromium.org, sboyd@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, mark.rutland@arm.com Cc: rnayak@codeaurora.org, sibis@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, John.Horley@arm.com References: <1bd39862-0725-70ce-6535-fdb59569f683@arm.com> <75ed74af-6946-b86d-092e-42dc16e55308@codeaurora.org> <91a90daa-9e14-2d2e-e633-2ddfdc0955bf@arm.com> <3906faf1-abbd-9c28-ad55-ed3800f06352@codeaurora.org> <5b54c6e0-7d22-ecee-486f-31333f49f84a@codeaurora.org> <18b70426-60fe-4871-6388-6e09fd5feb37@arm.com> From: Sai Prakash Ranjan Message-ID: Date: Thu, 24 Jan 2019 23:51:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <18b70426-60fe-4871-6388-6e09fd5feb37@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, On 1/24/2019 4:49 PM, Suzuki K Poulose wrote: > Hi Sai, > > > That looks fine with me. But as Mathieu said, this needs to be a separate > patch. But before all that please could you provide me the PIDR4 value for > the Kryo A75 and A55 please ? > Sure. PIDR4 value is 0x4. I get it now. So we are looking for JEP106 identification(PIDR1[7:4] and PIDR2[2:0]) and continuation code(PIDR4[3:0]). From ARM Coresight Spec: DES_0, PIDR1 bits[7:4] JEP106 identification code bits[3:0]. DES_1, PIDR2 bits[2:0] JEP106 identification code bits[6:4]. DES_2, PIDR4 bits[3:0] JEP106 continuation code. For SDM845(A75 based): *0xB_B8_03* does indicate that the JEP106 identification code is 0x3B and continuation code is 0x4 which is of ARM and not QCOM(JEP106 ID is 0x70) which is expected. And the other values of PIDR0[0:7] and PIDR1[3:0] are *Implementation defined part numbers* and can be different from ARM A75/A55. I think this clears up case for SDM845. As for MSM8996, it is not based on any ARM derivative and hence the JEP106 ID is of QCOM(0x70) from the value of pid = *0xF_02_11* based on PIDR1[7:4] and PIDR2[2:0]. This clears this as well. Please correct me if I am wrong and also let me know if I can continue with PID addition to table. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation