From: Bart Van Assche <bvanassche@acm.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Thu, 9 Dec 2021 16:02:07 -0800 [thread overview]
Message-ID: <de725f08-2f98-56fc-8305-baf93f867af3@acm.org> (raw)
In-Reply-To: <YbKT/lcp6iZ+lD4n@sol.localdomain>
On 12/9/21 3:40 PM, Eric Biggers wrote:
> On Thu, Dec 09, 2021 at 02:51:59PM -0800, Bart Van Assche wrote:
>> Has it been considered to report each value separately, e.g. 512\n4096\n
>> instead of 0x1200\n? I think the former approach is more friendly for shell
>> scripts.
>
> I don't think that would be acceptable to the sysfs folks, as they only allow
> one value per file. I suppose a bitmask could be viewed as unacceptable too,
> but it seemed to make sense here, given that the data unit sizes are always
> powers of 2, and the hardware reports them as bitmasks.
In case Greg wouldn't have the time to reply, I think the following quote from
Documentation/filesystems/sysfs.txt is relevant in this context: "Attributes
should be ASCII text files, preferably with only one value per file. It is
noted that it may not be efficient to contain only one value per file, so it is
socially acceptable to express an array of values of the same type."
Thanks,
Bart.
next prev parent reply other threads:[~2021-12-10 0:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:35 [PATCH v3 0/3] block: " Eric Biggers
2021-12-08 1:35 ` [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-12-09 19:00 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-12-09 22:38 ` Bart Van Assche
2021-12-09 23:17 ` Eric Biggers
2021-12-09 23:26 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-12-09 22:51 ` Bart Van Assche
2021-12-09 23:40 ` Eric Biggers
2021-12-10 0:02 ` Bart Van Assche [this message]
2021-12-10 0:12 ` Eric Biggers
2021-12-10 6:42 ` Greg Kroah-Hartman
2021-12-10 17:29 ` Bart Van Assche
2021-12-10 17:45 ` Eric Biggers
2021-12-11 10:50 ` Greg Kroah-Hartman
2021-12-14 5:04 ` Bart Van Assche
2021-12-14 7:23 ` Chaitanya Kulkarni
2021-12-14 7:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de725f08-2f98-56fc-8305-baf93f867af3@acm.org \
--to=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®