mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ti: remove sound support for DaVinci DM644x and DM646x
Date: Wed, 20 Jul 2022 21:36:18 +0300	[thread overview]
Message-ID: <de72dd7f-639b-1733-a38b-a0ed9346f3d9@gmail.com> (raw)
In-Reply-To: <20220720112152.22918-1-lukas.bulwahn@gmail.com>

Hi Lukas,

On 20/07/2022 14:21, Lukas Bulwahn wrote:
> Commit 7dd33764486d ("ARM: davinci: Delete DM644x board files") and commit
> b4aed01de486 ("ARM: davinci: Delete DM646x board files") removes the
> support for DaVinci DM644x and DM646x boards.
> 
> Hence, remove the sound support for those boards as well.

This is not going to remove the sound support, it is just removes the
select, which is now rendered NOP as neither MACH_DAVINCI_EVM nor
MACH_DAVINCI_DM6467_EVM is an option to select...

There is still structs and some code in davinci-evm.c in the path of
if (machine_is_davinci_evm())
and
else if (machine_is_davinci_dm6467_evm())

Those can also go, but I can only  drop that in about two weeks from now...

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  sound/soc/ti/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
> index 40110e9a9e8a..35fddd7c501a 100644
> --- a/sound/soc/ti/Kconfig
> +++ b/sound/soc/ti/Kconfig
> @@ -180,9 +180,6 @@ config SND_SOC_DAVINCI_EVM
>  	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_DM355_EVM
>  	select SND_SOC_DAVINCI_ASP if SND_SOC_DM365_AIC3X_CODEC
>  	select SND_SOC_DAVINCI_VCIF if SND_SOC_DM365_VOICE_CODEC
> -	select SND_SOC_DAVINCI_ASP if MACH_DAVINCI_EVM # DM6446
> -	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DM6467_EVM
> -	select SND_SOC_SPDIF if MACH_DAVINCI_DM6467_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA830_EVM
>  	select SND_SOC_DAVINCI_MCASP if MACH_DAVINCI_DA850_EVM
>  	select SND_SOC_TLV320AIC3X
> @@ -191,8 +188,6 @@ config SND_SOC_DAVINCI_EVM
>  	  DaVinci EVM platforms:
>  	  - DM355
>  	  - DM365
> -	  - DM6446
> -	  - DM6447
>  	  - DM830
>  	  - DM850
>  

-- 
Péter

  reply	other threads:[~2022-07-20 18:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 11:21 Lukas Bulwahn
2022-07-20 18:36 ` Péter Ujfalusi [this message]
2022-07-26  7:43 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de72dd7f-639b-1733-a38b-a0ed9346f3d9@gmail.com \
    --to=peter.ujfalusi@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®