mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 37/39] net/mac80211: Update WARN uses
Date: Sat, 30 Oct 2010 14:08:54 -0700	[thread overview]
Message-ID: <de75963e04701e309b86dfee54c36e11873048c2.1288471898.git.joe@perches.com> (raw)
In-Reply-To: <cover.1288471897.git.joe@perches.com>

Coalesce long formats.
Add missing newlines.

Signed-off-by: Joe Perches <joe@perches.com>
---
 net/mac80211/agg-tx.c |    5 +++--
 net/mac80211/iface.c  |    4 ++--
 net/mac80211/mlme.c   |    2 +-
 net/mac80211/rx.c     |    4 +---
 net/mac80211/tx.c     |    4 +---
 net/mac80211/util.c   |    4 +---
 net/mac80211/work.c   |    4 ++--
 7 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index d4679b2..9f2c3f6 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -454,8 +454,9 @@ ieee80211_agg_splice_packets(struct ieee80211_local *local,
 
 	ieee80211_stop_queue_agg(local, tid);
 
-	if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates"
-			  " from the pending queue\n", tid))
+	if (WARN(!tid_tx,
+		 "TID %d gone but expected when splicing aggregates from the pending queue\n",
+		 tid))
 		return;
 
 	if (!skb_queue_empty(&tid_tx->pending)) {
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index f9163b1..328e637 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -820,7 +820,7 @@ static void ieee80211_iface_work(struct work_struct *work)
 			ieee80211_mesh_rx_queued_mgmt(sdata, skb);
 			break;
 		default:
-			WARN(1, "frame for unexpected interface type");
+			WARN(1, "frame for unexpected interface type\n");
 			break;
 		}
 
@@ -979,7 +979,7 @@ static int ieee80211_runtime_change_iftype(struct ieee80211_sub_if_data *sdata,
 	ieee80211_setup_sdata(sdata, type);
 
 	err = ieee80211_do_open(sdata->dev, false);
-	WARN(err, "type change: do_open returned %d", err);
+	WARN(err, "type change: do_open returned %d\n", err);
 
 	return ret;
 }
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index a3a9421..22f054a 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -1780,7 +1780,7 @@ void ieee80211_sta_rx_queued_mgmt(struct ieee80211_sub_if_data *sdata,
 			cfg80211_send_disassoc(sdata->dev, (u8 *)mgmt, skb->len);
 			break;
 		default:
-			WARN(1, "unexpected: %d", rma);
+			WARN(1, "unexpected: %d\n", rma);
 		}
 		return;
 	}
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 902b03e..7775375 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -2840,9 +2840,7 @@ void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb)
 			 */
 			if (WARN((status->rate_idx < 0 ||
 				 status->rate_idx > 76),
-				 "Rate marked as an HT rate but passed "
-				 "status->rate_idx is not "
-				 "an MCS index [0-76]: %d (0x%02x)\n",
+				 "Rate marked as an HT rate but passed status->rate_idx is not an MCS index [0-76]: %d (0x%02x)\n",
 				 status->rate_idx,
 				 status->rate_idx))
 				goto drop;
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 96c5943..a511d69 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -649,9 +649,7 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
 	if (WARN(test_bit(SCAN_SW_SCANNING, &tx->local->scanning) &&
 		 (sta_flags & WLAN_STA_ASSOC) &&
 		 !rate_usable_index_exists(sband, &tx->sta->sta),
-		 "%s: Dropped data frame as no usable bitrate found while "
-		 "scanning and associated. Target station: "
-		 "%pM on %d GHz band\n",
+		 "%s: Dropped data frame as no usable bitrate found while scanning and associated. Target station: %pM on %d GHz band\n",
 		 tx->sdata->name, hdr->addr1,
 		 tx->channel->band ? 5 : 2))
 		return TX_DROP;
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 0b6fc92..2a14723 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -1120,9 +1120,7 @@ int ieee80211_reconfig(struct ieee80211_local *local)
 		 */
 		res = drv_start(local);
 		if (res) {
-			WARN(local->suspended, "Hardware became unavailable "
-			     "upon resume. This could be a software issue "
-			     "prior to suspend or a hardware issue.\n");
+			WARN(local->suspended, "Hardware became unavailable upon resume. This could be a software issue prior to suspend or a hardware issue.\n");
 			return res;
 		}
 
diff --git a/net/mac80211/work.c b/net/mac80211/work.c
index ae344d1..8583206 100644
--- a/net/mac80211/work.c
+++ b/net/mac80211/work.c
@@ -830,7 +830,7 @@ static void ieee80211_work_rx_queued_mgmt(struct ieee80211_local *local,
 		list_del_rcu(&wk->list);
 		break;
 	default:
-		WARN(1, "unexpected: %d", rma);
+		WARN(1, "unexpected: %d\n", rma);
 	}
 
 	mutex_unlock(&local->mtx);
@@ -973,7 +973,7 @@ static void ieee80211_work_work(struct work_struct *work)
 			list_add(&wk->list, &free_work);
 			break;
 		default:
-			WARN(1, "unexpected: %d", rma);
+			WARN(1, "unexpected: %d\n", rma);
 		}
 	}
 
-- 
1.7.3.1.g432b3.dirty


  parent reply	other threads:[~2010-10-30 21:10 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 21:08 [PATCH 00/39] Cleanup WARN #defines Joe Perches
2010-10-30 21:08 ` [PATCH 01/39] include/asm-generic/bug.h: Update WARN macros Joe Perches
2010-10-30 21:08 ` [PATCH 02/39] arch/alpha: Update WARN uses Joe Perches
2010-10-30 21:17   ` Matt Turner
2010-10-30 21:28     ` Joe Perches
2010-10-31  1:11       ` Michael Cree
2010-10-31  1:38         ` Joe Perches
2010-10-30 21:08 ` [PATCH 03/39] arch/arm: " Joe Perches
2010-10-30 21:08 ` [PATCH 04/39] arch/powerpc: " Joe Perches
2010-11-01 11:02   ` Michael Ellerman
2010-11-01 14:41     ` Joe Perches
2010-11-02  0:26       ` Michael Ellerman
2010-11-02  1:50         ` Joe Perches
2010-11-02  3:20           ` Michael Ellerman
2010-10-30 21:08 ` [PATCH 05/39] arch/x86: " Joe Perches
2010-10-31  1:38   ` Rafael J. Wysocki
2010-10-30 21:08 ` [PATCH 06/39] drivers/acpi: " Joe Perches
2010-10-30 21:08 ` [PATCH 07/39] drivers/base: " Joe Perches
2010-10-30 21:08 ` [PATCH 08/39] drivers/block: " Joe Perches
2010-10-30 21:08 ` [PATCH 09/39] drivers/cpuidle: " Joe Perches
2010-10-30 21:08 ` [PATCH 10/39] drivers/firewire: " Joe Perches
2010-10-30 21:57   ` Stefan Richter
2010-10-30 21:08 ` [PATCH 11/39] drivers/firmware: " Joe Perches
2010-10-30 21:08 ` [PATCH 12/39] drivers/gpio: " Joe Perches
2010-10-30 21:08 ` [PATCH 13/39] drivers/gpu/drm: " Joe Perches
2010-10-30 21:08 ` [PATCH 14/39] drivers/media/video: " Joe Perches
2010-10-30 21:08 ` [PATCH 15/39] drivers/mfd: " Joe Perches
2010-11-26 10:02   ` Samuel Ortiz
2010-10-30 21:08 ` [PATCH 16/39] drivers/net/can: " Joe Perches
2010-11-09 17:23   ` David Miller
2010-10-30 21:08 ` [PATCH 17/39] drivers/net/usb: " Joe Perches
2010-11-09 17:23   ` David Miller
2010-10-30 21:08 ` [PATCH 18/39] drivers/net/wireless/iwlwifi: " Joe Perches
2010-10-30 21:08 ` [PATCH 19/39] drivers/regulator: " Joe Perches
2010-11-01 13:25   ` Mark Brown
2010-10-30 21:08 ` [PATCH 20/39] drivers/scsi/fcoe: " Joe Perches
2010-10-30 21:08 ` [PATCH 21/39] drivers/staging: " Joe Perches
2010-11-09 23:50   ` Greg KH
2010-10-30 21:08 ` [PATCH 22/39] drivers/usb/musb: " Joe Perches
2010-11-05 11:44   ` Felipe Balbi
2010-11-05 13:54     ` Jiri Kosina
2010-11-05 13:56       ` Felipe Balbi
2010-10-30 21:08 ` [PATCH 23/39] drivers/video/omap2/dss: " Joe Perches
2010-10-30 21:08 ` [PATCH 24/39] fs/nfsd: " Joe Perches
2010-10-30 21:08 ` [PATCH 25/39] fs/notify/inotify: " Joe Perches
2010-10-30 21:08 ` [PATCH 26/39] fs/sysfs: " Joe Perches
2010-10-30 21:08 ` [PATCH 27/39] fs/proc: " Joe Perches
2010-10-30 21:08 ` [PATCH 28/39] fs: " Joe Perches
2010-10-30 21:08 ` [PATCH 29/39] include/linux/device.h: " Joe Perches
2010-10-30 21:08 ` [PATCH 30/39] kernel/irq: " Joe Perches
2010-10-30 21:08 ` [PATCH 31/39] kernel/panic.c: Update warn_slowpath to use %pV Joe Perches
2010-10-30 21:08 ` [PATCH 32/39] kernel: Update WARN uses Joe Perches
2010-10-30 21:08 ` [PATCH 33/39] lib: " Joe Perches
2010-10-30 21:08 ` [PATCH 34/39] mm: " Joe Perches
2010-11-08 12:03   ` Michał Nazarewicz
2010-10-30 21:08 ` [PATCH 35/39] net/core/dev.c: " Joe Perches
2010-11-09 17:23   ` David Miller
2010-10-30 21:08 ` [PATCH 36/39] net/ipv4/tcp.c: " Joe Perches
2010-11-09 17:23   ` David Miller
2010-10-30 21:08 ` Joe Perches [this message]
2010-10-31  7:33   ` [PATCH 37/39] net/mac80211: " Johannes Berg
2010-10-30 21:08 ` [PATCH 38/39] net/rfkill/input.c: " Joe Perches
2010-10-30 21:08 ` [PATCH 39/39] sound/soc/codecs/wm_hubs.c: " Joe Perches
2010-11-01 19:47   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de75963e04701e309b86dfee54c36e11873048c2.1288471898.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®