Re: [PATCH] nvme-keyring: add MODULE_LICENSE()

[Hannes Reinecke <hare@suse.de>]

On 10/24/23 01:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
> 
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
> 
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: linux-nvme@lists.infradead.org
> ---
>   drivers/nvme/common/keyring.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
>   	key_put(nvme_keyring);
>   }
>   EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman