From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0FBC4363C for ; Sat, 3 Oct 2020 03:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EC1E206E3 for ; Sat, 3 Oct 2020 03:27:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VcshOLvw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725896AbgJCD15 (ORCPT ); Fri, 2 Oct 2020 23:27:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgJCD15 (ORCPT ); Fri, 2 Oct 2020 23:27:57 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B59CC0613D0 for ; Fri, 2 Oct 2020 20:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=QQSZoOnloLMD7/ZhvOjy+/MmtuG47S2C6q8QYmBfaLg=; b=VcshOLvwQUeuRpKaTWGm+Y8U+2 GRyNs41czvUF8AZ+KMGn6OYdMKpAkL4xDTfHCc5jZd1CuaGmGbOdFIg9mRr4tW8Tiwvpab8i4oeRF WIAZphlvKmRzjuWSvAvl7BB5Bz2JKcJsWT/j/hojTdMro6nEHkgMgvJQIUXIXRV7rKTdLTRNvTAZH cuxUqeAV7TTvCfNZp3XCzoRgtSTfCzrevvewoIMbGerSRSV6m/pKRYyTmW/eGryGPa52L7eWUOgFn OOLN+9peMY/pWJEn6gLx3C1TYQo/vBRdNGBF8DSa8A6m3UcspAJVbfnWBOuS+jwMd/l3cVhhO4SxD nfhT8bQg==; Received: from [2601:1c0:6280:3f0::2c9a] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOYD7-000129-6I; Sat, 03 Oct 2020 03:27:49 +0000 Subject: Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface To: Ricardo Neri , Greg Kroah-Hartman , x86@kernel.org, Borislav Petkov , Ingo Molnar , Thomas Gleixner , "Rafael J. Wysocki" Cc: Tony Luck , Len Brown , "Ravi V. Shankar" , linux-kernel@vger.kernel.org, Andi Kleen , Dave Hansen , "Gautham R. Shenoy" , Kan Liang , Srinivas Pandruvada References: <20201003011745.7768-1-ricardo.neri-calderon@linux.intel.com> <20201003011745.7768-2-ricardo.neri-calderon@linux.intel.com> From: Randy Dunlap Message-ID: Date: Fri, 2 Oct 2020 20:27:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201003011745.7768-2-ricardo.neri-calderon@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/20 6:17 PM, Ricardo Neri wrote: > +/** > + * arch_get_cpu_type() - Get the CPU type number > + * @cpu: Index of the CPU of which the index is needed > + * > + * Get the CPU type number of @cpu, a non-zero unsigned 32-bit number that Are you sure that @cpu is non-zero? > + * uniquely identifies a type of CPU micro-architecture. All CPUs of the same > + * type have the same type number. Type numbers are defined by each CPU > + * architecture. > + */ > +u32 __weak arch_get_cpu_type(int cpu) > +{ > + return 0; > +} arch_get_cpu_type() in patch 4/4 allows @cpu to be 0. -- ~Randy