From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0453C942A for ; Thu, 23 Apr 2026 03:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776914084; cv=none; b=Qd5qYrmk0wxIqSlybxc9PXbbpMrlZ511SvH8xyAhD2ecByo/rkSkUxBBnidkfJPn+VN9x7vxtSWsNLJBWp6IOw8/FOAmov3MNLrQzzIPBbA6HeJEP5s+UiLQb/9lxbNtQyDOmmxnDarQ77Gjh2cLCWPT1Px+EWJWvPimncBssM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776914084; c=relaxed/simple; bh=3twAVeIRu09Yes+lRweJXWGJoomxGY8WmxUkaciImJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y/Mg7eR5UGM0QccsRToHgXVjuq1J6HjbSiSow1zMUDZK96dIvnNXSegekCf6FRWWlun7oZ0NGqVq40o155eTANy1Dac3AQE+hqRltlkB/SPYy2pZKDMHFOIIy5f+bc6By4e4Zg9XfqdAvNUJAlnTV47JBSAQkG7jzJv9QZSCGhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FB1Ln6AP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bTAXqqTr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FB1Ln6AP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bTAXqqTr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N2uJEv2956103 for ; Thu, 23 Apr 2026 03:14:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QQXoZzH2+O8sR7z+rdLtaGC4M3a6RTUnICpFU0MK+yo=; b=FB1Ln6APT2F/WLQJ rR9FoC0vumAGkSwy77awWj4QW91/xzkwLL6cWLA5F6Y2+HKVw756w/uZCoAzu7GK iuv4zbvZfQ33DtfYFvJNSMK6LK+vz7x6k5xkIOqRAToaTsL+PTmDoB4W9BF7ASsn darEcAW6dLGIHxoGqUqrSB/bhtWmGETb1DUZpMfmSyzVOlycB0Ew9Urqc2uvzy8N T+HCXCO1wNb5OoVeDXSK2cUIr8nwSoBrkjSEf7hIEaOa3hd7/+heJbZZUEtZwxZM DyAOvGvSFgsDfh4UlRVB6D+u8Ol8e4dDVknlaNqIx4j67WLYgrcJxCH+fxpgSw3Z CVXh7Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16q20eg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 03:14:41 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b7867bb92dso51674615ad.3 for ; Wed, 22 Apr 2026 20:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776914080; x=1777518880; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QQXoZzH2+O8sR7z+rdLtaGC4M3a6RTUnICpFU0MK+yo=; b=bTAXqqTrUEUXXQcURlpWaIGNaZ+JXqbwUUleQTMmkKC96k7QdCpvaGk5C5RMp/uGUG BcPSf3Qa27ybUD/lALDEfVFOd7KSGhCT+qjrDTYP/bWr7mgW56cK2thU7UGB+fK3JjXZ b5B0FSmTwbyUt2K+RWXqcMHpMZWmup+3O5lRX7EmcsZS/Tid5dKewdkrhnmEKtSuZv5I J8MSRjhWB/ZotJzPiEsJ9Yfpkae2UX7b6Cjx8/T7Z4apHWT9S8KcpwnDlEwj6P9v2Ivd FsFqT2QiJRWVqmyylxbnSQmGniR75AsCIPV6FAnpGFaJdxj4o0EWGC1iz5YyKRVlsxTO qXOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776914080; x=1777518880; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QQXoZzH2+O8sR7z+rdLtaGC4M3a6RTUnICpFU0MK+yo=; b=sKv+7u2LmuRqs4tewVQnvqrgy50GxhPDKPMXb937cUQwIDB5xJus72D4GdvAxB2Qg8 FpTYre/3eA2Vm2WklSuqALm+Ef6fvt1XFWUAbOUSh8EWOV32N1kPJjRvbVRwMq8akSw/ mjXT9vGMFbF5L1oXY7wofkZiKMxJ1b6ST7xZS2JEUJSA6OrqAe/ut1HUPDvAn2C9TiuR t76H/qGvo9oFZXKKrXj3LG401TUDKUc/Y3nqwKqLPjZP9wCz0N4hSjxfF3Sht6ntfZK3 RQBE3JJwMTfOv+uit/LCFvXL/psLtrPmNv7VAGs9Uvsr5tReWj+3nsHilE37vhF+/Tz8 rhAg== X-Forwarded-Encrypted: i=1; AFNElJ/7iUH824aFN3ci8oRtaIds5FNfVTb4t9FKea82pARHCaEeK14Cj6t/v2hb738G8ndnTQP/bzUQaiKwJKE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0uDHSTIHl1ifuPyTDerLXeCCe3Gj5kjiu64k6yWVBBMXJbe0W NCrFJZId1Ecm4WKtjfmzv8ze54DczTxg8Xl+NyL52CXiqgfg6LHIz4pb3d/BaJv+B9AghMda2QZ v56cjZuu12U3EzQBs3TBxytEp3PwZaXhWp5Wd5kp5cAtu4Jx3+8EyWco5MB2Qrwd/VAA= X-Gm-Gg: AeBDiev62spej74LPVPNVBEN33CJ0fJrwzRHi2nyy/uYteYqYD+nOKM2z2GCNm2G936 8B/BPe+GvTdmS+46p+7QKcYzVZpywhnHfMwppGePmDuMlo0/Uj2mWeBUizyKqCBkJ6h/45fBTV1 ornwnPG3Ntmo0+6zwNO9lO/a1QhmacPwqhOOoZU0lIPBpX+9GmGB3d/i9bcnwLwy5Oo87oG3cXp GNOhLGAL7Kgu5R77Y4omBI84NpFMpVrLBBaD1HQ4PofspoXYlF/8gISCxikx2GjpY+TGcrNLkw2 npxRaaOSoF/uBbA1vOgavYwPWF4U/0d2B5eVfL34/NMinBdP7UIwzsVaKXQHxT9xdY3kEnVTubC LHs04BgyqrCX9ymBVLZvE3oU8WQfv6RMU0x18w8KBCd6lyebbTKO17vo/i1fk6mKF+93TsWaM9Q m7aFgo4y82seDtL0pi1MWPk5oxvMQr X-Received: by 2002:a17:902:e746:b0:2b0:5a4c:7263 with SMTP id d9443c01a7336-2b5f9ef646amr297764985ad.18.1776914080487; Wed, 22 Apr 2026 20:14:40 -0700 (PDT) X-Received: by 2002:a17:902:e746:b0:2b0:5a4c:7263 with SMTP id d9443c01a7336-2b5f9ef646amr297764635ad.18.1776914079967; Wed, 22 Apr 2026 20:14:39 -0700 (PDT) Received: from [10.133.33.123] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa3073asm170173705ad.27.2026.04.22.20.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 20:14:39 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 11:14:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] phy: qcom: edp: Add eDP/DP mode switch support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio References: <20260422-edp_phy-v4-0-c38bef2d027b@oss.qualcomm.com> <20260422-edp_phy-v4-2-c38bef2d027b@oss.qualcomm.com> <2cyvdtnnmrfz4zffhikfxl2goyby73gybgm3ih52rfpyvbhnzk@37x3g26o2t33> Content-Language: en-US From: Yongxing Mou In-Reply-To: <2cyvdtnnmrfz4zffhikfxl2goyby73gybgm3ih52rfpyvbhnzk@37x3g26o2t33> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KPNqylFo c=1 sm=1 tr=0 ts=69e98ea1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=GN78Z6GrLXGed5ov1boA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: _vcWnMvCUibcEB0XlDFQieIJQDx60IZg X-Proofpoint-ORIG-GUID: _vcWnMvCUibcEB0XlDFQieIJQDx60IZg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDAyOCBTYWx0ZWRfX878eeG4UzHwc iPxp1r3V/f+gV48X4C3wcc3sFUM1NS6OCUzPRJM8O21scxTJ4tuYv7YJi9s1qc6HXk4rihpJez1 ULOGufams+9vAIeRu09/wrjKAQw3oWo2hlvSOyFY/cs/6wxH4wSr12MdCd6/quiJLU95n24zGKe SWLpt3QpNaB4pVzFqzuri4D4oCNPorwlnOrPABbAEH8Oh5drfYCNqVz4k2xuBXBrZaNWxNJyxM3 0guKJpV0eh0H/EJDlpAJjEQ7qd9OqQ6RWmc+LyXH3bCRcGmSQQtgFOZaqCUe0ftR9ckA9MgBoV7 0LD/VXVr5zNidNqQ2TZ6GEScQyBDoNZXl2hfvh5Vg6EFj3pRXKv/FUZHaQsiy9v/aP3icTEt1n7 m22CH+/UYdIK188UEYWZgVjXEIO37zQUHpRQDXsPIlZm23rW4Xn5WRHeKI4lRla4x1SGwuWmi6Q D1Sey1Zij0D25XLFJZg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230028 On 4/23/2026 12:14 AM, Dmitry Baryshkov wrote: > On Wed, Apr 22, 2026 at 02:01:52PM +0800, Yongxing Mou wrote: >> The eDP PHY supports both eDP/DP modes, each requires a different table. >> The current driver doesn't support both modes and use either the eDP or >> DP table when enable the platform. > > This is not quite true. The driver supports both modes, but it uses a > fixed static table for eDP programming. > > Other than the commit message, LGTM. > Will modify next patch. > >> Add a separate set of tables for eDP >> and DP modes, and select the appropriate table based on the current mode. >> >> Glymur's DP mode table differs from the other platforms, add a dedicated >> table for it. >> >> Since both modes are supported, so also fixes the table mismatch for >> X1E80100(eDP) and SA8775P(DP). >> >> Cc: stable@vger.kernel.org >> Fixes: 3f12bf16213c ("phy: qcom: edp: Add support for eDP PHY on SA8775P") >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Yongxing Mou >> --- >> drivers/phy/qualcomm/phy-qcom-edp.c | 46 +++++++++++++++++++++++++++---------- >> 1 file changed, 34 insertions(+), 12 deletions(-) >> >