From: Neil Armstrong <neil.armstrong@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functions
Date: Thu, 29 Aug 2024 13:00:19 +0200 [thread overview]
Message-ID: <de807810-ab84-49eb-a96a-080f44452205@linaro.org> (raw)
In-Reply-To: <CAD=FV=Wke51vmTy7zZ+RV7oDoCGSeszOarhLGapdDrkByNyi-g@mail.gmail.com>
On 28/08/2024 18:32, Doug Anderson wrote:
> Hi,
>
> On Wed, Aug 28, 2024 at 9:03 AM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
>>
>> Make usage of the new _multi() mipi_dsi functions instead of the
>> deprecated macros, improving error handling and printing.
>>
>> bloat-o-meter gives a 12% gain on arm64:
>> Function old new delta
>> visionox_vtdr6130_unprepare 208 204 -4
>> visionox_vtdr6130_prepare 1192 896 -296
>> Total: Before=2348, After=2048, chg -12.78%
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 186 +++++++++++-------------
>> 1 file changed, 82 insertions(+), 104 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>> index 540099253e1b..ebe92871dbb6 100644
>> --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>> +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
>> @@ -40,120 +40,103 @@ static void visionox_vtdr6130_reset(struct visionox_vtdr6130 *ctx)
>> static int visionox_vtdr6130_on(struct visionox_vtdr6130 *ctx)
>> {
>> struct mipi_dsi_device *dsi = ctx->dsi;
>> - struct device *dev = &dsi->dev;
>> - int ret;
>> + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>>
>> dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>
> This isn't something you introduced in your patch, but I wonder if we
> should avoid setting the "MIPI_DSI_MODE_LPM" bit when the function
> returns an error?
Yeah it's unrelated to this change, but I'll investigate.
>
> In any case:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks,
Neil
next prev parent reply other threads:[~2024-08-29 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 16:03 [PATCH 0/2] drm/panel: annual cleanup of visionox vtdr6130 driver Neil Armstrong
2024-08-28 16:03 ` [PATCH 1/2] drm/panel: visionox-vtdr6130: switch to mipi_dsi wrapped functions Neil Armstrong
2024-08-28 16:32 ` Doug Anderson
2024-08-29 11:00 ` Neil Armstrong [this message]
2024-08-28 16:03 ` [PATCH 2/2] drm/panel: visionox-vtdr6130: switch to devm_regulator_bulk_get_const Neil Armstrong
2024-08-28 16:32 ` Doug Anderson
2024-08-29 11:22 ` [PATCH 0/2] drm/panel: annual cleanup of visionox vtdr6130 driver Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de807810-ab84-49eb-a96a-080f44452205@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®